| Message ID | 1521035556-26787-1-git-send-email-jpittman@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, 2018-03-14 at 09:52 -0400, John Pittman wrote: > In the comment for function alua_alloc_pg() the argument '@h' is > mistakenly referred to. Fix this by replacing it with the correct > argument reference, '@tpgs', and provide a short description. > > Signed-off-by: John Pittman <jpittman@redhat.com> > --- > drivers/scsi/device_handler/scsi_dh_alua.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c > b/drivers/scsi/device_handler/scsi_dh_alua.c > index 4b44325..ab89e42 100644 > --- a/drivers/scsi/device_handler/scsi_dh_alua.c > +++ b/drivers/scsi/device_handler/scsi_dh_alua.c > @@ -214,8 +214,8 @@ static struct alua_port_group > *alua_find_get_pg(char *id_str, size_t id_size, > /* > * alua_alloc_pg - Allocate a new port_group structure > * @sdev: scsi device > - * @h: alua device_handler data > * @group_id: port group id > + * @tpgs: target port group settings > * > * Allocate a new port_group structure for a given > * device. Looks good to me, Thanks Reviewed-by Laurence Oberman <loberman@redhat.com>
John, > In the comment for function alua_alloc_pg() the argument '@h' is > mistakenly referred to. Fix this by replacing it with the correct > argument reference, '@tpgs', and provide a short description. Applied to 4.17/scsi-queue, thanks!
diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c index 4b44325..ab89e42 100644 --- a/drivers/scsi/device_handler/scsi_dh_alua.c +++ b/drivers/scsi/device_handler/scsi_dh_alua.c @@ -214,8 +214,8 @@ static struct alua_port_group *alua_find_get_pg(char *id_str, size_t id_size, /* * alua_alloc_pg - Allocate a new port_group structure * @sdev: scsi device - * @h: alua device_handler data * @group_id: port group id + * @tpgs: target port group settings * * Allocate a new port_group structure for a given * device.
In the comment for function alua_alloc_pg() the argument '@h' is mistakenly referred to. Fix this by replacing it with the correct argument reference, '@tpgs', and provide a short description. Signed-off-by: John Pittman <jpittman@redhat.com> --- drivers/scsi/device_handler/scsi_dh_alua.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)