From patchwork Thu Apr 5 15:46:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaitra P B X-Patchwork-Id: 10324849 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2A594600CB for ; Thu, 5 Apr 2018 15:47:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1BF1C206AF for ; Thu, 5 Apr 2018 15:47:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1055327EED; Thu, 5 Apr 2018 15:47:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B9CA7206AF for ; Thu, 5 Apr 2018 15:47:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751638AbeDEPr5 (ORCPT ); Thu, 5 Apr 2018 11:47:57 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:54097 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbeDEPr4 (ORCPT ); Thu, 5 Apr 2018 11:47:56 -0400 Received: by mail-wm0-f66.google.com with SMTP id p9so6925532wmc.3 for ; Thu, 05 Apr 2018 08:47:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6iWA6sUa5rXFfypNpQN1UXsPOt9SpZCzXK+iRa+68mg=; b=EWQFslUmNbO45N2x5A+qYsAqzFtMW8ZQDum8Tqhpd0YndRwyMh4RHSHxXCc6pH/3OA 7R4XF30FmPQmgN8MT9CGWWcXqwGtb6kSycO8lpYbRbICed98fYXHrC/JmQiwUbBmLsuu /DzOi1sx6mTKJaN3m1DFc4nbwJG8HZ4MjUMLE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6iWA6sUa5rXFfypNpQN1UXsPOt9SpZCzXK+iRa+68mg=; b=t3EI2Ho4yRkaaiEaiITqojCX96oujeqsk/HdtwuFwKoxrhV+NJ413SSB4FGbAyXwUe fM+gYldWOvkGgG2MErO1xly3wkJgJ0nUXD40fweIxk7uUUdEIcLj+KoRuZ461qKcsKpv DpwIshrU0jU1+y66l/H60ErcU+fF7VB0fpmYFYPOKarQ1tF7E8CnMPAespxXyrynfBr8 yfqOrR1XSTfnAmW6qV3HivCxuqFggDDLZL5NKlBlj/DRhjol4Rk6+jeOnaxZOG1/nic+ ACwt9WscoFeJMBjAapAVM7jaJwQlvcixMECj8nXEAiXOKU7bSQGonxv7/t2uprTU/C1W Loww== X-Gm-Message-State: ALQs6tBgk1nXWnbhDxHJCUJugy00sxCbaQwOezdwLFwyOtOwVNQn/x7O MIQI7OICGf50Moy+jHnrRwc3ZO7o X-Google-Smtp-Source: AIpwx491GUKsK8If9BtzbxBcq2bD+7jM3/W45jNlL1iRwxy5YpYfa3pHhHmOt9t2on6Yv5wTN17JdQ== X-Received: by 10.80.134.120 with SMTP id 53mr3501138edt.187.1522943274655; Thu, 05 Apr 2018 08:47:54 -0700 (PDT) Received: from localhost.localdomain.localdomain ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id p91sm4745777edp.65.2018.04.05.08.47.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Apr 2018 08:47:54 -0700 (PDT) From: Chaitra P B To: linux-scsi@vger.kernel.org Cc: Sathya.Prakash@broadcom.com, sreekanth.reddy@broadcom.com, suganath-prabu.subramani@broadcom.com, Chaitra P B Subject: [PATCH v1 14/15] mpt3sas: fix possible memory leak. Date: Thu, 5 Apr 2018 11:46:36 -0400 Message-Id: <1522943197-5408-15-git-send-email-chaitra.basappa@broadcom.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1522943197-5408-1-git-send-email-chaitra.basappa@broadcom.com> References: <1522943197-5408-1-git-send-email-chaitra.basappa@broadcom.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In ioctl exit path driver refers ioc_list to free memory associated with diag buffers and event_log pointer used to save events by driver. If ctl_exit() func is called after unregistering driver, then ioc_list will be empty and hence driver will not be able to free the allocated memory which in turn causes memory leak. So call ctl_exit() function before unregistering mpt3sas driver. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index f3e1dc7..f8b5248 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -11283,10 +11283,10 @@ _mpt3sas_exit(void) pr_info("mpt3sas version %s unloading\n", MPT3SAS_DRIVER_VERSION); - pci_unregister_driver(&mpt3sas_driver); - mpt3sas_ctl_exit(hbas_to_enumerate); + pci_unregister_driver(&mpt3sas_driver); + scsih_exit(); }