From patchwork Fri Aug 31 04:34:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suganath Prabu S X-Patchwork-Id: 10583115 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EEBC814BD for ; Fri, 31 Aug 2018 04:35:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DEAF92C18F for ; Fri, 31 Aug 2018 04:35:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D2FBB2C1D8; Fri, 31 Aug 2018 04:35:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 828972C18F for ; Fri, 31 Aug 2018 04:35:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727240AbeHaIk7 (ORCPT ); Fri, 31 Aug 2018 04:40:59 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:52331 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726660AbeHaIk7 (ORCPT ); Fri, 31 Aug 2018 04:40:59 -0400 Received: by mail-wm0-f66.google.com with SMTP id y139-v6so3853415wmc.2 for ; Thu, 30 Aug 2018 21:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mQI7Kz+eUmlAYDX8/WCTH/9Q+lnyZaPfLRghzEpIaeI=; b=cIfrKQS+NjmGrzThfvL9IPvpFdqVp2+gBsCsnsYzFWePFcBBSIhuSvWn2kxNFzr+lX HCJqUoRUNER2ApwxpEObBoo+KHAQOF1ql33uyeYAlMczgwxAWa1Fa5pHtoeGcRq10wOU 4Ostt5JSt5+xqPEtpDK7VK3EqYtFTcuu9daH0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mQI7Kz+eUmlAYDX8/WCTH/9Q+lnyZaPfLRghzEpIaeI=; b=XoV+tfX7HJEcGa596l7F0ba1GtdH/Nj5Wf7etws/EwspYuuXQSlNHaN7AM/DvgP8Br rgGLGOFwKabjPrvukSl31ZeA7SdL6EYzphOQElGPDwrbgX7DnH4io+AoBgpk9I4JQMt+ 8dAV/aWvqg1dJvxz7RX9WUHfeDliKrogyzMdXMlP4SSr9tkpKzU9nffKUO+MAim8BdcV 6Uenn2+84XELGzbnSxg2GwqHoF7VaSNntpZu/PRJ5YAEYbs9bCr0OURn/2tcbrGh9yPu IXOg7cFzq2EQiuQqXGW2OrZVsPt7IbzxC/a2TWL3epkzLgMdG+YnViD4FxwI8cTJ89iJ 5g0w== X-Gm-Message-State: APzg51CHmqFFtLD5wDZ3VVup/O4sRfUgvYckyxeE+/FcpEjuz/wrOjv+ ff9nCktsvkXcIQp8zG2lMhKN0xd9E8k= X-Google-Smtp-Source: ANB0VdZi6Uk3ucPo2xkll7VkYVJNUs4zRnjdB1oeV3PCHRxehtAS4TE6cw1CHTPpfsmxXvdtdKBlsg== X-Received: by 2002:a1c:7301:: with SMTP id d1-v6mr3428330wmb.34.1535690122965; Thu, 30 Aug 2018 21:35:22 -0700 (PDT) Received: from localhost.localdomain.localdomain ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id h15-v6sm2261735wmb.21.2018.08.30.21.35.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Aug 2018 21:35:22 -0700 (PDT) From: Suganath Prabu S To: linux-scsi@vger.kernel.org Cc: Sathya.Prakash@broadcom.com, sreekanth.reddy@broadcom.com, Suganath Prabu S Subject: [Patch v1 6/7] mpt3sas: Fix driver modifying NVRAM/persistent data. Date: Fri, 31 Aug 2018 00:34:40 -0400 Message-Id: <1535690081-16116-7-git-send-email-suganath-prabu.subramani@broadcom.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1535690081-16116-1-git-send-email-suganath-prabu.subramani@broadcom.com> References: <1535690081-16116-1-git-send-email-suganath-prabu.subramani@broadcom.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP * If EEDPTagMode field in manufacturing page11 is set, unset it. This is needed to fix a hardware bug in SAS3/SAS2 cards, So, skipping EEDPTagMode changes in Manufacturing page11 for SAS35 controllers. * Fix driver modifying NVRAM/persistent data in Manufacturing page11 along with current copy. Driver should change only current copy of Manufacturing page11 Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +- drivers/scsi/mpt3sas/mpt3sas_config.c | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index a46ded8..92637c5 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -4235,7 +4235,7 @@ _base_static_config_pages(struct MPT3SAS_ADAPTER *ioc) * flag unset in NVDATA. */ mpt3sas_config_get_manufacturing_pg11(ioc, &mpi_reply, &ioc->manu_pg11); - if (ioc->manu_pg11.EEDPTagMode == 0) { + if ((!ioc->is_gen35_ioc) && (ioc->manu_pg11.EEDPTagMode == 0)) { pr_err("%s: overriding NVDATA EEDPTagMode setting\n", ioc->name); ioc->manu_pg11.EEDPTagMode &= ~0x3; diff --git a/drivers/scsi/mpt3sas/mpt3sas_config.c b/drivers/scsi/mpt3sas/mpt3sas_config.c index 5713a2d..f2a326a 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_config.c +++ b/drivers/scsi/mpt3sas/mpt3sas_config.c @@ -676,10 +676,6 @@ mpt3sas_config_set_manufacturing_pg11(struct MPT3SAS_ADAPTER *ioc, r = _config_request(ioc, &mpi_request, mpi_reply, MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, config_page, sizeof(*config_page)); - mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_WRITE_NVRAM; - r = _config_request(ioc, &mpi_request, mpi_reply, - MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, config_page, - sizeof(*config_page)); out: return r; }