From patchwork Wed Oct 31 13:23:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suganath Prabu S X-Patchwork-Id: 10662651 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D893213BF for ; Wed, 31 Oct 2018 13:24:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C807525F31 for ; Wed, 31 Oct 2018 13:24:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B8F0128935; Wed, 31 Oct 2018 13:24:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3EBA625F31 for ; Wed, 31 Oct 2018 13:24:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729422AbeJaWWv (ORCPT ); Wed, 31 Oct 2018 18:22:51 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:36908 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729420AbeJaWWu (ORCPT ); Wed, 31 Oct 2018 18:22:50 -0400 Received: by mail-wm1-f68.google.com with SMTP id p2-v6so14485291wmc.2 for ; Wed, 31 Oct 2018 06:24:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ejdq2iAILhXuBUzBm5b1+5FdxwkTFXYLi2UC8hcWNRQ=; b=Kf8+c6Q102OvZvnTwjj50CdT9IfffMtzPGIY+oCBNs2T1u3rtVgD4lq0peAaDuCQpH P+Mvx8ob870aZX2EJaWLvFjmB9mKWCVRPnd28fVb1yDXiS+Uc/PP1WSKsxIGhotmrn/e d6kwOY6WBHxlc02dhOSMPvZtEFUNOZBSLyadk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ejdq2iAILhXuBUzBm5b1+5FdxwkTFXYLi2UC8hcWNRQ=; b=GIfXs8QoPI8BT9aeOdzL2N28s3uIhbe96G0HrosHbRCQzLyv+TJso7Ssku2sN3T2Gd IjC0rAotsyjjjuD8SULMCfnUOZG5viEaA5akMBgwvTm3WUqy1Qq21LIKGBcQQxsAPD9I m1zhtq4Sd7FSSuAhDXm8ahiaw1faxezp9UMQidRA5SSZmlL/+M1w1p1AOhFtgsgz1WK8 MLRDBMMwGxEw8nJ7wFaMteqp8l22U+ve7ciH+qclVS0f1yBR5c6zqB0WlnZpbrntFcJO b5NMTb2OqQOYVFENsWc6OjxW5l/KAwKndvT5Ic3grRjltN5atgIFRgP+WilPtwaNZdSx SlgA== X-Gm-Message-State: AGRZ1gKQAi2Yzgwue0KYJ107bUxQVxMmccrCog7ejcpihE8+1WZ5guAf S4y3Pr8e1QhcnUiv4Wzt0l4gktzyU2U= X-Google-Smtp-Source: AJdET5cgS67HPw9NbceOniS8Yv9iCAHa90PIgYODhS8OKx+Wh7VgKCGjle4Bg3NnCTTQnsXfOlr4RQ== X-Received: by 2002:a1c:4601:: with SMTP id t1-v6mr2336964wma.102.1540992288664; Wed, 31 Oct 2018 06:24:48 -0700 (PDT) Received: from dhcp-10-123-74-106.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id r16-v6sm25202614wrv.21.2018.10.31.06.24.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Oct 2018 06:24:48 -0700 (PDT) From: Suganath Prabu To: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sathya.Prakash@broadcom.com, sreekanth.reddy@broadcom.com, Suganath Prabu Subject: [PATCH v7 7/8] mpt3sas: Fix driver modifying persistent data in Manufacturing page11 Date: Wed, 31 Oct 2018 18:53:38 +0530 Message-Id: <1540992219-20291-8-git-send-email-suganath-prabu.subramani@broadcom.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1540992219-20291-1-git-send-email-suganath-prabu.subramani@broadcom.com> References: <1540992219-20291-1-git-send-email-suganath-prabu.subramani@broadcom.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently driver is modifying both current & NVRAM/persistent data in Manufacturing page11. Driver should change only current copy of Manufacturing page11. It should not modify the persistent data. So removed the section of code where driver is modifying the persistent data of Manufacturing page11. Signed-off-by: Suganath Prabu --- drivers/scsi/mpt3sas/mpt3sas_config.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_config.c b/drivers/scsi/mpt3sas/mpt3sas_config.c index 257b66f..8516713 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_config.c +++ b/drivers/scsi/mpt3sas/mpt3sas_config.c @@ -658,10 +658,6 @@ mpt3sas_config_set_manufacturing_pg11(struct MPT3SAS_ADAPTER *ioc, r = _config_request(ioc, &mpi_request, mpi_reply, MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, config_page, sizeof(*config_page)); - mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_WRITE_NVRAM; - r = _config_request(ioc, &mpi_request, mpi_reply, - MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, config_page, - sizeof(*config_page)); out: return r; }