From patchwork Wed Jan 9 13:08:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shivasharan Srikanteshwara X-Patchwork-Id: 10754073 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D8E78746 for ; Wed, 9 Jan 2019 13:09:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C89C31FF0B for ; Wed, 9 Jan 2019 13:09:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BCCA8207A7; Wed, 9 Jan 2019 13:09:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6495A1FF0B for ; Wed, 9 Jan 2019 13:09:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730249AbfAINJN (ORCPT ); Wed, 9 Jan 2019 08:09:13 -0500 Received: from mail-yb1-f195.google.com ([209.85.219.195]:38091 "EHLO mail-yb1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729603AbfAINJM (ORCPT ); Wed, 9 Jan 2019 08:09:12 -0500 Received: by mail-yb1-f195.google.com with SMTP id x9so2954578ybj.5 for ; Wed, 09 Jan 2019 05:09:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id; bh=XTt61aMBa7T9taHhKV+0wbjj3L9apOaqV6WsWk44LUI=; b=QGzmIzdZxrw2kI0Ew+NLBkAzQJJaymqoDCA941HPw5ZM/fhgU7qMidyejgYRq/nsuw v5X35U4alyYdvAFY9Voh6dnq1u7wtaNnA4VwYlFTbReY9srnm34sutJqxxDHfFo6Y1GY AjJtjbNkRPGhPgxw5pgGKNCEjCoe6hbXH/v7Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=XTt61aMBa7T9taHhKV+0wbjj3L9apOaqV6WsWk44LUI=; b=Hj/J8UPnCZiUvURAuXlIUazMCeb26a+wOFr5V2i1gJP4NMJuglHPGmfxvIRDW+xS9Y 5CmxIF+Jmra5rbSjuQhi3EKYQoN8p8cfhPj9n0wX8Ce4FZPAviY9/UNqkPHTIebgHGMP yYsPwN8cMOpMcb0cx0Hr7BcgORg/y1EAmjnintQ2ufhE/QbmK4lI+opBaSsfLBhRMTo3 8hExYYGWRXwb7vmQcxeL7TKHTarIsCH2sHQ2qAnvflPiJPjoTgwA9R5y/Sh9b/9P0O4h 3LEuu9ideYeT+Ze25vZ1fjn20jE7N4RlNjw8/Z4cB5M8WbSQYKY5rP3psZUN7oUwXAVJ Nscg== X-Gm-Message-State: AJcUuke5l5anqmLTP7/T1Cj504+F9kcDTOjd3l39Oo2Q6UDAPMDAdI+4 M7XMpnhmmsorl0aGb0MSYk3XIAr1sYzK1+moFq8/E0M+8DhhKKGA3LDw4SoGQsThzTjpQ8XKO2f ZKpf80Si1UXK1lkW0kbimAahzIuWzZIuRBwYAex3H2RKgQlcmn6iTCLaLw0XaJ3y64I8vOYwpqQ bpJc5+vwGlvincZ23i4vUo X-Google-Smtp-Source: ALg8bN7DBIBgqFDtUj/ZRvjRvlU1LysqQ5rf4iJLfxjP4YfAK6w4XmmUfx8nTkQuHCxNOzuFuvxeGw== X-Received: by 2002:a25:add8:: with SMTP id d24mr5461559ybe.146.1547039351197; Wed, 09 Jan 2019 05:09:11 -0800 (PST) Received: from dhcp-135-24-192-142.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id d3sm38381042ywh.58.2019.01.09.05.09.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Jan 2019 05:09:10 -0800 (PST) From: Shivasharan S To: linux-scsi@vger.kernel.org Cc: kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, thenzl@redhat.com, Shivasharan S Subject: [PATCH] megaraid_sas: Retry reads of outbound_intr_status reg Date: Wed, 9 Jan 2019 05:08:37 -0800 Message-Id: <1547039317-1421-1-git-send-email-shivasharan.srikanteshwara@broadcom.com> X-Mailer: git-send-email 2.4.3 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP commit 272652fcbf1a ("scsi: megaraid_sas: add retry logic in megasas_readl") missed changing readl to megasas_readl in megasas_clear_intr_fusion(). For Aero controllers, reads of outbound_intr_status register needs to be retried. Reported-by: Tomas Henzl Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c index 211c17c33aa0..2665dbdcf2f8 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c @@ -175,7 +175,8 @@ megasas_clear_intr_fusion(struct megasas_instance *instance) /* * Check if it is our interrupt */ - status = readl(®s->outbound_intr_status); + status = megasas_readl(instance, + ®s->outbound_intr_status); if (status & 1) { writel(status, ®s->outbound_intr_status);