| Message ID | 1590632686-17866-1-git-send-email-cang@codeaurora.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | be32acff43800c87dc5c707f5d47cc607b76b653 |
| Headers | show |
| Series | [v1,1/1] scsi: ufs: Don't update urgent bkops level when toggle auto bkops | expand |
On Wed, 2020-05-27 at 19:24 -0700, Can Guo wrote: > Urgent bkops level is used to compare against actual bkops status read > from UFS device. Urgent bkops level is set during initialization and might > be updated in exception event handler during runtime, but it should not be > updated to the actual bkops status every time when auto bkops is toggled. > Otherwise, if urgent bkops level is updated to 0, auto bkops shall always > be kept enabled. > > Fixes: 24366c2afbb0 ("scsi: ufs: Recheck bkops level if bkops is disabled") > Signed-off-by: Can Guo <cang@codeaurora.org> > --- > drivers/scsi/ufs/ufshcd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 1827b57..178322e 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -5133,7 +5133,6 @@ static int ufshcd_bkops_ctrl(struct ufs_hba *hba, > err = ufshcd_enable_auto_bkops(hba); > else > err = ufshcd_disable_auto_bkops(hba); > - hba->urgent_bkops_lvl = curr_status; > out: > return err; > } Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
On Wed, 27 May 2020 19:24:42 -0700, Can Guo wrote: > Urgent bkops level is used to compare against actual bkops status read > from UFS device. Urgent bkops level is set during initialization and might > be updated in exception event handler during runtime, but it should not be > updated to the actual bkops status every time when auto bkops is toggled. > Otherwise, if urgent bkops level is updated to 0, auto bkops shall always > be kept enabled. Applied to 5.8/scsi-queue, thanks! [1/1] scsi: ufs: Don't update urgent bkops level when toggling auto bkops https://git.kernel.org/mkp/scsi/c/be32acff4380
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 1827b57..178322e 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -5133,7 +5133,6 @@ static int ufshcd_bkops_ctrl(struct ufs_hba *hba, err = ufshcd_enable_auto_bkops(hba); else err = ufshcd_disable_auto_bkops(hba); - hba->urgent_bkops_lvl = curr_status; out: return err; }
Urgent bkops level is used to compare against actual bkops status read from UFS device. Urgent bkops level is set during initialization and might be updated in exception event handler during runtime, but it should not be updated to the actual bkops status every time when auto bkops is toggled. Otherwise, if urgent bkops level is updated to 0, auto bkops shall always be kept enabled. Fixes: 24366c2afbb0 ("scsi: ufs: Recheck bkops level if bkops is disabled") Signed-off-by: Can Guo <cang@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 1 - 1 file changed, 1 deletion(-)