From patchwork Wed Dec 2 03:47:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Can Guo X-Patchwork-Id: 11944613 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE976C83013 for ; Wed, 2 Dec 2020 03:48:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 577A2206D5 for ; Wed, 2 Dec 2020 03:48:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728279AbgLBDsc (ORCPT ); Tue, 1 Dec 2020 22:48:32 -0500 Received: from labrats.qualcomm.com ([199.106.110.90]:10547 "EHLO labrats.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727033AbgLBDsc (ORCPT ); Tue, 1 Dec 2020 22:48:32 -0500 IronPort-SDR: MCwQ/Bbj6jLFjbYgKXexx2aXabVporQ9xLaeL5o55vwWLPYJyevxED93bt04mh8IWTIpn/LeyG ZR6JALd7e17YHyEdMJtP/7a3pbH1MB3Q4VidqzzA28XxGl+yli/eoz6slqkPp37s22ra+dkuCk kw0mM2LMd82wR7XCi9gfWeVygbr4NMHIa2dKlIDlUI/q+fvEJZArn9DUaIEy4mlZxF6kCq3IIl S5JBdJKa1bJHpJFbeJIDqsSNDb0tm0CwpgZj2FcUPi4FdO/wifcC21gppuemHbEI8K9kh8rGSp pR4= X-IronPort-AV: E=Sophos;i="5.78,385,1599548400"; d="scan'208";a="47538812" Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by labrats.qualcomm.com with ESMTP; 01 Dec 2020 19:47:28 -0800 X-QCInternal: smtphost Received: from stor-presley.qualcomm.com ([192.168.140.85]) by ironmsg04-sd.qualcomm.com with ESMTP; 01 Dec 2020 19:47:26 -0800 Received: by stor-presley.qualcomm.com (Postfix, from userid 359480) id DE2FA2106B; Tue, 1 Dec 2020 19:47:26 -0800 (PST) From: Can Guo To: asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, cang@codeaurora.org Cc: Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , Bart Van Assche , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v4 3/3] scsi: ufs: Print host regs in IRQ handler when AH8 error happens Date: Tue, 1 Dec 2020 19:47:08 -0800 Message-Id: <1606880829-27500-4-git-send-email-cang@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1606880829-27500-1-git-send-email-cang@codeaurora.org> References: <1606880829-27500-1-git-send-email-cang@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org When AH8 error happens, all the regs and states are dumped in err handler. Sometime we need to look into host regs right after AH8 error happens, which is before leaving the IRQ handler. Reviewed-by: Bao D. Nguyen Reviewed-by: Asutosh Das Reviewed-by: Hongwu Su Signed-off-by: Can Guo --- drivers/scsi/ufs/ufshcd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index cd7394e..a7857f6 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -6057,7 +6057,8 @@ static irqreturn_t ufshcd_check_errors(struct ufs_hba *hba) hba->saved_uic_err |= hba->uic_error; /* dump controller state before resetting */ - if ((hba->saved_err & (INT_FATAL_ERRORS)) || + if ((hba->saved_err & + (INT_FATAL_ERRORS | UFSHCD_UIC_HIBERN8_MASK)) || (hba->saved_uic_err && (hba->saved_uic_err != UFSHCD_UIC_PA_GENERIC_ERROR))) { dev_err(hba->dev, "%s: saved_err 0x%x saved_uic_err 0x%x\n",