diff mbox series

[v2] scsi: ufs: see link lost as fatal

Message ID 1642743475-54275-1-git-send-email-kwmad.kim@samsung.com (mailing list archive)
State Accepted
Headers show
Series [v2] scsi: ufs: see link lost as fatal | expand

Commit Message

Kiwoong Kim Jan. 21, 2022, 5:37 a.m. UTC
v1 -> v2: modify comment

This event is raised when link is lost as specified
in UFSHCI spec and that means communication is
not possible. Thus initializing UFS interface needs to be done.

This patch is to make UFS driver see Link Lost as fatal by using
INT_FATAL_ERRORS. This lead to host reset whenever a link lost
interrupt occurs.

Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com>
---
 drivers/scsi/ufs/ufshci.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Martin K. Petersen Jan. 25, 2022, 5:41 a.m. UTC | #1
On Fri, 21 Jan 2022 14:37:55 +0900, Kiwoong Kim wrote:

> v1 -> v2: modify comment
> 
> This event is raised when link is lost as specified
> in UFSHCI spec and that means communication is
> not possible. Thus initializing UFS interface needs to be done.
> 
> This patch is to make UFS driver see Link Lost as fatal by using
> INT_FATAL_ERRORS. This lead to host reset whenever a link lost
> interrupt occurs.
> 
> [...]

Applied to 5.17/scsi-fixes, thanks!

[1/1] scsi: ufs: see link lost as fatal
      https://git.kernel.org/mkp/scsi/c/c99b9b230149
diff mbox series

Patch

diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
index 6a295c8..a7ff0e5 100644
--- a/drivers/scsi/ufs/ufshci.h
+++ b/drivers/scsi/ufs/ufshci.h
@@ -142,7 +142,8 @@  static inline u32 ufshci_version(u32 major, u32 minor)
 #define INT_FATAL_ERRORS	(DEVICE_FATAL_ERROR |\
 				CONTROLLER_FATAL_ERROR |\
 				SYSTEM_BUS_FATAL_ERROR |\
-				CRYPTO_ENGINE_FATAL_ERROR)
+				CRYPTO_ENGINE_FATAL_ERROR |\
+				UIC_LINK_LOST)
 
 /* HCS - Host Controller Status 30h */
 #define DEVICE_PRESENT				0x1