| Message ID | 1650533091-28815-1-git-send-email-baihaowen@meizu.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | scsi: qla4xxx: Drop redundant memset | expand |
On Thu, 21 Apr 2022 17:24:50 +0800, Haowen Bai wrote: > The region set by the call to memset is immediately overwritten by the > subsequent call to memcpy. So we drop redundant memset. > > Applied to 5.19/scsi-queue, thanks! [1/1] scsi: qla4xxx: Drop redundant memset https://git.kernel.org/mkp/scsi/c/bda57fede0a6
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 3f6cb2a5c2c2..9e849f6b0d0f 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -671,7 +671,6 @@ static void qla4xxx_create_chap_list(struct scsi_qla_host *ha) goto exit_chap_list; } - memset(ha->chap_list, 0, chap_size); memcpy(ha->chap_list, chap_flash_data, chap_size); exit_chap_list:
The region set by the call to memset is immediately overwritten by the subsequent call to memcpy. So we drop redundant memset. Signed-off-by: Haowen Bai <baihaowen@meizu.com> --- drivers/scsi/qla4xxx/ql4_os.c | 1 - 1 file changed, 1 deletion(-)