diff mbox series

[v6,1/4] ufs: core: Remove redundant wb check

Message ID 1671011427-26184-2-git-send-email-Arthur.Simchaev@wdc.com (mailing list archive)
State Deferred
Headers show
Series ufs: core: Always read the descriptors with max length | expand

Commit Message

Arthur Simchaev Dec. 14, 2022, 9:50 a.m. UTC 
We used to use the extended-feature field in the device descriptor,
as an indication that the device supports ufs2.2 or later.
Remove that as this check is specifically done few lines above.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Bean Huo <beanhuo@micron.com>
Signed-off-by: Arthur Simchaev <Arthur.Simchaev@wdc.com>
---
 drivers/ufs/core/ufshcd.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Bean Huo Dec. 15, 2022, 4:06 p.m. UTC | #1 
Arthur,

You forgot to add Stanley's reviewed tag:

Reviewed-by: Stanley Chu<stanley.chu@mediatek.com>

On 14.12.22 10:50 AM, Arthur Simchaev wrote:
> We used to use the extended-feature field in the device descriptor,
> as an indication that the device supports ufs2.2 or later.
> Remove that as this check is specifically done few lines above.
>
> Reviewed-by: Bart Van Assche<bvanassche@acm.org>
> Reviewed-by: Bean Huo<beanhuo@micron.com>
> Signed-off-by: Arthur Simchaev<Arthur.Simchaev@wdc.com>
diff mbox series

Patch

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index c63cd8b..c43dc2e 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -7616,10 +7616,6 @@  static void ufshcd_wb_probe(struct ufs_hba *hba, const u8 *desc_buf)
 	     (hba->dev_quirks & UFS_DEVICE_QUIRK_SUPPORT_EXTENDED_FEATURES)))
 		goto wb_disabled;
 
-	if (hba->desc_size[QUERY_DESC_IDN_DEVICE] <
-	    DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP + 4)
-		goto wb_disabled;
-
 	ext_ufs_feature = get_unaligned_be32(desc_buf +
 					DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP);