| Message ID | 20150317200252.19856.96524.stgit@brunhilda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 03/17/2015 09:02 PM, Don Brace wrote: > From: Stephen Cameron <stephenmcameron@gmail.com> > > make tracking of outstanding commands more robust > > Reviewed-by: Scott Teel <scott.teel@pmcs.com> > Reviewed-by: Kevin Barnett <kevin.barnett@pmcs.com> > Signed-off-by: Don Brace <don.brace@pmcs.com> > --- > drivers/scsi/hpsa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c > index fe860a6..3a06812 100644 > --- a/drivers/scsi/hpsa.c > +++ b/drivers/scsi/hpsa.c > @@ -6945,7 +6945,7 @@ static void fail_all_outstanding_cmds(struct ctlr_info *h) > if (refcount > 1) { > c->err_info->CommandStatus = CMD_CTLR_LOCKUP; > finish_cmd(c); > - failcount++; The failcount should stay untouched. What is the status of this series is it already accepted or makes reviewing still sense? Christopher has commented on 2/41 + 6/41 in the previous V2, has this been answered/resolved? Thanks, Tomas > + atomic_dec(&h->commands_outstanding); > } > cmd_free(h, c); > } > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index fe860a6..3a06812 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -6945,7 +6945,7 @@ static void fail_all_outstanding_cmds(struct ctlr_info *h) if (refcount > 1) { c->err_info->CommandStatus = CMD_CTLR_LOCKUP; finish_cmd(c); - failcount++; + atomic_dec(&h->commands_outstanding); } cmd_free(h, c); }