From patchwork Sat Jun 6 00:45:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vaishali Thakkar X-Patchwork-Id: 6558651 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AE010C0020 for ; Sat, 6 Jun 2015 00:45:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D7F66207EE for ; Sat, 6 Jun 2015 00:45:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00D84207F2 for ; Sat, 6 Jun 2015 00:45:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932369AbbFFApU (ORCPT ); Fri, 5 Jun 2015 20:45:20 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:33158 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751582AbbFFApS (ORCPT ); Fri, 5 Jun 2015 20:45:18 -0400 Received: by padev16 with SMTP id ev16so2182066pad.0; Fri, 05 Jun 2015 17:45:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=CWH2l+DXcC5FFjUMjCbOB1M5na7pvrcpn5E37bAZoaQ=; b=SILb3hozb0dIK1kCPPx5SzhamWbbZh9dibv0NSEWJWcIp7nIa0hk6WT3LcXgE+BFt2 7zGlKF8JW3/iKKiNJWZt/+DnI0N+xKefTh35lrzCbw3kp7JZ88ppLGvcD7jNwBQuzNBC pBstiJDEtRPsi+0RdHQaPcQypW5ObPr0GMA8N5i336N3rVNA8N5XEgifSv99hRY05UzB WgPr+TU+hWrV1tN31HxoNSHZF4tYo+9OzEIM4lS+XLOtl4GYWO+9XER/Rh+MAL+9RTlx n22xmuHb7pcRXtelQO8fGsxLy42JXa3xErqpNKaYOHoAio7iwmuJAFRpLwgBhbSIpVt7 ESOw== X-Received: by 10.70.132.195 with SMTP id ow3mr9708401pdb.87.1433551517923; Fri, 05 Jun 2015 17:45:17 -0700 (PDT) Received: from vaishali-Ideapad-Z570 ([43.249.235.16]) by mx.google.com with ESMTPSA id ve1sm7803251pbc.52.2015.06.05.17.45.15 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 05 Jun 2015 17:45:16 -0700 (PDT) Date: Sat, 6 Jun 2015 06:15:12 +0530 From: Vaishali Thakkar To: "James E.J. Bottomley" Cc: QLogic-Storage-Upstream@qlogic.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Julia Lawall Subject: [PATCH v2] [SCSI] qla4xxx: Replace __constant_cpu_to_le16 with cpu_to_le16 Message-ID: <20150606004512.GA8197@vaishali-Ideapad-Z570> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In big endian cases, macro cpu_to_le16 unfolds to __swab16 which provides special case for constants. In little endian cases, __constant_cpu_to_le16 and cpu_to_le16 expand directly to the same expression. So, replace __constant_cpu_to_le16 with cpu_to_le16 with the goal of getting rid of the definition of __constant_cpu_to_le16 completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ - __constant_cpu_to_le16(x) + cpu_to_le16(x) Signed-off-by: Vaishali Thakkar --- Changes since v1: - Make subject more concise --- drivers/scsi/qla4xxx/ql4_nx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c index 7c33658..06d6cce 100644 --- a/drivers/scsi/qla4xxx/ql4_nx.c +++ b/drivers/scsi/qla4xxx/ql4_nx.c @@ -3741,9 +3741,9 @@ qla4_8xxx_get_flt_info(struct scsi_qla_host *ha, uint32_t flt_addr) goto no_flash_data; } - if (*wptr == __constant_cpu_to_le16(0xffff)) + if (*wptr == cpu_to_le16(0xffff)) goto no_flash_data; - if (flt->version != __constant_cpu_to_le16(1)) { + if (flt->version != cpu_to_le16(1)) { DEBUG2(ql4_printk(KERN_INFO, ha, "Unsupported FLT detected: " "version=0x%x length=0x%x checksum=0x%x.\n", le16_to_cpu(flt->version), le16_to_cpu(flt->length), @@ -3846,7 +3846,7 @@ qla4_82xx_get_fdt_info(struct scsi_qla_host *ha) qla4_82xx_read_optrom_data(ha, (uint8_t *)ha->request_ring, hw->flt_region_fdt << 2, OPTROM_BURST_SIZE); - if (*wptr == __constant_cpu_to_le16(0xffff)) + if (*wptr == cpu_to_le16(0xffff)) goto no_flash_data; if (fdt->sig[0] != 'Q' || fdt->sig[1] != 'L' || fdt->sig[2] != 'I' ||