From patchwork Fri Oct 2 12:52:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 7315321 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 719FE9F1B9 for ; Fri, 2 Oct 2015 12:52:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A5DBB208BE for ; Fri, 2 Oct 2015 12:52:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2F61208BD for ; Fri, 2 Oct 2015 12:52:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752581AbbJBMw2 (ORCPT ); Fri, 2 Oct 2015 08:52:28 -0400 Received: from verein.lst.de ([213.95.11.211]:43917 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751919AbbJBMw0 (ORCPT ); Fri, 2 Oct 2015 08:52:26 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id A1CB2691D8; Fri, 2 Oct 2015 14:52:24 +0200 (CEST) Date: Fri, 2 Oct 2015 14:52:24 +0200 From: Christoph Hellwig To: Paul Mackerras Cc: Christoph Hellwig , James Bottomley , linux-scsi@vger.kernel.org, Tejun Heo Subject: Re: Bugs in multipath scsi in 4.3-rc2 Message-ID: <20151002125224.GA14899@lst.de> References: <20150925121636.GC12540@fergus.ozlabs.ibm.com> <20150925151802.GB20282@lst.de> <1443202278.2188.13.camel@HansenPartnership.com> <20150930151449.GC26299@lst.de> <20151001043453.GA2893@iris.ozlabs.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20151001043453.GA2893@iris.ozlabs.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Oct 01, 2015 at 02:34:54PM +1000, Paul Mackerras wrote: > I still get the warning: Ok, I sent you the wrong patch. scsi_dh_add_device is the function that needs to switch to use __scsi_dh_lookup. New version below: --- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c index edb044a..cc9ea81 100644 --- a/drivers/scsi/scsi_dh.c +++ b/drivers/scsi/scsi_dh.c @@ -226,7 +226,7 @@ int scsi_dh_add_device(struct scsi_device *sdev) drv = scsi_dh_find_driver(sdev); if (drv) - devinfo = scsi_dh_lookup(drv); + devinfo = __scsi_dh_lookup(drv); if (devinfo) err = scsi_dh_handler_attach(sdev, devinfo); return err;