diff mbox

[2/2] ipr: Remove redundant messages at adapter init time

Message ID 20160916215137.7DE02B204E@b01ledav03.gho.pok.ibm.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Brian King Sept. 16, 2016, 9:51 p.m. UTC
Whenever multiple HRRQs are enabled, which is the default
setting now, we end up seeing the following message logged
prior to initialization of each HRRQ:

Starting IOA initialization sequence

This results in 16 of these messages on most adapters, which
serves little purpose. Change to just log this once.

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
---

 drivers/scsi/ipr.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Gabriel Krisman Bertazi Sept. 16, 2016, 10 p.m. UTC | #1
Brian King <brking@linux.vnet.ibm.com> writes:

> Whenever multiple HRRQs are enabled, which is the default
> setting now, we end up seeing the following message logged
> prior to initialization of each HRRQ:
>
> Starting IOA initialization sequence
>
> This results in 16 of these messages on most adapters, which
> serves little purpose. Change to just log this once.


Reviewed-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Martin K. Petersen Sept. 19, 2016, 3:59 p.m. UTC | #2
>>>>> "Brian" == Brian King <brking@linux.vnet.ibm.com> writes:

Brian> Whenever multiple HRRQs are enabled, which is the default setting
Brian> now, we end up seeing the following message logged prior to
Brian> initialization of each HRRQ:

Brian> Starting IOA initialization sequence

Brian> This results in 16 of these messages on most adapters, which
Brian> serves little purpose. Change to just log this once.

Applied to 4.9/scsi-queue.
diff mbox

Patch

diff -puN drivers/scsi/ipr.c~ipr_hrrq_message drivers/scsi/ipr.c
--- linux-2.6.git/drivers/scsi/ipr.c~ipr_hrrq_message	2016-08-30 20:53:06.909099536 -0500
+++ linux-2.6.git-bjking1/drivers/scsi/ipr.c	2016-08-30 20:53:06.915099497 -0500
@@ -8049,7 +8049,8 @@  static int ipr_ioafp_identify_hrrq(struc
 
 	ENTER;
 	ipr_cmd->job_step = ipr_ioafp_std_inquiry;
-	dev_info(&ioa_cfg->pdev->dev, "Starting IOA initialization sequence.\n");
+	if (ioa_cfg->identify_hrrq_index == 0)
+		dev_info(&ioa_cfg->pdev->dev, "Starting IOA initialization sequence.\n");
 
 	if (ioa_cfg->identify_hrrq_index < ioa_cfg->hrrq_num) {
 		hrrq = &ioa_cfg->hrrq[ioa_cfg->identify_hrrq_index];