diff mbox

[2/2] scsi: qla2xxx: make msix_entries const

Message ID 20161226132310.3204-2-nicolas.iooss_linux@m4x.org (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Nicolas Iooss Dec. 26, 2016, 1:23 p.m. UTC 
msix_entries and qla82xx_msix_entries arrays are never modified in
drivers/scsi/qla2xxx/qla_isr.c. Move their contents to read-only data.

Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
 drivers/scsi/qla2xxx/qla_isr.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Bart Van Assche Jan. 2, 2017, 8:17 a.m. UTC | #1 
On Mon, 2016-12-26 at 14:23 +0100, Nicolas Iooss wrote:
> msix_entries and qla82xx_msix_entries arrays are never modified in

> drivers/scsi/qla2xxx/qla_isr.c. Move their contents to read-only data.


Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Madhani, Himanshu Jan. 6, 2017, 5:06 p.m. UTC | #2 
On 12/26/16, 5:23 AM, "Nicolas Iooss" <nicolas.iooss_linux@m4x.org> wrote:

>msix_entries and qla82xx_msix_entries arrays are never modified in

>drivers/scsi/qla2xxx/qla_isr.c. Move their contents to read-only data.

>

>Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>

>---

> drivers/scsi/qla2xxx/qla_isr.c | 6 +++---

> 1 file changed, 3 insertions(+), 3 deletions(-)

>

>diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c

>index 474b415217df..b9c113e47346 100644

>--- a/drivers/scsi/qla2xxx/qla_isr.c

>+++ b/drivers/scsi/qla2xxx/qla_isr.c

>@@ -3003,14 +3003,14 @@ struct qla_init_msix_entry {

> 	irq_handler_t handler;

> };

> 

>-static struct qla_init_msix_entry msix_entries[] = {

>+static const struct qla_init_msix_entry msix_entries[] = {

> 	{ "qla2xxx (default)", qla24xx_msix_default },

> 	{ "qla2xxx (rsp_q)", qla24xx_msix_rsp_q },

> 	{ "qla2xxx (atio_q)", qla83xx_msix_atio_q },

> 	{ "qla2xxx (qpair_multiq)", qla2xxx_msix_rsp_q },

> };

> 

>-static struct qla_init_msix_entry qla82xx_msix_entries[] = {

>+static const struct qla_init_msix_entry qla82xx_msix_entries[] = {

> 	{ "qla2xxx (default)", qla82xx_msix_default },

> 	{ "qla2xxx (rsp_q)", qla82xx_msix_rsp_q },

> };

>@@ -3284,7 +3284,7 @@ qla2x00_free_irqs(scsi_qla_host_t *vha)

> int qla25xx_request_irq(struct qla_hw_data *ha, struct qla_qpair *qpair,

> 	struct qla_msix_entry *msix, int vector_type)

> {

>-	struct qla_init_msix_entry *intr = &msix_entries[vector_type];

>+	const struct qla_init_msix_entry *intr = &msix_entries[vector_type];

> 	scsi_qla_host_t *vha = pci_get_drvdata(ha->pdev);

> 	int ret;

> 

>-- 

>2.11.0

>


Looks Good. 

Acked-By: Himanshu Madhani <himanshu.madhani@cavium.com>


>
diff mbox

Patch

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index 474b415217df..b9c113e47346 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -3003,14 +3003,14 @@  struct qla_init_msix_entry {
 	irq_handler_t handler;
 };
 
-static struct qla_init_msix_entry msix_entries[] = {
+static const struct qla_init_msix_entry msix_entries[] = {
 	{ "qla2xxx (default)", qla24xx_msix_default },
 	{ "qla2xxx (rsp_q)", qla24xx_msix_rsp_q },
 	{ "qla2xxx (atio_q)", qla83xx_msix_atio_q },
 	{ "qla2xxx (qpair_multiq)", qla2xxx_msix_rsp_q },
 };
 
-static struct qla_init_msix_entry qla82xx_msix_entries[] = {
+static const struct qla_init_msix_entry qla82xx_msix_entries[] = {
 	{ "qla2xxx (default)", qla82xx_msix_default },
 	{ "qla2xxx (rsp_q)", qla82xx_msix_rsp_q },
 };
@@ -3284,7 +3284,7 @@  qla2x00_free_irqs(scsi_qla_host_t *vha)
 int qla25xx_request_irq(struct qla_hw_data *ha, struct qla_qpair *qpair,
 	struct qla_msix_entry *msix, int vector_type)
 {
-	struct qla_init_msix_entry *intr = &msix_entries[vector_type];
+	const struct qla_init_msix_entry *intr = &msix_entries[vector_type];
 	scsi_qla_host_t *vha = pci_get_drvdata(ha->pdev);
 	int ret;