From patchwork Fri May 19 08:04:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9736159 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0B067601A1 for ; Fri, 19 May 2017 08:05:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CCED22889E for ; Fri, 19 May 2017 08:05:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C1A92288E5; Fri, 19 May 2017 08:05:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7C7302889E for ; Fri, 19 May 2017 08:05:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752055AbdESIFH (ORCPT ); Fri, 19 May 2017 04:05:07 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:56820 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751976AbdESIFG (ORCPT ); Fri, 19 May 2017 04:05:06 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue104 [212.227.15.145]) with ESMTPA (Nemesis) id 0MV5B7-1dUegm38d3-00YV5d; Fri, 19 May 2017 10:04:49 +0200 From: Arnd Bergmann To: James Smart , Dick Kennedy Cc: Arnd Bergmann , "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke , Johannes Thumshirn , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] lpfc: nvmet_fc: fix format string Date: Fri, 19 May 2017 10:04:31 +0200 Message-Id: <20170519080447.1043039-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:KAYRjFWr9716eWIdWBOMLw4O4Eo/eDfjMY/p99dQv9Bg9aco5sV Yw3BO9BvYXXEwogA5USXq+1MpVX5EPTHHwWYLqiuxDxa+1AHh82198AQjy/7kJWJmE//yj9 HPyyJtztCgeGF3r+WitHTq9ibc9ClJDNXt4ybXyNBPc1jiMZn/rsU6AGrt/OeuvjE5c1kUD FL/iqfLI9pek3mE9Z7BOg== X-UI-Out-Filterresults: notjunk:1; V01:K0:x+Z2RmMWu3o=:dBqiFyt9eFty5SH49QzZQ7 /T+tpE0sn0C4UWYM5wNgEORQGOTM8HlBs59O5+Vz32wgxG43Qisc8A46eWD49bVDPtwQ6IyBW FP98cCGXKg6v751jbaRzvqojuVljlLL8Dw+m/0hnTv0HGulhpV0pxvp1yx1yCR4rIletKR+aN jlHRt0+2qB2x7fLCbepdwb4IKyCODuji8oKBEKqY0flyVvwAx6gsGLhV70EUTaL/HSQjN4/GF rzeNTfqQp/fR0/QHU362J1hVQXbFwXRgUNF6pbVTNiqFI9+/w2prRzrxvZ6qaYvtEn3busJ8N CG3+7IWXt5Sx8wHu33YriO1ITD/NbTr8Dca2p1gy2Lt+pFtixSaN3xkLY66UJIMonPQSj1ZGU 47SijfFBFGnZgp3YMtLlM0uGh5AO8v/ndiv3Zz/lCfBATtVfr9nRqhML2ucJ1iTvyBr6M0ia6 DRB7EB5TnhRXbEqn/08wKOIWBiHVysiab6xR4f3ekbsQw6yB5u9eLiV7vb9IYnaItTieH2H7d 4Rm4T18651K2obgZBPkcbUzCjmmqx49dVEpfluB70AtBHMT7ccKIRK5NokD0FraqUxDMVS7oS /z36MXBdaGjQDwgRj7Kd5g34DVrEFI/aw2YceR11MPRyx3GpEIt139JHnGvn2CXTeR+Iw32wL 1iCdsDs4aurSiDySXq1OvOEfLLadPWlZzssyveVqS9pv+MrCYOp+GJ8nJTvNlbeKdBt0= Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The lpfc_nvmeio_data() tracing helper always takes a format string and three additional arguments. The latest caller has a format string with only two integer arguments, causing this harmless warning: drivers/scsi/lpfc/lpfc_nvmet.c: In function 'lpfc_nvmet_xmt_fcp_release': drivers/scsi/lpfc/lpfc_nvmet.c:802:25: error: too many arguments for format [-Werror=format-extra-args] lpfc_nvmeio_data(phba, "NVMET FCP FREE: xri x%x ste %d\n", ctxp->oxid, We could add a dummy argument here, but it seems reasonable to print the 'abort' flag as the third argument. Fixes: 19b58d9473e8 ("nvmet_fc: add req_release to lldd api") Signed-off-by: Arnd Bergmann Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvmet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c index f94294b77b7b..24d54dd016d4 100644 --- a/drivers/scsi/lpfc/lpfc_nvmet.c +++ b/drivers/scsi/lpfc/lpfc_nvmet.c @@ -799,8 +799,8 @@ lpfc_nvmet_xmt_fcp_release(struct nvmet_fc_target_port *tgtport, } spin_unlock_irqrestore(&ctxp->ctxlock, flags); - lpfc_nvmeio_data(phba, "NVMET FCP FREE: xri x%x ste %d\n", ctxp->oxid, - ctxp->state, 0); + lpfc_nvmeio_data(phba, "NVMET FCP FREE: xri x%x ste %d abt %d\n", ctxp->oxid, + ctxp->state, aborting); atomic_inc(&lpfc_nvmep->xmt_fcp_release);