| Message ID | 20170713161122.89375-2-khazhy@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Thanks. Acked-by: Chris Leech <cleech@redhat.com> On Thu, Jul 13, 2017 at 09:11:22AM -0700, 'Khazhismel Kumykov' via open-iscsi wrote: > iscsi_session_teardown was the only user of this function. Function > currently is just short for iscsi_remove_session + iscsi_free_session. > > Signed-off-by: Khazhismel Kumykov <khazhy@google.com> > --- > drivers/scsi/scsi_transport_iscsi.c | 16 ---------------- > include/scsi/scsi_transport_iscsi.h | 1 - > 2 files changed, 17 deletions(-) > > diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c > index a424eaeafeb0..924ac408d8a9 100644 > --- a/drivers/scsi/scsi_transport_iscsi.c > +++ b/drivers/scsi/scsi_transport_iscsi.c > @@ -2210,22 +2210,6 @@ void iscsi_free_session(struct iscsi_cls_session *session) > } > EXPORT_SYMBOL_GPL(iscsi_free_session); > > -/** > - * iscsi_destroy_session - destroy iscsi session > - * @session: iscsi_session > - * > - * Can be called by a LLD or iscsi_transport. There must not be > - * any running connections. > - */ > -int iscsi_destroy_session(struct iscsi_cls_session *session) > -{ > - iscsi_remove_session(session); > - ISCSI_DBG_TRANS_SESSION(session, "Completing session destruction\n"); > - iscsi_free_session(session); > - return 0; > -} > -EXPORT_SYMBOL_GPL(iscsi_destroy_session); > - > /** > * iscsi_create_conn - create iscsi class connection > * @session: iscsi cls session > diff --git a/include/scsi/scsi_transport_iscsi.h b/include/scsi/scsi_transport_iscsi.h > index 6183d20a01fb..b266d2a3bcb1 100644 > --- a/include/scsi/scsi_transport_iscsi.h > +++ b/include/scsi/scsi_transport_iscsi.h > @@ -434,7 +434,6 @@ extern struct iscsi_cls_session *iscsi_create_session(struct Scsi_Host *shost, > unsigned int target_id); > extern void iscsi_remove_session(struct iscsi_cls_session *session); > extern void iscsi_free_session(struct iscsi_cls_session *session); > -extern int iscsi_destroy_session(struct iscsi_cls_session *session); > extern struct iscsi_cls_conn *iscsi_create_conn(struct iscsi_cls_session *sess, > int dd_size, uint32_t cid); > extern int iscsi_destroy_conn(struct iscsi_cls_conn *conn); > -- > 2.13.2.932.g7449e964c-goog > > -- > You received this message because you are subscribed to the Google Groups "open-iscsi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@googlegroups.com. > To post to this group, send email to open-iscsi@googlegroups.com. > Visit this group at https://groups.google.com/group/open-iscsi. > For more options, visit https://groups.google.com/d/optout.
On 07/13/2017 09:11 AM, Khazhismel Kumykov wrote: > iscsi_session_teardown was the only user of this function. Function > currently is just short for iscsi_remove_session + iscsi_free_session. > > Signed-off-by: Khazhismel Kumykov <khazhy@google.com> Why is this needed? I dislike changes that don't fix anything. > --- > drivers/scsi/scsi_transport_iscsi.c | 16 ---------------- > include/scsi/scsi_transport_iscsi.h | 1 - > 2 files changed, 17 deletions(-) > > diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c > index a424eaeafeb0..924ac408d8a9 100644 > --- a/drivers/scsi/scsi_transport_iscsi.c > +++ b/drivers/scsi/scsi_transport_iscsi.c > @@ -2210,22 +2210,6 @@ void iscsi_free_session(struct iscsi_cls_session *session) > } > EXPORT_SYMBOL_GPL(iscsi_free_session); > > -/** > - * iscsi_destroy_session - destroy iscsi session > - * @session: iscsi_session > - * > - * Can be called by a LLD or iscsi_transport. There must not be > - * any running connections. > - */ > -int iscsi_destroy_session(struct iscsi_cls_session *session) > -{ > - iscsi_remove_session(session); > - ISCSI_DBG_TRANS_SESSION(session, "Completing session destruction\n"); > - iscsi_free_session(session); > - return 0; > -} > -EXPORT_SYMBOL_GPL(iscsi_destroy_session); > - > /** > * iscsi_create_conn - create iscsi class connection > * @session: iscsi cls session > diff --git a/include/scsi/scsi_transport_iscsi.h b/include/scsi/scsi_transport_iscsi.h > index 6183d20a01fb..b266d2a3bcb1 100644 > --- a/include/scsi/scsi_transport_iscsi.h > +++ b/include/scsi/scsi_transport_iscsi.h > @@ -434,7 +434,6 @@ extern struct iscsi_cls_session *iscsi_create_session(struct Scsi_Host *shost, > unsigned int target_id); > extern void iscsi_remove_session(struct iscsi_cls_session *session); > extern void iscsi_free_session(struct iscsi_cls_session *session); > -extern int iscsi_destroy_session(struct iscsi_cls_session *session); > extern struct iscsi_cls_conn *iscsi_create_conn(struct iscsi_cls_session *sess, > int dd_size, uint32_t cid); > extern int iscsi_destroy_conn(struct iscsi_cls_conn *conn); >
On Wed, Sep 13, 2017 at 05:09:03PM -0700, Lee Duncan wrote: > On 07/13/2017 09:11 AM, Khazhismel Kumykov wrote: > > iscsi_session_teardown was the only user of this function. Function > > currently is just short for iscsi_remove_session + iscsi_free_session. > > > > Signed-off-by: Khazhismel Kumykov <khazhy@google.com> > > Why is this needed? I dislike changes that don't fix anything. The function has no more users left after patch 1, so why keep it bitrotting?
diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c index a424eaeafeb0..924ac408d8a9 100644 --- a/drivers/scsi/scsi_transport_iscsi.c +++ b/drivers/scsi/scsi_transport_iscsi.c @@ -2210,22 +2210,6 @@ void iscsi_free_session(struct iscsi_cls_session *session) } EXPORT_SYMBOL_GPL(iscsi_free_session); -/** - * iscsi_destroy_session - destroy iscsi session - * @session: iscsi_session - * - * Can be called by a LLD or iscsi_transport. There must not be - * any running connections. - */ -int iscsi_destroy_session(struct iscsi_cls_session *session) -{ - iscsi_remove_session(session); - ISCSI_DBG_TRANS_SESSION(session, "Completing session destruction\n"); - iscsi_free_session(session); - return 0; -} -EXPORT_SYMBOL_GPL(iscsi_destroy_session); - /** * iscsi_create_conn - create iscsi class connection * @session: iscsi cls session diff --git a/include/scsi/scsi_transport_iscsi.h b/include/scsi/scsi_transport_iscsi.h index 6183d20a01fb..b266d2a3bcb1 100644 --- a/include/scsi/scsi_transport_iscsi.h +++ b/include/scsi/scsi_transport_iscsi.h @@ -434,7 +434,6 @@ extern struct iscsi_cls_session *iscsi_create_session(struct Scsi_Host *shost, unsigned int target_id); extern void iscsi_remove_session(struct iscsi_cls_session *session); extern void iscsi_free_session(struct iscsi_cls_session *session); -extern int iscsi_destroy_session(struct iscsi_cls_session *session); extern struct iscsi_cls_conn *iscsi_create_conn(struct iscsi_cls_session *sess, int dd_size, uint32_t cid); extern int iscsi_destroy_conn(struct iscsi_cls_conn *conn);
iscsi_session_teardown was the only user of this function. Function currently is just short for iscsi_remove_session + iscsi_free_session. Signed-off-by: Khazhismel Kumykov <khazhy@google.com> --- drivers/scsi/scsi_transport_iscsi.c | 16 ---------------- include/scsi/scsi_transport_iscsi.h | 1 - 2 files changed, 17 deletions(-)