diff mbox

scsi: libfc: fix potential null lport dereference

Message ID 20170920132541.13691-1-colin.king@canonical.com (mailing list archive)
State Deferred
Headers show

Commit Message

Colin King Sept. 20, 2017, 1:25 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Don't pass a null lport to FC_LPORT_DBG as this causes a null pointer
dereference when accessing lport->host and lport->port_id. Instead
use the FC_CHECK_LOGGING macro to print the kernel message via pr_info.

Detected by CoverityScan, CID#113198 ("Dereference after null check")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/scsi/libfc/fc_exch.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox

Patch

diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c
index 42bcf7f3a0f9..46d842d238f1 100644
--- a/drivers/scsi/libfc/fc_exch.c
+++ b/drivers/scsi/libfc/fc_exch.c
@@ -2603,8 +2603,8 @@  void fc_exch_recv(struct fc_lport *lport, struct fc_frame *fp)
 
 	/* lport lock ? */
 	if (!lport || lport->state == LPORT_ST_DISABLED) {
-		FC_LPORT_DBG(lport, "Receiving frames for an lport that "
-			     "has not been initialized correctly\n");
+		FC_CHECK_LOGGING(FC_LPORT_LOGGING,
+				 pr_info("Receiving frames for an lport that has not been initialized correctly\n"));
 		fc_frame_free(fp);
 		return;
 	}