From patchwork Fri Sep 22 06:17:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Smart X-Patchwork-Id: 9965235 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 94EB3602D8 for ; Fri, 22 Sep 2017 06:18:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 865DE29707 for ; Fri, 22 Sep 2017 06:18:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7B7632970B; Fri, 22 Sep 2017 06:18:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3CCD929707 for ; Fri, 22 Sep 2017 06:18:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751897AbdIVGSS (ORCPT ); Fri, 22 Sep 2017 02:18:18 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34623 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751809AbdIVGSL (ORCPT ); Fri, 22 Sep 2017 02:18:11 -0400 Received: by mail-pg0-f68.google.com with SMTP id u18so126740pgo.1 for ; Thu, 21 Sep 2017 23:18:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RReRGsOCHWNKxe5m4Y9cCOZhhE5/IWVtgxPQZvERbGg=; b=YlSRphBJdq14uRCOIKO7Zo48d9fFfV94ZQwBguNTFTZbvJvKBwxtVxEJ88/bBFQFAE sdswn3hDNJ3uVCV49D2PTy6m+LPM+IrI/IJLpF1vfyt6w5NUTvBJglnRbqlKNm9VILL/ eEwM4SodIZQoVkjmAkU9o8Cx1b0uQkQu67jzVC4CyWjY3SDv4xooS6zPoyC+GMw4rGhP Ux0b6rzpRjjvyRx1PMI1RaWOdYmdIZ65xwo+RlF21n93CGa7R3ypzzQ5l2cmKQSBuTeX zJwS0rOv8xLku5c1GS7MipUSeer5Ei7wltCGHFMNInVeba6oJfAUox+WKIGAuFyjqbXO q1jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RReRGsOCHWNKxe5m4Y9cCOZhhE5/IWVtgxPQZvERbGg=; b=aEb47L3mkyQAJCvxqDtLNbbnyO9V0CS+UUWobFdCBGwoK9M6wHfgQZ32XLQ3RgP4PB OBEXwT7MWo9FECgirFJj90aEXoJKSlhBuiLa70UDWdS2KvP45MgPBHvK41hnaNEJdACN bZms2tFVys0H5mZasx0+6f6yzdkj8/as5x5ArZLVxtJ6Hghfc5+gCRzHTNHnldndpTJ2 Dhzwa7ioDkJ3EVd146HjebB9yS5g8rAhWsKwuTcEoE34yUTgdYN6f9/jEcwMD80zyPCS X5rLyB2EKakWsXjUCQUyYupcEeFBo4L3gGjN5PSX2vhB3P2Z+VB3ugwWGUBKRYY1LcZL YvMg== X-Gm-Message-State: AHPjjUh/Nw85Nrk+tivaxoGNqXEbesEitYf15lP3nIE/aLzH+1A0YZCD 3oGSkiargPIrk2jPl/TXdjL3GQ== X-Google-Smtp-Source: AOwi7QA11hWcyN3mx94/J2qkxk7Iuu1CVZ6DQ+gP6Q/HnPETAO83VePh/4DtWwJrZrwfGqTFaU6a0w== X-Received: by 10.98.75.12 with SMTP id y12mr8146183pfa.43.1506061090311; Thu, 21 Sep 2017 23:18:10 -0700 (PDT) Received: from os42.localdomain (ip68-4-115-207.oc.oc.cox.net. [68.4.115.207]) by smtp.gmail.com with ESMTPSA id e87sm5911355pfl.46.2017.09.21.23.18.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 21 Sep 2017 23:18:09 -0700 (PDT) From: James Smart To: linux-scsi@vger.kernel.org Cc: Dick Kennedy , James Smart Subject: [PATCH 15/19] lpfc: Fix secure firmware updates Date: Thu, 21 Sep 2017 23:17:37 -0700 Message-Id: <20170922061741.12347-16-jsmart2021@gmail.com> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20170922061741.12347-1-jsmart2021@gmail.com> References: <20170922061741.12347-1-jsmart2021@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Dick Kennedy Firmware update fails with: status x17 add_status x56 on the final write If multiple DMA buffers are used for the download, some firmware revs have difficulty with signatures and crcs split across the dma buffer boundaries. Resolve by making all writes be a single 4k page in length. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_hw4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hw4.h b/drivers/scsi/lpfc/lpfc_hw4.h index 1db0a38683f4..2b145966c73f 100644 --- a/drivers/scsi/lpfc/lpfc_hw4.h +++ b/drivers/scsi/lpfc/lpfc_hw4.h @@ -3636,7 +3636,7 @@ struct lpfc_mbx_get_port_name { #define MB_CEQ_STATUS_QUEUE_FLUSHING 0x4 #define MB_CQE_STATUS_DMA_FAILED 0x5 -#define LPFC_MBX_WR_CONFIG_MAX_BDE 8 +#define LPFC_MBX_WR_CONFIG_MAX_BDE 1 struct lpfc_mbx_wr_object { struct mbox_header header; union {