From patchwork Fri Sep 22 06:17:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Smart X-Patchwork-Id: 9965245 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C853D602D8 for ; Fri, 22 Sep 2017 06:18:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B1D8329707 for ; Fri, 22 Sep 2017 06:18:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A689C2970B; Fri, 22 Sep 2017 06:18:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 479AE29707 for ; Fri, 22 Sep 2017 06:18:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751879AbdIVGSZ (ORCPT ); Fri, 22 Sep 2017 02:18:25 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36354 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751842AbdIVGSM (ORCPT ); Fri, 22 Sep 2017 02:18:12 -0400 Received: by mail-pf0-f196.google.com with SMTP id f84so88372pfj.3 for ; Thu, 21 Sep 2017 23:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zuDRSfF47nXggfR3Bszxsqu17YGbMwNZvJvl0/viFJs=; b=lIIEyV16mYPhOpKnKv6dkhtdfguH61jq+zTcQ4Hz7sWU2Gl3ZuowfxYxb5tSzECHSq yoNUc3/Uixh2smiYbeRuRT5BaKQZanFiUFVZuTrmUJY7KwoCFikDXRI7ygLmohDWvMbZ HCEF1GIFWDVKnHrqceyShNuUeEcpR/n09rOahTrpGRJ59Bt8Bd6Zz5R9uQJ4pm802aej n6TNRvtfl57XI2hJ25I4lsw69RIj5MIo2srJKtsc5HIlXdHDvwQCqUlvi5HMl2f4Da80 Y5f2O4SN2aJqIZfboqTsnMJ6kTwcnfDQFtOqh6Q2K/uveC3LyjNnN6k/PF+NDseBzxAo UpkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zuDRSfF47nXggfR3Bszxsqu17YGbMwNZvJvl0/viFJs=; b=p1m/Di8NK4MrPBaXE3FHgMuuAqq5aOeWJggROTfOi0+7QiZHm8meDP6kbdgMPuT46o Gw6WmUG9/rMp8dPavkyPwouXcZHJEj3LkMGchl0vi3jGTKrulDrqQbSvTCVyxUmOYeSc 7RJpv9bhvbvQy4AFcG56WGwOkHYxyZq+LMxWDWspSsf1mY2te0gU8GOWE39X6f0cdvLi C7IY4CZej3tHiCfD/WvaAmvRfHD2dDaiMHYLQLJpYJypSrMLFgULrZ7UydqiemIO7ECH w0FZOh/IczfpiB0Dv38xE5KHzywnaCzNZW3NfvcwY2Sw5TNQaZgBcpf8N9zw5m7EmHZA pleg== X-Gm-Message-State: AHPjjUg+a0OrX2XmVG4hAANGqezWUUsu6h3p4wGDt7jL2u9CUyViIr9S akiv1KK71m1maYYes/YsrusAiA== X-Google-Smtp-Source: AOwi7QBm4s6KB9T1rw3FZqT4KB29sWoI4RkWe0Grrk9e2br6EKTxFZXBfnX+rTuOwNII+kAzO3fPhg== X-Received: by 10.99.123.79 with SMTP id k15mr8306177pgn.33.1506061091915; Thu, 21 Sep 2017 23:18:11 -0700 (PDT) Received: from os42.localdomain (ip68-4-115-207.oc.oc.cox.net. [68.4.115.207]) by smtp.gmail.com with ESMTPSA id e87sm5911355pfl.46.2017.09.21.23.18.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 21 Sep 2017 23:18:11 -0700 (PDT) From: James Smart To: linux-scsi@vger.kernel.org Cc: Dick Kennedy , James Smart Subject: [PATCH 17/19] lpfc: Extend RDP support Date: Thu, 21 Sep 2017 23:17:39 -0700 Message-Id: <20170922061741.12347-18-jsmart2021@gmail.com> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20170922061741.12347-1-jsmart2021@gmail.com> References: <20170922061741.12347-1-jsmart2021@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Dick Kennedy Support RDP and Multiple Frames If the remote Nport is not logged in, the driver would not populate all the descriptors in the RDP response payload. Doing so would create a payload length that requires multiple frames due to exceeding the default rx buffer size without an explicit login. Currently FC-LS explicitly states the RDP response must be a single frame sequence. Thus we did not violate the standard. Recently, a modification to FC-LS was accepted which allows multi-frame sequences and all vendors have indicated they are interoperable with the change. As such, extend RDP support with the additional fields and send a multi-frame sequence. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_els.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 3ebf6ccba6e6..b14f7c5653cd 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -5394,10 +5394,6 @@ lpfc_els_rdp_cmpl(struct lpfc_hba *phba, struct lpfc_rdp_context *rdp_context, (len + pcmd), vport, ndlp); len += lpfc_rdp_res_fec_desc((struct fc_fec_rdp_desc *)(len + pcmd), &rdp_context->link_stat); - /* Check if nport is logged, BZ190632 */ - if (!(ndlp->nlp_flag & NLP_RPI_REGISTERED)) - goto lpfc_skip_descriptor; - len += lpfc_rdp_res_bbc_desc((struct fc_rdp_bbc_desc *)(len + pcmd), &rdp_context->link_stat, vport); len += lpfc_rdp_res_oed_temp_desc(phba, @@ -5418,7 +5414,6 @@ lpfc_els_rdp_cmpl(struct lpfc_hba *phba, struct lpfc_rdp_context *rdp_context, len += lpfc_rdp_res_opd_desc((struct fc_rdp_opd_sfp_desc *)(len + pcmd), rdp_context->page_a0, vport); -lpfc_skip_descriptor: rdp_res->length = cpu_to_be32(len - 8); elsiocb->iocb_cmpl = lpfc_cmpl_els_rsp; @@ -5540,7 +5535,6 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb, pcmd = (struct lpfc_dmabuf *) cmdiocb->context2; rdp_req = (struct fc_rdp_req_frame *) pcmd->virt; - lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS, "2422 ELS RDP Request " "dec len %d tag x%x port_id %d len %d\n", @@ -5549,12 +5543,6 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb, be32_to_cpu(rdp_req->nport_id_desc.nport_id), be32_to_cpu(rdp_req->nport_id_desc.length)); - if (!(ndlp->nlp_flag & NLP_RPI_REGISTERED) && - !phba->cfg_enable_SmartSAN) { - rjt_err = LSRJT_UNABLE_TPC; - rjt_expl = LSEXP_PORT_LOGIN_REQ; - goto error; - } if (sizeof(struct fc_rdp_nport_desc) != be32_to_cpu(rdp_req->rdp_des_length)) goto rjt_logerr;