From patchwork Sat Sep 30 00:34:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Smart X-Patchwork-Id: 9978883 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2909F6037F for ; Sat, 30 Sep 2017 00:35:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1BB39298D1 for ; Sat, 30 Sep 2017 00:35:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 10BFF298D5; Sat, 30 Sep 2017 00:35:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B96F6298D1 for ; Sat, 30 Sep 2017 00:35:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752653AbdI3AfP (ORCPT ); Fri, 29 Sep 2017 20:35:15 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:49542 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752616AbdI3AfL (ORCPT ); Fri, 29 Sep 2017 20:35:11 -0400 Received: by mail-qt0-f196.google.com with SMTP id o3so1613026qte.6 for ; Fri, 29 Sep 2017 17:35:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=67a62H7pFRMYT6ctW0LL17gFx4zUfLoZH7iFT2HpALQ=; b=hCBsYYLOCkm8BMpTMcKLqgDfj3h897Yo4FYIhECneLIewCN65VRM9IxlUR2/tchGNh dVIdPAIpF8MBhw073qPr3FAzR/sCxE+pBgz/AwEu3XpSuggToW0rOUmpKBBic5IXjTFO mGnNHgISxQR6CtJne5RDpjGlcPo17pots9YpWq5dUnqfChtYCr4f/191J2LSjCPhcfTw gPNaBwVt8zwTIinePG3XT+LOr2NENt+Dae1gxcTVuoY0iY08YByfv1roOJJ1BEhZv5FT c6a3OVIjbGByx+5s3NXQ4ix7mKfZ7tWPEl7+pY+tlMbTUkE2G056QZsVXTqlPJ28SuPI ylJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=67a62H7pFRMYT6ctW0LL17gFx4zUfLoZH7iFT2HpALQ=; b=i3bztlTFDdh6mVff75xQx8mSYV/c17K4vCbZbV8JSSwHI0GNWiUKiWjsYHOj5z3dxJ KQP6IPYDFYix+jjXWHoy/dk6eueAhAKO/8K8w4MYU5iGLToBJDyJ2BBjyaG48mRSZ3S8 i7EOh90w50bZssdb/+AEP6Xi6KI1Lqw+Lei9xM+sfEvzWLkGveWh0VrwfDIUhN3mP0sp 5/QT1aAkqjX1oH8qNLFIXvTpDzllhAGPZR9F/Mz9Z5QuehaFp/c+rvFxOainin9bjGfR fC3JQqQBdBjYQv6Q94xAbWek7lXrRIZu82vv1uL2VB8bVGs3k7O2yq8znY7Y18l/o1Re hiCQ== X-Gm-Message-State: AMCzsaWu5frJ+1ItkLH3+jD8mWoNe+SAKDJlGzxM9P5zbVEcP4ODiet3 KyVWeT3tmb1Nkm1/7JOjPkrt0g== X-Google-Smtp-Source: AOwi7QBk/1tFAYM8rCoYrvuyGxJvplkaL+1otoUGv9JauSIpEdzwUjVvJPOBygoPHQi5SjN0SVgY9Q== X-Received: by 10.200.53.200 with SMTP id l8mr9340143qtb.334.1506731710571; Fri, 29 Sep 2017 17:35:10 -0700 (PDT) Received: from pallmd1.broadcom.com ([192.19.255.250]) by smtp.gmail.com with ESMTPSA id u32sm3596918qte.25.2017.09.29.17.35.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Sep 2017 17:35:10 -0700 (PDT) From: James Smart To: linux-scsi@vger.kernel.org Cc: Dick Kennedy , James Smart Subject: [PATCH v2 16/21] lpfc: Fix secure firmware updates Date: Fri, 29 Sep 2017 17:34:42 -0700 Message-Id: <20170930003447.10747-17-jsmart2021@gmail.com> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20170930003447.10747-1-jsmart2021@gmail.com> References: <20170930003447.10747-1-jsmart2021@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Dick Kennedy Firmware update fails with: status x17 add_status x56 on the final write If multiple DMA buffers are used for the download, some firmware revs have difficulty with signatures and crcs split across the dma buffer boundaries. Resolve by making all writes be a single 4k page in length. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_hw4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hw4.h b/drivers/scsi/lpfc/lpfc_hw4.h index 1db0a38683f4..2b145966c73f 100644 --- a/drivers/scsi/lpfc/lpfc_hw4.h +++ b/drivers/scsi/lpfc/lpfc_hw4.h @@ -3636,7 +3636,7 @@ struct lpfc_mbx_get_port_name { #define MB_CEQ_STATUS_QUEUE_FLUSHING 0x4 #define MB_CQE_STATUS_DMA_FAILED 0x5 -#define LPFC_MBX_WR_CONFIG_MAX_BDE 8 +#define LPFC_MBX_WR_CONFIG_MAX_BDE 1 struct lpfc_mbx_wr_object { struct mbox_header header; union {