From patchwork Sat Sep 30 00:34:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Smart X-Patchwork-Id: 9978895 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2C7596037F for ; Sat, 30 Sep 2017 00:35:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1F11F298D1 for ; Sat, 30 Sep 2017 00:35:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 14388298D5; Sat, 30 Sep 2017 00:35:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B2DB2298D1 for ; Sat, 30 Sep 2017 00:35:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752647AbdI3AfW (ORCPT ); Fri, 29 Sep 2017 20:35:22 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:47190 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752595AbdI3AfN (ORCPT ); Fri, 29 Sep 2017 20:35:13 -0400 Received: by mail-qt0-f195.google.com with SMTP id b1so1606905qtc.4 for ; Fri, 29 Sep 2017 17:35:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fXw5/sTx9XdQN5uOqeClr3BU2ZOa14hDrL+//0bjAX0=; b=vLucKMBhtI5Nbpiu+wgp6F1Q30jB9in10P6GKrTnHMGYR3ynTenDGoqb8Cy2WngoId Hjf7fGNxCDi5wZ1IIDJO92gl5clAMXCKfl67AYKw0ZFzZe95L3B4hIJ0vTo6IWwWgOGg DSgjrdxTVx2F2Dpw7rDk+1FzuO97EJB6MKxaxwySuK5LIgBXRPzeqCE9uEVHG0XJ2j6C 8e+h/kuoh9OBbsX0atvxVbcuX/CDXziLz5luJ5XmyIt8S4SVn3de/kD4t+lGLaJQnDZF Kv32QRByXP100WbTFyYfozCARuxDDz9gq/m1ZdK3IM11f/NSWuMXRix1aGAktxSzXy35 5s7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fXw5/sTx9XdQN5uOqeClr3BU2ZOa14hDrL+//0bjAX0=; b=L4FY8DYd0gLD9thpqz/X9Gz8jzrbqfbAjzhlb99qerGofuE39BZzGS2TdHxAMNDBy+ zIKMhUaeNfT/sdtHjK4HH0uzg6mN5sF66B/CnbfbPGs6U+hBrYQHpZz2Sne6ZuFZ+kcE agWxkxInSrN9VsWpeDPtKzDJVo/p9N02MYPMSKBC9tPFaipwXlzJg5Rop9udLjKLuQgz wETjHATtBG8/IXvcsQzz0O73I9TsntAja/06IYrjbJEcn+pvAIzXH+UQNvy81N+PthBE wrsHj2JSLEW26PtxvsWKtJujIvNDQWxrG1AELO/p82cwDNFJpEfxdt6cjas9oFhg6J3+ Q2Bg== X-Gm-Message-State: AMCzsaVY4X9OAFP1y7kKXOOpqRyIG1Ki7DUkTw0Zp1vBVKhhY9xkHjF4 3y9iWKkByAw20P65autfXSs0ug== X-Google-Smtp-Source: AOwi7QDgbhD2ChntjO92wwOZiBkFWuPjs4bg2inGNgltCbicBdGJ6tX4aZtqDCKzrz3EYsAUQht80g== X-Received: by 10.200.63.2 with SMTP id c2mr8445574qtk.194.1506731712349; Fri, 29 Sep 2017 17:35:12 -0700 (PDT) Received: from pallmd1.broadcom.com ([192.19.255.250]) by smtp.gmail.com with ESMTPSA id u32sm3596918qte.25.2017.09.29.17.35.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Sep 2017 17:35:12 -0700 (PDT) From: James Smart To: linux-scsi@vger.kernel.org Cc: Dick Kennedy , James Smart Subject: [PATCH v2 18/21] lpfc: Extend RDP support Date: Fri, 29 Sep 2017 17:34:44 -0700 Message-Id: <20170930003447.10747-19-jsmart2021@gmail.com> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20170930003447.10747-1-jsmart2021@gmail.com> References: <20170930003447.10747-1-jsmart2021@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Dick Kennedy Support RDP and Multiple Frames If the remote Nport is not logged in, the driver would not populate all the descriptors in the RDP response payload. Doing so would create a payload length that requires multiple frames due to exceeding the default rx buffer size without an explicit login. Currently FC-LS explicitly states the RDP response must be a single frame sequence. Thus we did not violate the standard. Recently, a modification to FC-LS was accepted which allows multi-frame sequences and all vendors have indicated they are interoperable with the change. As such, extend RDP support with the additional fields and send a multi-frame sequence. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_els.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 3ebf6ccba6e6..b14f7c5653cd 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -5394,10 +5394,6 @@ lpfc_els_rdp_cmpl(struct lpfc_hba *phba, struct lpfc_rdp_context *rdp_context, (len + pcmd), vport, ndlp); len += lpfc_rdp_res_fec_desc((struct fc_fec_rdp_desc *)(len + pcmd), &rdp_context->link_stat); - /* Check if nport is logged, BZ190632 */ - if (!(ndlp->nlp_flag & NLP_RPI_REGISTERED)) - goto lpfc_skip_descriptor; - len += lpfc_rdp_res_bbc_desc((struct fc_rdp_bbc_desc *)(len + pcmd), &rdp_context->link_stat, vport); len += lpfc_rdp_res_oed_temp_desc(phba, @@ -5418,7 +5414,6 @@ lpfc_els_rdp_cmpl(struct lpfc_hba *phba, struct lpfc_rdp_context *rdp_context, len += lpfc_rdp_res_opd_desc((struct fc_rdp_opd_sfp_desc *)(len + pcmd), rdp_context->page_a0, vport); -lpfc_skip_descriptor: rdp_res->length = cpu_to_be32(len - 8); elsiocb->iocb_cmpl = lpfc_cmpl_els_rsp; @@ -5540,7 +5535,6 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb, pcmd = (struct lpfc_dmabuf *) cmdiocb->context2; rdp_req = (struct fc_rdp_req_frame *) pcmd->virt; - lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS, "2422 ELS RDP Request " "dec len %d tag x%x port_id %d len %d\n", @@ -5549,12 +5543,6 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb, be32_to_cpu(rdp_req->nport_id_desc.nport_id), be32_to_cpu(rdp_req->nport_id_desc.length)); - if (!(ndlp->nlp_flag & NLP_RPI_REGISTERED) && - !phba->cfg_enable_SmartSAN) { - rjt_err = LSRJT_UNABLE_TPC; - rjt_expl = LSEXP_PORT_LOGIN_REQ; - goto error; - } if (sizeof(struct fc_rdp_nport_desc) != be32_to_cpu(rdp_req->rdp_des_length)) goto rjt_logerr;