From patchwork Fri Nov 3 22:56:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Smart X-Patchwork-Id: 10041307 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4BAEF60384 for ; Fri, 3 Nov 2017 22:57:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3E55D299CE for ; Fri, 3 Nov 2017 22:57:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 320F4299E1; Fri, 3 Nov 2017 22:57:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BABF1299CE for ; Fri, 3 Nov 2017 22:57:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752472AbdKCW4v (ORCPT ); Fri, 3 Nov 2017 18:56:51 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:50728 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756069AbdKCW4n (ORCPT ); Fri, 3 Nov 2017 18:56:43 -0400 Received: by mail-qt0-f193.google.com with SMTP id d9so5052942qtd.7 for ; Fri, 03 Nov 2017 15:56:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pqis69Z1DEXQrafsUnuftSOqo7UIso1XPB1+XbMCv/M=; b=QA1IPzQqz6pCrDALQf7DGrg/wFeWiI/A7QYojIVgl6kHi9/n0GjqTPureVyXs+Wnq3 9WaWRqlPLcUujTrKSeKH8kqIxWYzO/L9Kts1ZctQsVFhHEVCez6tgwmSukjiMgsMRnvs +U5ms3aRYko9x1+DQLUH3mtFA0Eh3gRulAshr+8skcEnauUiWvhZZxRSq1cSqU09Zbb4 7X0beWoZc9N/DJIgKFyq0wrgo3TijWz7rAlWCawGD7BXRlZwhIO9yNHl4oABxDqi2HQ8 0mbWhQIWG5ClysZ1VvpjUnJhVqP65yIF9+Wt/IxzT32byh+S/rKcidcWeCZ1cieHlPVn O5+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pqis69Z1DEXQrafsUnuftSOqo7UIso1XPB1+XbMCv/M=; b=clsYFvy/YPExJMHkItJkv8KHPZmMTCOs2ZOA0W2/EDKhMt76M76fd+WKSBEiAxHEp3 CEPrj6tf95c0cE+UDhBfco843xxMcBbU/BzLzYOA7k7KOcFrrZDTvl/0IKY1ePbdh1TH FKSQqjvCh37O0My1Dzxk8PpsBTmDwNJioseL64EDq7VPtXQUmCfplOJ4kNQKSjgAvzfi cY5Li8fBJq+du+n2aehH0OhPSuttAXXIcXEXQU0nK9ORHe6K6J16bijFvol4RVZmUIlD iMUZPNhPbXyYIQdFvuHKIKn7Z1eyhiM0lR8rjJUyoJFa72QziEzLkrbt8o7SIfxbYC25 IltQ== X-Gm-Message-State: AMCzsaU+PJcfBvL2VMxihuHgT04PFMY78lOVh0Z0ji2+UwRQIJe5b/7X DBKkGhOnXcR3k4vqUKgArqRyTQTQ X-Google-Smtp-Source: ABhQp+RFw3XigI3TR/0uOldGk2OMQzAmXUChwQ000usFEEwOXMUsnoR96gPYElzOYdbSNhiecC3Lzg== X-Received: by 10.200.35.75 with SMTP id b11mr12604635qtb.185.1509749802154; Fri, 03 Nov 2017 15:56:42 -0700 (PDT) Received: from pallmd1.broadcom.com ([192.19.255.250]) by smtp.gmail.com with ESMTPSA id v21sm4765626qtv.21.2017.11.03.15.56.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 03 Nov 2017 15:56:41 -0700 (PDT) From: James Smart To: linux-scsi@vger.kernel.org Cc: James Smart , Dick Kennedy , James Smart Subject: [PATCH 05/17] lpfc: Fix NVME LS abort_xri Date: Fri, 3 Nov 2017 15:56:16 -0700 Message-Id: <20171103225628.24716-6-jsmart2021@gmail.com> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20171103225628.24716-1-jsmart2021@gmail.com> References: <20171103225628.24716-1-jsmart2021@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP performing an LS abort results in the following message being seen: 0603 Invalid CQ subtype 6: 00000300 22000002 ffff0016 d0050000 and the associated exchange is not properly freed. The code did not recognize the exchange type that was aborted, thus it was not properly handled. Correct by adding the NVME LS ELS type to the exchange types that are recognized. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Hannes Reinecke --- drivers/scsi/lpfc/lpfc_sli.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index ba6f0619433c..1229f58bdd09 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -12807,6 +12807,7 @@ lpfc_sli4_sp_handle_abort_xri_wcqe(struct lpfc_hba *phba, spin_unlock_irqrestore(&phba->hbalock, iflags); workposted = true; break; + case LPFC_NVME_LS: /* NVME LS uses ELS resources */ case LPFC_ELS: cq_event = lpfc_cq_event_setup( phba, wcqe, sizeof(struct sli4_wcqe_xri_aborted));