From patchwork Thu Nov 9 18:49:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10051685 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D214760631 for ; Thu, 9 Nov 2017 18:50:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C5D36291D3 for ; Thu, 9 Nov 2017 18:50:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BA7DD29AAF; Thu, 9 Nov 2017 18:50:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6001B2B06E for ; Thu, 9 Nov 2017 18:50:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753588AbdKISuD (ORCPT ); Thu, 9 Nov 2017 13:50:03 -0500 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:43041 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752790AbdKISuC (ORCPT ); Thu, 9 Nov 2017 13:50:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1510253403; x=1541789403; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=w4uYvso+VA75X5DNMCE+jw46Kdw6xXcoSn6mx7qwu8Q=; b=l0EcEaBIAFd0SkkXY5VdNIop1OaK2ovtd/hXrscuitw9EVDwQrlL0UZS 53NGpqBxJ79gyj5rD9EOFw7qbcqeaVxVfg5kOaQRUOzzIOAWqTe1b/7Hn egkMqCFCneF+7DvL7mgo5hlYIC62sendfNb0EEaaZ05u904rO0WbVuMi0 sHir3Xm1Cs0glekHaOsiTSnVcNJc40FHKe00pLlAfG1w15oMoKSngd7Sl 0R/qBbdboEykA1eFNoqV8uhTmT+ca2GdNoV45jm1+rR3Kk82BEC0qT/nV YB1V2o8gdSwlen4H6rqU3S3VAtj2hQF1PF4R1jrBSjauMmEADCqkTg9nS Q==; X-IronPort-AV: E=Sophos;i="5.44,370,1505750400"; d="scan'208";a="61801473" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 10 Nov 2017 02:50:03 +0800 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP; 09 Nov 2017 10:47:25 -0800 Received: from unknown (HELO MILHUBIP04.sdcorp.global.sandisk.com) ([10.177.9.97]) by uls-op-cesaip02.wdc.com with ESMTP; 09 Nov 2017 10:50:02 -0800 Received: from milsmgip11.sandisk.com (10.177.9.6) by MILHUBIP04.sdcorp.global.sandisk.com (10.177.9.97) with Microsoft SMTP Server id 14.3.319.2; Thu, 9 Nov 2017 10:50:01 -0800 X-AuditID: 0ab10959-41c5898000002c97-f1-5a04a35984bb Received: from thinkpad-bart.int.fusionio.com ( [10.177.9.6]) by (Symantec Messaging Gateway) with SMTP id E1.AE.11415.953A40A5; Thu, 9 Nov 2017 10:50:01 -0800 (PST) From: Bart Van Assche To: Jens Axboe CC: , , "Christoph Hellwig" , "Martin K . Petersen" , Oleksandr Natalenko , Ming Lei , Martin Steigerwald , "Bart Van Assche" Subject: [PATCH v12 1/7] block: Make q_usage_counter also track legacy requests Date: Thu, 9 Nov 2017 10:49:53 -0800 Message-ID: <20171109184959.4617-2-bart.vanassche@wdc.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171109184959.4617-1-bart.vanassche@wdc.com> References: <20171109184959.4617-1-bart.vanassche@wdc.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrIJMWRmVeSWpSXmKPExsXCtZGTTTdyMUuUwYmTMhar7/azWVz684XR YuXqo0wWe29pW3Rf38Fmsfz4PyaLJbOamSwOTQYSC19sYnbg9Lh8ttRj4no+j903G9g8Xl7i 8Pj49BaLx/t9V9k8Pm+S82g/0M0UwBHFZZOSmpNZllqkb5fAlfHxdnzBXumKf7d5GxjPiHUx cnJICJhITHi/mxXEFhJYySjxdaENiM0moCdxat4+JhBbREBBouf3SrYuRi4OZoGDTBL/mvez dDFycAgL+Et8msQCUsMioCpx88oGdhCbV8BKovVhGzvEfHmJtW/vMYLYnALWEn/3zGUDaRUC qtl9n2cCI/cCRoZVjGK5mTnFuemZBYaGesWJeSmZxdl6yfm5mxghgRS5g/HpRPNDjEwcnFIN jKv/rrL/8Nb4qMyHeOl127OkuRflnfn1yivC6+hXprwFjp+zVTa9TOVy2DvD5+Ke1E9vzA+t OfhAdzrzY7f3l9k+ah45e6loUkjpQ0W5o9275940yDU/ESZVy8lXfmLL+8I7kyyF22xarWOW vbJ7+tDs3p4vR82+JK9nT3h95tR/1WltHMxPF5UrsRRnJBpqMRcVJwIAfzEWQdQBAAA= MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Ming Lei This patch makes it possible to pause request allocation for the legacy block layer by calling blk_mq_freeze_queue() and blk_mq_unfreeze_queue(). Signed-off-by: Ming Lei [ bvanassche: Combined two patches into one, edited a comment and made sure REQ_NOWAIT is handled properly in blk_old_get_request() ] Signed-off-by: Bart Van Assche Reviewed-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn Reviewed-by: Hannes Reinecke Tested-by: Martin Steigerwald Tested-by: Oleksandr Natalenko Cc: Ming Lei --- block/blk-core.c | 12 ++++++++++++ block/blk-mq.c | 10 ++-------- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index 5e81dcf4690a..a4362849059a 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -612,6 +612,9 @@ void blk_set_queue_dying(struct request_queue *q) } spin_unlock_irq(q->queue_lock); } + + /* Make blk_queue_enter() reexamine the DYING flag. */ + wake_up_all(&q->mq_freeze_wq); } EXPORT_SYMBOL_GPL(blk_set_queue_dying); @@ -1398,16 +1401,22 @@ static struct request *blk_old_get_request(struct request_queue *q, unsigned int op, gfp_t gfp_mask) { struct request *rq; + int ret = 0; WARN_ON_ONCE(q->mq_ops); /* create ioc upfront */ create_io_context(gfp_mask, q->node); + ret = blk_queue_enter(q, !(gfp_mask & __GFP_DIRECT_RECLAIM) || + (op & REQ_NOWAIT)); + if (ret) + return ERR_PTR(ret); spin_lock_irq(q->queue_lock); rq = get_request(q, op, NULL, gfp_mask); if (IS_ERR(rq)) { spin_unlock_irq(q->queue_lock); + blk_queue_exit(q); return rq; } @@ -1579,6 +1588,7 @@ void __blk_put_request(struct request_queue *q, struct request *req) blk_free_request(rl, req); freed_request(rl, sync, rq_flags); blk_put_rl(rl); + blk_queue_exit(q); } } EXPORT_SYMBOL_GPL(__blk_put_request); @@ -1860,8 +1870,10 @@ static blk_qc_t blk_queue_bio(struct request_queue *q, struct bio *bio) * Grab a free request. This is might sleep but can not fail. * Returns with the queue unlocked. */ + blk_queue_enter_live(q); req = get_request(q, bio->bi_opf, bio, GFP_NOIO); if (IS_ERR(req)) { + blk_queue_exit(q); __wbt_done(q->rq_wb, wb_acct); if (PTR_ERR(req) == -ENOMEM) bio->bi_status = BLK_STS_RESOURCE; diff --git a/block/blk-mq.c b/block/blk-mq.c index 2396f036c388..2b7d95b2cdfb 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -126,7 +126,8 @@ void blk_freeze_queue_start(struct request_queue *q) freeze_depth = atomic_inc_return(&q->mq_freeze_depth); if (freeze_depth == 1) { percpu_ref_kill(&q->q_usage_counter); - blk_mq_run_hw_queues(q, false); + if (q->mq_ops) + blk_mq_run_hw_queues(q, false); } } EXPORT_SYMBOL_GPL(blk_freeze_queue_start); @@ -256,13 +257,6 @@ void blk_mq_wake_waiters(struct request_queue *q) queue_for_each_hw_ctx(q, hctx, i) if (blk_mq_hw_queue_mapped(hctx)) blk_mq_tag_wakeup_all(hctx->tags, true); - - /* - * If we are called because the queue has now been marked as - * dying, we need to ensure that processes currently waiting on - * the queue are notified as well. - */ - wake_up_all(&q->mq_freeze_wq); } bool blk_mq_can_queue(struct blk_mq_hw_ctx *hctx)