From patchwork Fri Nov 10 01:08:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Smart X-Patchwork-Id: 10052219 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 74D0F6032D for ; Fri, 10 Nov 2017 01:08:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 684E02B20E for ; Fri, 10 Nov 2017 01:08:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5D3A82B227; Fri, 10 Nov 2017 01:08:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EA7F42B20E for ; Fri, 10 Nov 2017 01:08:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755522AbdKJBIw (ORCPT ); Thu, 9 Nov 2017 20:08:52 -0500 Received: from mail-qt0-f194.google.com ([209.85.216.194]:45000 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755499AbdKJBIs (ORCPT ); Thu, 9 Nov 2017 20:08:48 -0500 Received: by mail-qt0-f194.google.com with SMTP id 8so10084264qtv.1 for ; Thu, 09 Nov 2017 17:08:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=X1Uk9e+osuStozbzXd1TXGUZ4ShH9QFB+Hg6PvdN1b8=; b=pXdlGrsTZcJRWR+lnDv59Yycwi9Mp41eyNPg6hYseLP42WHLvvJTcc11B/Yo9LN96m Dtoba59i2yU7JVCXwPrZCfz4Cpi07qsa9wfOLJgWaV5nljS8VpeSfWeLNZNYIzENeyqM rv5NBCMFXHChEcgHg4EVcyR7TlbaX7bpMijr1fOEDzrUtCsxA5sGq4rYpn7AjrRJF5/Y uG2B13dQ/CFsU3R/0KbpfayLbyIsax120ErbsoHiU76GH5XxTqGu19PhaDAEkuZRrLT7 clWExOUmyfwY33GVFrMydLyRj9zdLwzsMy4cy1jHcdetub4DEzI6TR0wZb1eotX4GQqB EzEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=X1Uk9e+osuStozbzXd1TXGUZ4ShH9QFB+Hg6PvdN1b8=; b=Nr5SD1wtPVdJfpIq1PqcyMHPzQYLFrdmr+98kqQ8Nhq+azN0TnayXKWtqzri9r9nwx Z+bke8BfFnMfFSQpCN7m16fyN3YgTwaQ9HWuq53KbUD6JLkYllsH3JybolP2QGIrxIr4 JiRNFx0+adecmqEKZRpXYcagvtppWZsjdBj+tt2oKCL+q0a8uT4fWXwned8OGGh+23hH IpGtI7W9V/AMJAzzDaCXMO52R4vqsc8SsKtS3EFjZHqYftsG0GZiOYkiPX2RZXKEP/uv np5SoF3xB74Z27yNiwUxlhgmTwQg0C2m9biMaVgavX2URk103rhhGH4ORsM1vfcSPhWY FX7A== X-Gm-Message-State: AJaThX4XDY1x90ZveJ+OnjdFhI//uZFHeSK12T3xbvS1ba53VJ40o5IS af1uefDJtjjotWHmjMs+iKczTTLt X-Google-Smtp-Source: AGs4zMbQjT1jxFtW/jsMJqIW4ykbpmeyva/Y2WNW8Yr3R6PxJw15d1Plst247QVNgOM/HgMGXCaxFA== X-Received: by 10.200.3.111 with SMTP id w47mr4180651qtg.312.1510276127618; Thu, 09 Nov 2017 17:08:47 -0800 (PST) Received: from pallmd1.broadcom.com ([192.19.255.250]) by smtp.gmail.com with ESMTPSA id j48sm5661969qta.96.2017.11.09.17.08.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Nov 2017 17:08:47 -0800 (PST) From: James Smart To: linux-scsi@vger.kernel.org Cc: James Smart , Dick Kennedy , James Smart Subject: [PATCH v2 05/17] lpfc: Fix NVME LS abort_xri Date: Thu, 9 Nov 2017 17:08:22 -0800 Message-Id: <20171110010834.4542-6-jsmart2021@gmail.com> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20171110010834.4542-1-jsmart2021@gmail.com> References: <20171110010834.4542-1-jsmart2021@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP performing an LS abort results in the following message being seen: 0603 Invalid CQ subtype 6: 00000300 22000002 ffff0016 d0050000 and the associated exchange is not properly freed. The code did not recognize the exchange type that was aborted, thus it was not properly handled. Correct by adding the NVME LS ELS type to the exchange types that are recognized. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Hannes Reinecke --- drivers/scsi/lpfc/lpfc_sli.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 4b76db19ef73..c1c7df607604 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -12814,6 +12814,7 @@ lpfc_sli4_sp_handle_abort_xri_wcqe(struct lpfc_hba *phba, spin_unlock_irqrestore(&phba->hbalock, iflags); workposted = true; break; + case LPFC_NVME_LS: /* NVME LS uses ELS resources */ case LPFC_ELS: cq_event = lpfc_cq_event_setup( phba, wcqe, sizeof(struct sli4_wcqe_xri_aborted));