From patchwork Tue Nov 21 00:00:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Smart X-Patchwork-Id: 10067499 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 586C660224 for ; Tue, 21 Nov 2017 00:01:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4985A29194 for ; Tue, 21 Nov 2017 00:01:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3E938291AB; Tue, 21 Nov 2017 00:01:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DBF7B29194 for ; Tue, 21 Nov 2017 00:01:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752008AbdKUABH (ORCPT ); Mon, 20 Nov 2017 19:01:07 -0500 Received: from mail-qk0-f195.google.com ([209.85.220.195]:42446 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963AbdKUAA7 (ORCPT ); Mon, 20 Nov 2017 19:00:59 -0500 Received: by mail-qk0-f195.google.com with SMTP id a194so9753465qkc.9 for ; Mon, 20 Nov 2017 16:00:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=X1Uk9e+osuStozbzXd1TXGUZ4ShH9QFB+Hg6PvdN1b8=; b=FpiFv1tZ6rzChYQGtyynb/e2m/UAVCsKDpUNxNXb4dcrUNBM2QyhXxChaqiw8O5tAA dCx2W4nV4KAXwL75UdqqdtBdvlI9DfBykERqZH79/OFAHdGO1GcfwFjok0oKXChRGIk8 C84fsQfFwVP6YIOSgGFujLFilS73aCq7Budphs7//U3MnYMg1h2pRHCu8Rc8UeAoguWh 5Dg4Wx/nIkixznZdqz9tZJi21QmowtYA3flLGkeBBle9WZo3v/k2F/3safwfd2mJVKZ8 7HOd4lxGOo5ZkhdvZHBZauuTZ0yf+qJwUycQNz7XRM3u4tN593/h+AdLIOhco8Kua1bX YFng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=X1Uk9e+osuStozbzXd1TXGUZ4ShH9QFB+Hg6PvdN1b8=; b=l415kzSufrttcfQDoCJn1esQKL9VL+o2sadjBVQgIc596yr/NFbu3WwXHwiWgotKy3 3Bv+kXrE5QX6DkaEB8Bo0Ac4L6H+ONCZopffLXu81ZjRYfqyUmI4t/UqvPqeNKHyhv59 nFGNfSLkpu9F6U8EXTkv3NTZAu6N83bqfHUNaCIWXkB4NEYRFMnNHV9OVZ924/KPE1bY dRjVhd+MXfdD+z5ZgbIoMx4W8DhEzlkb88gXML0XJACf+r+VBSk93ievKab+PdLbIQ0o f7GVAGnK99VSRKlRwonvNh+FwknpDD5Rt4cmtuS1ye7QdFlgpozbbkuAmFJaD+pKHLir aUmQ== X-Gm-Message-State: AJaThX7SXEmIXKxUpZHjpTboYgKzO3LgvsZ/um6JwajIiiDizCsgkLfd nw27Cleau5dprBuDvC8p2YmQS2t4 X-Google-Smtp-Source: AGs4zMbs+vVYbmSHmKci52Ix5yEEyzZn6lmIXXakA0m1J7qJR6ESGIMGGkMQt+Ad8dMU/i5LYc5TKg== X-Received: by 10.55.19.19 with SMTP id d19mr21813704qkh.189.1511222458852; Mon, 20 Nov 2017 16:00:58 -0800 (PST) Received: from pallmd1.broadcom.com ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id w143sm1612821qka.84.2017.11.20.16.00.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 20 Nov 2017 16:00:58 -0800 (PST) From: James Smart To: linux-scsi@vger.kernel.org Cc: James Smart , Dick Kennedy , James Smart Subject: [PATCH v3 05/17] lpfc: Fix NVME LS abort_xri Date: Mon, 20 Nov 2017 16:00:32 -0800 Message-Id: <20171121000044.27702-6-jsmart2021@gmail.com> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20171121000044.27702-1-jsmart2021@gmail.com> References: <20171121000044.27702-1-jsmart2021@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP performing an LS abort results in the following message being seen: 0603 Invalid CQ subtype 6: 00000300 22000002 ffff0016 d0050000 and the associated exchange is not properly freed. The code did not recognize the exchange type that was aborted, thus it was not properly handled. Correct by adding the NVME LS ELS type to the exchange types that are recognized. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Hannes Reinecke --- drivers/scsi/lpfc/lpfc_sli.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 4b76db19ef73..c1c7df607604 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -12814,6 +12814,7 @@ lpfc_sli4_sp_handle_abort_xri_wcqe(struct lpfc_hba *phba, spin_unlock_irqrestore(&phba->hbalock, iflags); workposted = true; break; + case LPFC_NVME_LS: /* NVME LS uses ELS resources */ case LPFC_ELS: cq_event = lpfc_cq_event_setup( phba, wcqe, sizeof(struct sli4_wcqe_xri_aborted));