From patchwork Tue Nov 28 19:34:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10080947 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E1163602DC for ; Tue, 28 Nov 2017 19:35:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D4F06289B8 for ; Tue, 28 Nov 2017 19:35:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C9E212964E; Tue, 28 Nov 2017 19:35:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9581C29638 for ; Tue, 28 Nov 2017 19:35:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932091AbdK1Tfb (ORCPT ); Tue, 28 Nov 2017 14:35:31 -0500 Received: from mail-sn1nam01on0074.outbound.protection.outlook.com ([104.47.32.74]:50528 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752410AbdK1TfX (ORCPT ); Tue, 28 Nov 2017 14:35:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AQkTADwJNQlQL16Zk4FkCjq2tCE9tFRUorQIM46tGCs=; b=WXJlwApdp9UFcsiMPFJuq03Bhu4V5h6zbYDBvJY9akDw6Y+C2nsJpxN/OdocXTVS6dQM6BxL7y1J1lixRkRyjrziTaiJSzKGeXfZOPcJ8u/y8adhZxr2o5ebRcfLMGfEymqte9dh3EoKNKVdkk3VDGH8ybJ8pCXPd18iyVGu0WY= Received: from BY2PR07CA0098.namprd07.prod.outlook.com (10.166.107.51) by BY2PR0701MB1944.namprd07.prod.outlook.com (10.163.155.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Tue, 28 Nov 2017 19:35:22 +0000 Received: from BY2FFO11OLC011.protection.gbl (2a01:111:f400:7c0c::127) by BY2PR07CA0098.outlook.office365.com (2a01:111:e400:7bff::51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.260.4 via Frontend Transport; Tue, 28 Nov 2017 19:35:22 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BY2FFO11OLC011.mail.protection.outlook.com (10.1.15.22) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.218.12 via Frontend Transport; Tue, 28 Nov 2017 19:35:21 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Tue, 28 Nov 2017 11:35:06 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id vASJZ6ph013782; Tue, 28 Nov 2017 11:35:06 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id vASJZ66o013781; Tue, 28 Nov 2017 11:35:06 -0800 From: Himanshu Madhani To: , CC: , Subject: [PATCH 13/22] qla2xxx: Fix PRLI state check Date: Tue, 28 Nov 2017 11:34:54 -0800 Message-ID: <20171128193503.13695-14-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20171128193503.13695-1-himanshu.madhani@cavium.com> References: <20171128193503.13695-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(2980300002)(428002)(189002)(199003)(54906003)(81156014)(189998001)(8676002)(110136005)(16586007)(81166006)(105586002)(101416001)(106466001)(305945005)(356003)(47776003)(5660300001)(33646002)(1076002)(6666003)(2906002)(51416003)(69596002)(48376002)(50466002)(42186006)(50986999)(76176999)(316002)(2950100002)(72206003)(36756003)(87636003)(80596001)(478600001)(4326008)(8936002)(86362001)(50226002); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0701MB1944; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC011; 1:Xtp9Kn6R+rozgwB+JL23g6siqP10RMLVFuUQUJe678opoXSFZFEnHIcVOmB2pcx5EJoFzI4b0RLHKjVDAkWJY1/4yrAoFjZajDY7SSDpblcEkb/FCm/XCjeM821WazFN X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 02e8f993-3ccb-40c0-58d7-08d536972a4b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603199); SRVR:BY2PR0701MB1944; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB1944; 3:n3wUTLz6NBEmb1fyBwpSJF4xewTfXdy5s6BLeLPh6ZdyR1EIO1zD0v0hNknmHz03PTCZWhUmw8m/teW7b1fkS7DqSMXO2zEvRQyzZ2YPOVsKLkT2iqmmpiXDwpwXkeGHEf/TnJl0zEY87nO0Jb5KI7n/HemYRcmzhsGeYjf5Ee7mPiRdrhjhXH7mscd/uMJ602jVpHjwFdTd1Tl9Qf7QdLeYS3xXdFQabsY8dQHVq9re5HSJdz5c+Ivd56sD/GucgXioe3omrAdJe0+gt+n1bE92LU1vHIPkpvoeSFxBl4R18lAyNAHw0lTBDTefveWHeOSzCUX0V2OOs3rC+ySBhCR7XfM4tRS/HP/jxTwb5MY=; 25:iqvNx5G/8p6JaFAqC3EV/8P1ISelGdKhxEW+SYdygt9GkMlu1p9TDHjzIhRGl42hqzUcgjfZFWAkOHMXSOBfNY5TKdNc+Yle4pfr4ypO3ViGd5wLDHySx4L6nccI8fO4VITjm97uLMl4VgqSHPvSG8CLEWGxhQXJ0Oebngihkm57JQ7JourctN71/DqkvXbdlG4bgJzXfIIde8WraaECtUnd9wzzrT5008Y0hCVgL4fAW5J5qQ6NPehUCkbfAXueckyTHP0BcHefZRBO5ursIjMbGXv4jaG2Kx72kc4kOS9MVMT5Zjq1chOZ+VMf59wXQKYFvhXoN6U4V/8OZG6SLQ== X-MS-TrafficTypeDiagnostic: BY2PR0701MB1944: X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB1944; 31:izen7i3vW5G2r1+egbfTnvBGpZN3meSDj7KnA5WHi99vZE7tD2oEDacLDHhzBZtKNGg41i+XRphEAgJFVrxB+IOBSxKFP/O5mSkUHCb8vwUZuJi9FZYfMLOQA4y9HT9PndQ84IGsXmHw0InlZJDHKe51ifhbwtYoBt1kB6vMZC3W/jT2WcK3XwCspm7CaBjj516t7RT0Sm+0fgx2OlxArzwVaqBQgd7w2VNjRT4HyVs=; 20:yufAQAjlwmcwQOuDQ9ARkwCTsCk1w3wxYf4McvTwueAPSUjLXsmLtNU9aFMdaK15/SV0YF61OLa6BTurppsKnU24fX9f+c96x7nFu3ssJzmhaPbxrSNvuYShTlEvFmhp0ViaUaV1B5qbfKwbCqt+GX6OHfeQgaQwlGNfkKBYoPkYW9VMBJFKrxC6+M8U3M6wFZoUpb5d2cXvHPvhXETgCKPoyXZjC9wN47NptbC4IkKDw2tXMRY37wkt5tbbJ70QNDG7woRJqQICNr1+FVP2352VNRvUC7BE61HD02AB5Xh2GLrGZ4d54LqGIuYY8fqOjMOVaBZe0NYZe16QKHLz46gWfrCHt0TA2RVxvs72IWl9aF3oz/G7cq2ttbeejxyEIejZO/ZEDca0o7knWGygb/xZ1x6ADu8s8kiY5d02vQC5gW8/0cl956sNWQ2BFfLVLgFFQayHiVoLF+wJXdwBt6waY6cA72rQgY9vedMSo0KtsIm1e+XJopPNwN+/AfRd X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231022)(3002001)(6041248)(20161123562025)(20161123558100)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011); SRVR:BY2PR0701MB1944; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BY2PR0701MB1944; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB1944; 4:JYRtFv4un0Nh3CEpZs08VLeZA7SvgaBP5sLeAr1B2tWx02wEwo2a773Q4rYUlJc3jMPFjr35AS/P2jsXnlpAUQXSlcmNCW5ytH/5HKgPT6HwOfovkS0Fmfdx/F7ElVVFFZrS61tyjD1DVl8lie1qhh/WiB/wfMLvbsB46UwQ8LZOpeiDTThNY3c4dRYlj1/Zx34yRkqC/NK9mKIOtq6OUw5nzBTATYzWmMG+AP8lU99lxesiArp6lDBZk2zeLXdl/mbZ5tfPoO3C/B+0oQ/blUWJjGlR/CU1al2u+LUVDb0DOmOHsJZxPwZcQ3SpOq9e X-Forefront-PRVS: 0505147DDB X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR0701MB1944; 23:th4xoeePfHH6dU4hsDulMgd904bnprhj3KuWnSJ?= =?us-ascii?Q?WfsGoTp2Sk5+7bP5Si5oAOLKC7AkJg0ivtcD1FcubbbSIRJ5zSZ2aXzCDJ9r?= =?us-ascii?Q?QdTPlehGdpk1g3J2AoDL46RW9fWC+DRJ0La8ZsLa0IxPpHEqNZzCpdiNZbbx?= =?us-ascii?Q?ngAui55j1GelGT1amsZzX+tUaQkXnYJVy18jrqd0nwOR5d2iQ7M9oHj9rmuf?= =?us-ascii?Q?OAxFos30xGl6RwUuDEh1DtNpZL69JM/76MppkDZfsDUdfK92gp3/EUrQL8cs?= =?us-ascii?Q?k06ZGyFBKHEic2GUzlZmm8SD5wj+EiG8xRKVps6kJ6WnOnw5Zm1Wrb6x+J93?= =?us-ascii?Q?wEoE/TPlz5k57uJHyAyFwrOw6fLD7V5lf7MZaITVN2eZShlKJ+uRA/M0JhCy?= =?us-ascii?Q?xdZVo6zF3XKX6f5xiQ9uu8fQ7G+aIGkhmeUNUg9eWRH72JT8RCevHCkTGVvl?= =?us-ascii?Q?AMqbxKnkgMqylip7El9LnCoVdAyKPY2TC2yh05xQ0MJ3XzBe2PLsw/zmCMZp?= =?us-ascii?Q?twBq4JswAR4rYFS1jvJa+H/wK+g/ta7fRSJ3OB6dOquxzEgI9QhYv8yiKJWv?= =?us-ascii?Q?4eCrwlD+jJNqYa24YUYTR8LcaEczKMc/Yw2OeACdunG5LsSS9O20jA/O1Pdi?= =?us-ascii?Q?xznU6IPT9fUmoODv/YntkwApuNl4SIBeXDsgJtZbkj197KMKjuugpPN2E94o?= =?us-ascii?Q?8TITduz3ME7KpXfqmW/5br7ugHPIR6HWng88UcfTYqnfiRPuYp70OVLrgSPP?= =?us-ascii?Q?F2L7tTM9sTbgeYXB1PTErXka7ywTOpy0LIR9hwUSWM1GhkAbkPIoAZ6oFy+q?= =?us-ascii?Q?dRnYIwLnVHDVUz2BLOMlpql0ag06KAaPL26BDfHhMQaDPvfTfURF4HjHyrjs?= =?us-ascii?Q?yrHQx2ulabg7uN+O+ShXntk8BBWp9N/A9FBQ83nSe9LvY0RRVugEBD23MBFU?= =?us-ascii?Q?T8JKIODjz7naJiiiU7IghVAqhTivrVjI7qDsp3/J/EWHVcKF8+ypaLFe5czk?= =?us-ascii?Q?/kmWLu5oTiNoEKdaScICkN/Ld?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB1944; 6:IGVO7sI10xvuWu0aiPPQvueQQ3rJNJ2Z+t7LzDIDop2suLKA8dajz1+frUP+eSyWxeP0Oszu+BHpqtgFZUKkSdLIkoeTKCpRXvFaHygsXBBx74pt6pLupuHkkXwXjs3mTIIe4q7S+MmDjLBil88RmB2BDuRkMyPS9GrUoB4JYozGm6BFWp13EB82oFeLUPBdN2j17TsAajik1TNz3PevcNlXyfAr5N/hWbRrZjxZnCG6GMbyNMZG9Jd2WU7gLYorewk7K2NAdTsZv45FcxfUvP9UlSpdDr5nMrEXndUkb44PN2yChQTkHXvgiPeS+w0WYRanw853eQ520Cp1NYLTiW+9KUFcBH96tkgFNz0MaKI=; 5:YeawoMyOqcw6xc5C3+JnSTZCVTtZN0Ls6V58iDBP4zHBjbbXh7Y9i2LTZasOfwrXF5grVhUyuimnt+9iTnYjeFAPvEiU8Qff3O6ISmWiPLFc4rKx0ugYvF6OcC9v3LDR9Xq8f2qLHrHiqESTUq6/z9xWEVio5mXrjIO8+RZkv3o=; 24:fXjURONvfayQGlF43f7+Pt9LodyYnlSl00lBCHa5mJKADk8YQmW/7h47XoTM+vDUEfioWEu+V4P9QOLW1QvsVh8pSdnEqEeAvtZcHFEiuvY=; 7:bC/lMPTRx0jQnXphULezklj4XtiseFK/ov2P+GDjzRbFaqnhcmOqkOml6pKGaUMYlEldLxD6qxdiVOUYInyIxj89S9tSs+VGi1Scf9LKZMmTT3hAXQCsH0HKjpl/3zSmQ0qjqWl3z6ld5KxnsRFFP4byv/srY/4hexQimW2vdSTP6KD+lXsg0DhKflpHiTV3KeHb/JWW2tbyFSV5JQM4nUoYBkH5f0qjzc3skQZCAdStq5qd/nGXuTNgfw0k8s4V SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2017 19:35:21.3160 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 02e8f993-3ccb-40c0-58d7-08d536972a4b X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0701MB1944 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran Get Port Database MBX cmd is to validate current Login state upon PRLI completion. Current code looks at the last login state for re-validation which was incorrect. This patch removed incorrect state check. Fixes: 15f30a5752287 ("qla2xxx: Use IOCB interface to submit non-critical MBX.") Cc: # 4.10+ Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mbx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index cb717d47339f..e2b5fa47bb57 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -6160,8 +6160,7 @@ int __qla24xx_parse_gpdb(struct scsi_qla_host *vha, fc_port_t *fcport, } /* Check for logged in state. */ - if (current_login_state != PDS_PRLI_COMPLETE && - last_login_state != PDS_PRLI_COMPLETE) { + if (current_login_state != PDS_PRLI_COMPLETE) { ql_dbg(ql_dbg_mbx, vha, 0x119a, "Unable to verify login-state (%x/%x) for loop_id %x.\n", current_login_state, last_login_state, fcport->loop_id);