From patchwork Tue Nov 28 19:34:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10080929 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0BD1D602DC for ; Tue, 28 Nov 2017 19:35:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F3EF928329 for ; Tue, 28 Nov 2017 19:35:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E86AF289B8; Tue, 28 Nov 2017 19:35:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2986128329 for ; Tue, 28 Nov 2017 19:35:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754016AbdK1TfJ (ORCPT ); Tue, 28 Nov 2017 14:35:09 -0500 Received: from mail-by2nam03on0047.outbound.protection.outlook.com ([104.47.42.47]:60558 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752410AbdK1TfI (ORCPT ); Tue, 28 Nov 2017 14:35:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EsWugzcc1n5KW1WVs6fTSxLYcZ+JoTUijHTwkMmJR4U=; b=MC9tgiEdZc8n7d92X3UMuUP0tSilPC6q7HGNTyOnl+kMi2lMi3hMiFlnT8/5mhdoaF9RQ4grrnGEMB/UEtT7S2nY18e4WPXvKDw1ZZbBfvyCnJ2SdfNuCnQ5HRwFjbzVJujJA0gOseNLrE/53+g83d7aMjFDtJr1prx9wED6BrY= Received: from CO2PR07CA0044.namprd07.prod.outlook.com (2603:10b6:100::12) by MWHPR0701MB3820.namprd07.prod.outlook.com (2603:10b6:301:7f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Tue, 28 Nov 2017 19:35:06 +0000 Received: from BY2FFO11FD017.protection.gbl (2a01:111:f400:7c0c::151) by CO2PR07CA0044.outlook.office365.com (2603:10b6:100::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.282.5 via Frontend Transport; Tue, 28 Nov 2017 19:35:06 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BY2FFO11FD017.mail.protection.outlook.com (10.1.14.105) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.218.12 via Frontend Transport; Tue, 28 Nov 2017 19:35:05 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Tue, 28 Nov 2017 11:35:04 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id vASJZ4OR013734; Tue, 28 Nov 2017 11:35:04 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id vASJZ4Y8013733; Tue, 28 Nov 2017 11:35:04 -0800 From: Himanshu Madhani To: , CC: , Subject: [PATCH 01/22] qla2xxx: Fix system crash for Notify ack timeout handling Date: Tue, 28 Nov 2017 11:34:42 -0800 Message-ID: <20171128193503.13695-2-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20171128193503.13695-1-himanshu.madhani@cavium.com> References: <20171128193503.13695-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(2980300002)(428002)(189002)(199003)(8936002)(42186006)(106466001)(50226002)(50986999)(8676002)(316002)(81166006)(81156014)(101416001)(76176999)(356003)(189998001)(305945005)(69596002)(80596001)(51416003)(47776003)(110136005)(5660300001)(478600001)(2906002)(105586002)(4326008)(54906003)(6666003)(48376002)(50466002)(575784001)(86362001)(72206003)(16586007)(36756003)(1076002)(2950100002)(87636003)(33646002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR0701MB3820; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD017; 1:kta4vZ/yGJO2vyGXVXMi6uarYfiedvyl90RnVedgiMlu2BrFImMGIK57zQ8zMtnhvqfEgb9RK7lq9dnIlhxOxUsk1Kt9mBAYw2uBDhYAbKa+kdJjJU6fjTvWtioQHmKb X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b180c3d9-2fa0-4d03-0c39-08d5369720d9 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603258); SRVR:MWHPR0701MB3820; X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3820; 3:UgkTs/unbG6H03AuI5Zt/N3oeSH4RA1euHE/S/ho2CRm5NHvlUsn9FPOYFrUVGtICjRlD2b9EJw/Plv+Orw/9NtMMtRxCRihOPQ8fMOzNd2FRW2BnhILKgZSuRo79wpd0jEzrEXpUA176iNVD9sR2RoZ4q9QRiRcj5KMnIrgvH6WZ3pmwU3oQXbieAbFtl77auxsK7kGDyfCCSasRq/RkSRjo6pOfxVC7bl4HaRRnJE2OwjLpY8C9A82XfX3YDLFY82uJCRQesipM1o1KvwGcN6lsWFKENlqZvr0j7pO+JB8ls6hpLEY1tXM0Nktrn75GeMe20kEirC0yEr1JcLmqa3FUFWu1A7YBwTt/+T4qCI=; 25:y901mMHK4IK4zN1fgGO/VCPVYyzI7DvvHBD59fH9VtHy9IIaD6aSfWs5fPdRI3MNrqrBXMfZ78N3wLJNrSqrfTPhi+SN/JJ8kQ2T1XLrSgNglfMQiGErsXfYYK6/1JcIWTA8KEt6d2JAzZVyYjEtuVZpA8RhuKEvnKe/dBcQgXwo63XMd6yy8b9miTHajIVO+OLq4P5PCg3WvB2dyAMLT5wJtoEzPZvPjtyhfZ0aFq6hkMuODYn3BUhVgXwcnpSZu65rTeKI8Fo9u5OKvf05UoXhO9mrXhomjvvYNzwS4awET92N512MfEohv5KhhFqlIloswEry3/K7Yog1zyAy+w== X-MS-TrafficTypeDiagnostic: MWHPR0701MB3820: X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3820; 31:NO0AYK67INs8ZWXt03L9dBTSJMBZ/UnBM5lkEdnSZOqbxJugiLOi8TifzBNuo8Mf8uxasCkBBa5druv4UXj++YToLxS3FsKPDdlEOn+AwWkulvXStRu81rtb0XX1UmHW0i4wNeSPdDl7xNZYncMJdyv8zyKBzrjwhkB/LgTy4R3M8uyR2+iqFvDVfGX1McqI9/8LwyeMPLeEx7XdIWXk2RprauLcBUygxKjLLraacdE=; 20:ZlgFM9PT89ixEfAmZJO8KIhPcbaBeV7FEzPDPngCfMLSVB7HgdmaM7Je7Ktf10CyVyQW6ZMTjYWBy02LjzOFEVcaOqp9wDTH3tFNde4TPMn02T5v2a/m9qSevvzZs6nr3J/QrfGkKczY6ZFcVJbFnJqLPodnINBUutsXF3QMDfHvUrwcFr89n7kLay/TufhQdQOlFA6hPDeMLJZgzsb6zcNSVxj2ymgWAcG3NNXYZM5ku0NNnzJaeqF5+tHPkACKM4jsmaRXkXHWa9zOSYc/YKYqmEv/Frya7ao2xCvGwHi9NhwOI5DWZpT1aaHX3zRJ+Xno6gniElEInE90ydp/gZ2je2CypTGOc5I+isN1l8IZs/wUkssWB21e95R812OZDtKx8Paz2A+mVRke6WY08VWvgR2mUlOE4p6QWAUb6YK5bgqo/mY6lfIp3dtYSGWhhOXuU8Jlh2tqjP4wgiSVAUnDS1iTGf/6E3XP/6KU5L5cYBkbJHBF+lwhZDQQFj4u X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231022)(10201501046)(6041248)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(20161123560025)(6072148)(201708071742011); SRVR:MWHPR0701MB3820; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:MWHPR0701MB3820; X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3820; 4:xbdmg3va5fTokj81qm/5XYBAePcsZ20Nqc9+UMAxG+2lGUq1Oz5k1QrkJuprgGbvv+sbh+2coNeUSJhQl1tYNHAytuBotIRwMU/inMEue78igymS0nqu7CkkCvJdQKNIlYRSk9WV7rCuPPA2uKmI/3xJ6qFuH4H/d3evHH3d4N0IgCO/HFTaC/1CJaLfB4ra5j6Y6gAbPvlw6NPat+bIe63Y4yeaA7OxGl3wL+7c8ZDEcBHvbHmLckyJEdlKJUmIX3B1PwKRFle68L9v7G56DX9zTHodv0co5v6x/SlXmHaTqGOgc1RBpjHMWtt7y5+f X-Forefront-PRVS: 0505147DDB X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR0701MB3820; 23:D+gkUtI70GK5YNHc6DbB3JL8H0XpU/BJKE5v9LH?= =?us-ascii?Q?stDVmB6RQ1Lxr6r/qlZN+eSAkb7ecpsfnsVpxIHB4x3ka11QyQ/OJrkjuS8t?= =?us-ascii?Q?YaoyXnS8VJBp5APJimUzE/NiySpraMFJeuRFkjuGx11Y2I807OPTe4uebmR9?= =?us-ascii?Q?tDEojbG6nXbkrUIhNt5/v6HKh8ZwLpY43plrKhoFSXkVKUULPEBxI/aw3iFW?= =?us-ascii?Q?mLK7jrYDA0XFwRjvqpr6Ej57XyVWNCK/3Vfpykw0BzPKosS8x1b2opkVI1Wl?= =?us-ascii?Q?mDm23lfDUQ4biHfJy+9lIwWsawNMr6LIgyjhJARxOwzy6vNzjEgnPaVkdyFF?= =?us-ascii?Q?9tJNcnir0PXVQ6Pc9eArrgCKxje06z1r2KjiEohCUlgzlJS8O0KdaXS9txtS?= =?us-ascii?Q?NEqFJM1RIWtTueWtcvXQi81j4EHA8miaRKOacF1QJ5wqqwoKedr581g+aYyI?= =?us-ascii?Q?gQZkFVgZxCEFpDuT5jBxzDHAVbXxBK7Tvuw+G16HJy/y4RderfQM9U4Ar1f1?= =?us-ascii?Q?/2NrZw/qPRkVpASuXoriyRO1bMgYuEZH8Bna5APXQW3c9I+lHd+NpG0YCq8Y?= =?us-ascii?Q?L+UFhIT8hEs2mAiwtd9lX7vo6NQbSxZ556Q9rDfOcLyUFsV1i27Qe5CSJdJl?= =?us-ascii?Q?1A17UvhPEXci533iDEenLDRklVPGleS8Ek4qdPu3OjuNMhmHnnpR1XfQOamD?= =?us-ascii?Q?bgpwf9KMxypwtdPZp0ER+TJQVcdl/gXOwbWBiEkPEWEcaUC7/UIo5pnoh21n?= =?us-ascii?Q?EMgrzeAFIkWbYcjlqnUGD4IUwP+KTqhI9XOoNwX2ADOoaIOCcpK1MWD0azwK?= =?us-ascii?Q?8ZzfV4BTkZSTrcJJXgXnSmDFGL/fbWJIQWiVDsZU+JnixYJ1SMNNWJD+GWRy?= =?us-ascii?Q?/ii+GdZIy7GefvxyPgzC4FgC3nAB/d2K3tP70lzi+ZV2QNtGvfHx/+8IUW84?= =?us-ascii?Q?hIHobjg3ierRwUIcQJEL0m2Mf6YHOagEQUm5JqJZ5o5XdvR2YtvK6Sw5L6sT?= =?us-ascii?Q?EOVUJ9BgfRVngxLVp0TzRlwaUhFRMqX9cQR+be2+x3vYYhg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3820; 6:KT9k0QLKwQ3ONi0hKxqUhoz2/yCHFCoIDqVfjEAkjkQrl+jAMRkjA4Ygj7F4LzPbLCAMWh/tHaShHeO8wtP9p81kO0kp79dYg03J2dSaM1VeBGRjhjWgkCektFhfse1JXiwUGIGy3LORZv4MqU+XqbUO7GYwy9QjlOQxsFZGZTh9nK6bO9lZ/l8Lg0bgTp9j0622gsuyrjINUB7bun31SoW678+Iq2s+jDW2hCwMFeaXPDvUVstBUwB98Ly5bgQeqq4DRMnWhMeSKkXYXP6z5HbtyQzW715H0Xre+O11NGdhW/872rBTYTvC268dI+bP6hdeOUcHueXFf6Z0gxZSVH62mrA5OlW4GOQ2hhenpts=; 5:1rmWj8dSGOA3UGgi7THlIRfIv8i4QKfZ7+znokN1MD3NNJKQBcOG8e2Wqr07REqKng3K+O0PHL7jvRsrNMlING51OiUVw8bpcWo6GVadqp6dymP74lp1GZ4YqdlZDdyhUVIw1tc/NwubUQYtUeBVJnh10XmB/VjHJteKZ8/wo2Y=; 24:WcHUjkt4ZEE1oCgEt8AhvV2iuQGsbFvDoZGD7ZQlP0lBjPR1pSuQ9bYLZgLF4iRHivHQtjAniNKqTU8+sOpLxntXBMoaXpJJPrTnHgYAKQw=; 7:rg2vp/N+jveF1V80RCm4H9G+X8VFNPmNhHTG8HSd7xEED1Yej/Wj7+EdJVixO4Q6DSavWjOs6QEZJGJGGgDu9ik40lGAgyT1qskbpkdlW9OaTFUkdSd7wxhUcKeib0zG1BtrJzy7ecqtw2XKU0rEsokeWcUZnft1yknHTcbCB6SxKkICylTHussbVYexI2vGdva5ef/peGPm2bpBbpNZqw2GbMxarnZ7QqNUC06LucgBx+ErOQRmlbot4TjESfjH SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2017 19:35:05.9666 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b180c3d9-2fa0-4d03-0c39-08d5369720d9 X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0701MB3820 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran Fix NULL pointer crash due to missing timeout handling callback for Notify Ack IOCB. Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric discovery") Cc: # 4.10+ Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 18069edd4773..1259ec85ec0a 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -665,7 +665,7 @@ int qla24xx_async_notify_ack(scsi_qla_host_t *vha, fc_port_t *fcport, qla2x00_init_timer(sp, qla2x00_get_async_timeout(vha)+2); sp->u.iocb_cmd.u.nack.ntfy = ntfy; - + sp->u.iocb_cmd.timeout = qla2x00_async_iocb_timeout; sp->done = qla2x00_async_nack_sp_done; rval = qla2x00_start_sp(sp);