From patchwork Tue Nov 28 19:35:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10080967 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 09AD3602DC for ; Tue, 28 Nov 2017 19:35:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F1BB12964E for ; Tue, 28 Nov 2017 19:35:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E6E2129650; Tue, 28 Nov 2017 19:35:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1C9FF2964E for ; Tue, 28 Nov 2017 19:35:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932153AbdK1Tfw (ORCPT ); Tue, 28 Nov 2017 14:35:52 -0500 Received: from mail-sn1nam02on0048.outbound.protection.outlook.com ([104.47.36.48]:60096 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932168AbdK1Tff (ORCPT ); Tue, 28 Nov 2017 14:35:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=LQ3IMelMPGwzMkBKqzwR9Wn2V1QdML/9+L/oQh3QowM=; b=F3r0cAqpK8M6e1A95JUHVpZecPd5XZa+eHrKVaf0pUY6Egn932aFasYd0/CCSAad3/uSZMZYOFTJ0Mghe+PVSA7mS+cP/pl6g5qJDBjAYSsv5GkoIrPY0qj7YFeduWOO1ihPkItRYVUzaishzTSMHlq6jHVvmUfd3NFgmVaPMYc= Received: from BY2PR07CA0093.namprd07.prod.outlook.com (10.166.107.46) by BN3PR07MB2513.namprd07.prod.outlook.com (10.167.4.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Tue, 28 Nov 2017 19:35:34 +0000 Received: from BY2FFO11OLC011.protection.gbl (2a01:111:f400:7c0c::151) by BY2PR07CA0093.outlook.office365.com (2a01:111:e400:7bff::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.260.4 via Frontend Transport; Tue, 28 Nov 2017 19:35:34 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BY2FFO11OLC011.mail.protection.outlook.com (10.1.15.22) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.218.12 via Frontend Transport; Tue, 28 Nov 2017 19:35:33 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Tue, 28 Nov 2017 11:35:07 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id vASJZ7bj013806; Tue, 28 Nov 2017 11:35:07 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id vASJZ7x6013805; Tue, 28 Nov 2017 11:35:07 -0800 From: Himanshu Madhani To: , CC: , Subject: [PATCH 19/22] qla2xxx: Remove aborting ELS IOCB call issued as part of timeout. Date: Tue, 28 Nov 2017 11:35:00 -0800 Message-ID: <20171128193503.13695-20-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20171128193503.13695-1-himanshu.madhani@cavium.com> References: <20171128193503.13695-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(2980300002)(428002)(199003)(189002)(105586002)(101416001)(36756003)(4326008)(50986999)(72206003)(356003)(305945005)(33646002)(8676002)(81166006)(81156014)(47776003)(50226002)(76176999)(106466001)(1076002)(5660300001)(48376002)(6666003)(110136005)(16586007)(8936002)(189998001)(54906003)(42186006)(50466002)(69596002)(80596001)(51416003)(2906002)(2950100002)(86362001)(575784001)(87636003)(478600001)(316002)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR07MB2513; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC011; 1:0iR18EhlKC1hDLllR2ZROHtj4RSmgUshlDZ20cW3cYPnGQRW2/arZUM3DI/yz0Bi1n4WTJUscHu/QIMdJBtZYyle0Gn/B+cwXm6nG/2x/RxU3je+mRIsWtopL9+r/eEC X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 08e9fbb1-6f50-4f3d-b4ff-08d53697317d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603199); SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 3:degPsnvWNVX1Mf1fhQqQMonKK/VX7piKzFBV1141FP992VCfGYkySpO+6b+/o2nKpGB/a7prbciz1pnSRg+coRHlghNSMgKESkHVV68b/B8JRw4Voj1aT3rcVwI+AJBkJjnHns4+9q+qjLHmoWaQhfIDOUAyrbL75WJ5UTvzJNH2iSKsiIGnVcHO5pDZWm/VvZAzDM4jv/Lj/Ndijcquv6YDEicEEm2rBF7hNLJM7oBrBxc4VrTs9JQyFQfqFUDRWTWWqft/L1khtSMAk+j4fd7TtnFTHyorv8KdhhDTrj1eZbxxp2Bk+/JjK7VUB89ueJYYPZcthPO/ONvk9PAaxk6BMSzYkk89KWliDmVuj/w=; 25:MSM0tIylrKg/hVtyIXeCAeLuJh7/IE45ew4bAMVej3jkf614x67ozSL5OE21V+USNGF+dBdhp2Z8kB9APD5moBqxv8adOYarJtByn7KW1TnkmThCb5HAFcsUzwbDFcZ1c2BdwOzMUCMsSjzdRfSIth7qpqGlMD/TQ1OMTCYzWl0GGnBUxxx/Hj/1pyB6/eSMF6D7bfxwfdyU4ce5zauaPlr32CnbIVyZmSBMdPfHkNZFnwQ4Udx0fj2hN5KCMXYPxaVysxddEyzcQsVYzUoq/KBUQCV3AwfLdELQZv5VCyoZL703ynG0DjqWl3EiAQsa6reGUC86b1F4P38wnL+c+A== X-MS-TrafficTypeDiagnostic: BN3PR07MB2513: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 31:cu700LGCQdX+wIz4B5uWVvK4L+YlTiAD+Ul2B7y3s3JJPvMHHhZrpp1fDJw1XmUmMf9Bm5Muz45fQm7qx13QUdcjSYD5zNwtVoteud7QjThIqhf+tRG3+W5vzQpjsqG2RyMN5peaLB2YUTThftZ1p4xcfW1htrDsoGIezFsMD3b1/C6yh9V+uyCbwJN9CXab5WpIz6pzEvVtYjy24tUChJfVaqKq+866sIYSYaWeCL0=; 20:zt9CMilkidiDbDiBEcRtZSQlS1xS3RjD8Wgoh/Zd7no/NQbFxuIkauLCUthbQhGXZK+pV+ha8vtvdA9fUruW2RFrvxXcSEzpEEcSeaLJ01bpFALgnWpuuCxO+vjZp9lNwqRZ0IVp7z+aRt1BQdFV74Lw4D/5pb0aQMWSxxsfonb53edyAwBWkLDa4Ou/H8zTTLg7yZddWDGRm8SubN6Hth7QK4yRfaCqJ47ecq+VncklLUg0MGkCxQXZcsm5Fr0McQyB1wY9PowJdQtLpfyUKtEHygL00TtCnrt2Iwm9DKonH0vYZbgDRaMa0dx+k5uvHnWpHvWSWEHvc+rIF/hOzp/0J8QnILsxssVHSELIf9+AiR9OvLWljhkyOayy4y4qQtWzC49cQAj/gIWA3KG15UJUCADA1ZsOQwlXCyTcqLNdRsbtsW1f2xY69yLeYb5NB43PcM+VzRzkjFyLw/GkmwsM0XRCL4qSm89ex9cRJOj3aZhQuDDCL60WX/W+68cA X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231022)(3002001)(6041248)(20161123558100)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(6072148)(201708071742011); SRVR:BN3PR07MB2513; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 4:zuYUPIX52McOhTXe4gqSQMpe5PBr2FTvoqQVSx+vrWlmvyy3s1Lrculj5u13Vv+mbjnA3LQHraf8o1Jpfke37ECYlP3jXrwatjAAlM05TUXzXHDXFZeGm4BrCUsLVLfS7qeJvl3pvPZtMBuDwzgZ/qUURvSc3lzpN3QPBNVPDmCMob1tmd9dI6E2JXrkuvcEa0X0GP22eaKOOOG2Av3tEd9pHBGpdUrvfVqve5LirmX8lg6hm/TFKGALkvl2Ot9IsnZCMgZvQQMlSn2Nx2yT+gWRroNyBtNmFulwy5M5YkIWS5G82ewGsfGFePhSFHqn X-Forefront-PRVS: 0505147DDB X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2513; 23:eY5EdZGhQg2XGBgsW2eLKL80olbs9IxvXI7+y6H93?= =?us-ascii?Q?kfPSaqtK9SXeZQw6FH7vHpJnixVvVw8+gnEl1py59+03OgR2CBVVeimmQ1WY?= =?us-ascii?Q?NMIInW5Tqiu+nddimyhNDcDtPCaeLO1xW5CiHYkWDNhEFg6STC6143YKcIMK?= =?us-ascii?Q?hNeWx5yOSzK0/4Bmo9YiVEnysgIEysDAiduUZbVQg4wEq1eA/DkbEVh3taPP?= =?us-ascii?Q?kpomeDkd14Wdf3uNhBcyaBLrhY0pyRIwJgOflfE9huqmFfKrUFJSz3tZiLoD?= =?us-ascii?Q?avu7tDZKQ04eM0ilOM9pubqn+d3sUzVA1HQ4PCXUaY0VajB68JMMeUbg2P0V?= =?us-ascii?Q?2F1oi/8e3AjRUIlMti6LdtqKQYqwYHBfAX1LSFM0vZR90OFFNB64LQg51TMJ?= =?us-ascii?Q?1J3TvniHZrykS0WXzbKr+HAkRL5MgLugzh8DM8ahojbkkYIZy9aHd7dddv0c?= =?us-ascii?Q?6cE0LgM8G38PEM9/NbBxO5Hkjij3ts+zW0CSwk85c/S9zzqxHlCPPwSf/Wae?= =?us-ascii?Q?KjVwxIX3dok9vGCbWboiHjryDTpf2/UdseZH2BNPICY3UWf4aRR38EjnjyCZ?= =?us-ascii?Q?1Mp1775K2HfSIPNJ/2O9/Xxd8UugKJ2zrXH6dQpcsd5Rd7/DUFPH3eIqeE9U?= =?us-ascii?Q?CiHrjjCfdY+i29jRbcY9nkuXP/Zui2KtWNwIJd+GnUOpliuftJUVj0MNPOkc?= =?us-ascii?Q?DrjNeMTOopDN3TvNuIyAiBcW9Ro6k30ePUoew9JIac6Fg5oWxClotpGhpfeX?= =?us-ascii?Q?sl+8bZTeg33UFTRR1/OKk2jY0+RGCqDaqJtwAjVDzB3FV5uIu+fasQrzxKiX?= =?us-ascii?Q?/bmFLdEOWpaTiCEbx10Jt72pt1DjFDY0JeBV6ROMt96FVDDITL19LDZ1LSPB?= =?us-ascii?Q?5cPRSzibrSwopfXf99QKhJrvpFhN3uJCnCYswJHOObRBvMPUemvH/hQZGMUZ?= =?us-ascii?Q?VptNBmo2/Fh+9Xo3vc8qzV20378F5oqGnP8VHjjv20Nwr9x83BQj4/rUn8lv?= =?us-ascii?Q?7Cs5eqmgQhJf7tBUpffN6t3L7Zh60mHoD0IeKvUX3mqBigdPx71XnVIEEND4?= =?us-ascii?Q?mD/aSI=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 6:9oVZoRmiaOVPmAxOUoA1lZx9XpwFWvZVmzs5OkUXGr+UFv12PyCTdWVLveqHb3y7iTLd3zLAYk4m0izhcN+IFNZK3uzWQBNiOqO801lxdi7puSOx+p1DaPUvrw5YoE2CmhpY6ijT/9/zMbJ0yvL8GfjSEG1w1YYOUWqAbln3ls0ofWBN3rvuwlCKDEQgNSbb3Xztvw3Q0mb942jpSntk4LbCGlJKKgGLVPwvOY+nE3+/fD9YDwIVHuU3bVwcWNMyXdx5HXiJnxvKiMrkvBS1NZPDJZYWd/P/jQpEYO0V1ujFCgqoHQhiE1cNOaAhwubJU0Uf6H/wxJbNgLhOnbV9EQ3eAAK5PL78JGBWKc18L0c=; 5:du2gkYL8vEfnUIKMeR0auWYF60pGUrx/LQ0/GaxTAEJPARYNZq3Z6BtxyldWyXYqO2ubUow9SULtWrWdht9pkAF959zl4AYsxeu1hcUOFp4IB21hk199qp/UgQi4PxLVwKDoqGN/P+rtUJF0rNeSSKr3/TUqgelTSbcSUCt83JM=; 24:JQsxHzg/saqR8rBXOSnE/d0vHhefEVkNF0PwCve8HL6emlTiQD+COqbqWUWHo1g+lP43tLUnqOd67x8G1WT50KnEyDumxFX0Tfe+uCth9p4=; 7:FgHr5mFoH1zVuTXyVhWFR6g5nyJUXzVA10M+tblTvWnBFx4wTxTpP4ZkSvX7kjkXUTOtsaALVdJIg7pkTShRDG0VRrANmeaFLREWc2RFUcVcH8xzp8Rg+dsSI2I4NHSp++zSH2laWz7a3uWjylVTABw+MnXiiWB4l5I8E83ayPLU2t+Dheze6kTcBCOpXZ3N6KVH6EeO9MX8uCmKPV0rybA/Iw5KUNu/wy/8+kJL6jE7jT/Ej4qHAtapvjXc0f0y SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2017 19:35:33.8892 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 08e9fbb1-6f50-4f3d-b4ff-08d53697317d X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2513 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Giridhar Malavali This fix the spinlock recursion issue seen while unloading the driver. 14 [ffff9f2e21e03db8] native_queued_spin_lock_slowpath at ffffffffad0d8802 15 [ffff9f2e21e03dc0] do_raw_spin_lock at ffffffffad0d99e4 16 [ffff9f2e21e03dd8] _raw_spin_lock_irqsave at ffffffffad652471 17 [ffff9f2e21e03e00] qla2x00_els_dcmd_iocb_timeout at ffffffffc070cd63 18 [ffff9f2e21e03e40] qla2x00_sp_timeout at ffffffffc06f06d3 [qla2xxx] 19 [ffff9f2e21e03e68] call_timer_fn at ffffffffad0f97d8 20 [ffff9f2e21e03ed8] run_timer_softirq at ffffffffad0faf47 21 [ffff9f2e21e03f68] __softirqentry_text_start at ffffffffad655f32 Fixes: 6eb54715b54bb ("qla2xxx: Added interface to send explicit LOGO.") Cc: # 4.10+ Signed-off-by: Giridhar Malavali Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_iocb.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 106f4ac4f733..8ea59586f4f1 100644 --- a/drivers/scsi/qla2xxx/qla_iocb.c +++ b/drivers/scsi/qla2xxx/qla_iocb.c @@ -2392,7 +2392,6 @@ qla2x00_els_dcmd_iocb_timeout(void *data) srb_t *sp = data; fc_port_t *fcport = sp->fcport; struct scsi_qla_host *vha = sp->vha; - struct qla_hw_data *ha = vha->hw; struct srb_iocb *lio = &sp->u.iocb_cmd; ql_dbg(ql_dbg_io, vha, 0x3069, @@ -2400,15 +2399,6 @@ qla2x00_els_dcmd_iocb_timeout(void *data) sp->name, sp->handle, fcport->d_id.b.domain, fcport->d_id.b.area, fcport->d_id.b.al_pa); - /* Abort the exchange */ - if (ha->isp_ops->abort_command(sp)) { - ql_dbg(ql_dbg_io, vha, 0x3070, - "mbx abort_command failed.\n"); - } else { - ql_dbg(ql_dbg_io, vha, 0x3071, - "mbx abort_command success.\n"); - } - complete(&lio->u.els_logo.comp); }