| Message ID | 20171130034047.15070-14-himanshu.madhani@cavium.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 11/30/2017 04:40 AM, Himanshu Madhani wrote: > From: Quinn Tran <quinn.tran@cavium.com> > > Get Port Database MBX cmd is to validate current Login state upon > PRLI completion. Current code looks at the last login state for > re-validation which was incorrect. This patch removed incorrect > state check. > > Fixes: 15f30a5752287 ("qla2xxx: Use IOCB interface to submit non-critical MBX.") > Cc: <stable@vger.kernel.org> # 4.10+ > Signed-off-by: Quinn Tran <quinn.tran@cavium.com> > Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com> > --- > drivers/scsi/qla2xxx/qla_mbx.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c > index cb717d47339f..e2b5fa47bb57 100644 > --- a/drivers/scsi/qla2xxx/qla_mbx.c > +++ b/drivers/scsi/qla2xxx/qla_mbx.c > @@ -6160,8 +6160,7 @@ int __qla24xx_parse_gpdb(struct scsi_qla_host *vha, fc_port_t *fcport, > } > > /* Check for logged in state. */ > - if (current_login_state != PDS_PRLI_COMPLETE && > - last_login_state != PDS_PRLI_COMPLETE) { > + if (current_login_state != PDS_PRLI_COMPLETE) { > ql_dbg(ql_dbg_mbx, vha, 0x119a, > "Unable to verify login-state (%x/%x) for loop_id %x.\n", > current_login_state, last_login_state, fcport->loop_id); > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes
diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index cb717d47339f..e2b5fa47bb57 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -6160,8 +6160,7 @@ int __qla24xx_parse_gpdb(struct scsi_qla_host *vha, fc_port_t *fcport, } /* Check for logged in state. */ - if (current_login_state != PDS_PRLI_COMPLETE && - last_login_state != PDS_PRLI_COMPLETE) { + if (current_login_state != PDS_PRLI_COMPLETE) { ql_dbg(ql_dbg_mbx, vha, 0x119a, "Unable to verify login-state (%x/%x) for loop_id %x.\n", current_login_state, last_login_state, fcport->loop_id);