From patchwork Thu Nov 30 03:40:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10084171 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CDE1E602B9 for ; Thu, 30 Nov 2017 03:40:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C460429935 for ; Thu, 30 Nov 2017 03:40:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B91BA29B02; Thu, 30 Nov 2017 03:40:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2B2F329935 for ; Thu, 30 Nov 2017 03:40:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753151AbdK3Dk6 (ORCPT ); Wed, 29 Nov 2017 22:40:58 -0500 Received: from mail-by2nam01on0060.outbound.protection.outlook.com ([104.47.34.60]:55301 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753066AbdK3Dk5 (ORCPT ); Wed, 29 Nov 2017 22:40:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EsWugzcc1n5KW1WVs6fTSxLYcZ+JoTUijHTwkMmJR4U=; b=Om+0bm/WZTM4EYAKiRWOnCDaQjGR3OifZXke2SdvKTQt9JKy964eL4Sq/NW/X1k5RcvObJ7e38Ztyr2nWt0JXnXFBKl8uKJFmNDyT8HwEgO1aO/dqk/uVg0D02wmO/6aQbYBsf3jf6jfquPxdLcs+8fEuQiAY4Zs8yNW7izyoug= Received: from BY2PR07CA0091.namprd07.prod.outlook.com (10.166.107.44) by BLUPR0701MB1939.namprd07.prod.outlook.com (10.163.121.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Thu, 30 Nov 2017 03:40:54 +0000 Received: from BL2FFO11FD049.protection.gbl (2a01:111:f400:7c09::119) by BY2PR07CA0091.outlook.office365.com (2a01:111:e400:7bff::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.260.4 via Frontend Transport; Thu, 30 Nov 2017 03:40:53 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BL2FFO11FD049.mail.protection.outlook.com (10.173.161.211) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.218.12 via Frontend Transport; Thu, 30 Nov 2017 03:40:53 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 29 Nov 2017 19:40:48 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id vAU3emcg015109; Wed, 29 Nov 2017 19:40:48 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id vAU3emC3015108; Wed, 29 Nov 2017 19:40:48 -0800 From: Himanshu Madhani To: , CC: , Subject: [PATCH v2 01/22] qla2xxx: Fix system crash for Notify ack timeout handling Date: Wed, 29 Nov 2017 19:40:26 -0800 Message-ID: <20171130034047.15070-2-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20171130034047.15070-1-himanshu.madhani@cavium.com> References: <20171130034047.15070-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(2980300002)(428002)(199003)(189002)(50466002)(478600001)(106466001)(305945005)(101416001)(87636003)(47776003)(2950100002)(6666003)(575784001)(105586002)(50986010)(76176010)(86362001)(356003)(50226002)(5660300001)(110136005)(80596001)(36756003)(2906002)(69596002)(33646002)(1076002)(54906003)(81166006)(48376002)(42186006)(81156014)(316002)(189998001)(4326008)(16586007)(8676002)(8936002)(51416003)(72206003); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1939; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD049; 1:bXXflPnujalIInB/5qYUV7zHY6hNpFVkq9NNEOzDU0ZOtYpOqsaRt5fQFS51nc34qCS3it3M8SOmTweHHCwbJ+Uj9ymQzMcYj4DmgI60nRzAMRzmIlpQCsyjdAb24ehh X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9dc5ec15-150c-4fba-a1d1-08d537a4289d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603280); SRVR:BLUPR0701MB1939; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1939; 3:h5ad5cyCAOi+nDF1ZFSp/x1ISeC/aXh89v2Wx82lgVIml2kTS21C3KBsFVeOgVZQLC8vQUqYFmR0cOk3iAYw2AjpoavSLm9SaMe1RU0q/O8Yg/y/L49TarqrLGd3Khd1VCJD/arEGX49Hub5wuXZepbXs6SDlAKLx5LX/vN3PhcI5Wm66k9cLqCpTDardSfTN3gMMFXQAfmB36WnzrSXjhkd8gkPMlfnJ4sMzYg2L32T6jgYiIq+kiyGoFNxzV/ca/tJHrA2O1DbnTxwf7eWkLZXkELG0L6gHYrew8+azW8ZaGvmIMl3CzxEyWxn3DYeVT3pQubwhxy29gLGi0tNaBPPqv/GvSgLrCnL6tCNhVM=; 25:FOnM/gnMY66lmcKlxYMEDhBTR/THswLMg0CfKpgj0kAvTBFzDHKJoYQJzWN7B4jnlscDuWqAPaxZ6fOcRC5TR5TN4/hkVbEUtvNov+3IEmrakN7hHdsI5Jzhd1rmcOH4epRrH8HtpLKPYiAM60UDKFaWIJYOhmiIvoxnoPg6kKmh5rixSpE2cfO4Kdc9vna5E62uhy1LFSBnIkz9Z4tTqm+LZ2+0jAO/t1udG/zQMIP62vbtm7lD1n1VPzkrUS2LNFMRwbzLuh7yY8i5jBzcDtfwrik71IYl2jv7KiU+ULEhgkBfnAk7hkbVxA5MJeJ0Im2Lr3c3C0uw35TCBCbIZqwrFCNMJ4BVC2WO6iA6rCE= X-MS-TrafficTypeDiagnostic: BLUPR0701MB1939: X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1939; 31:GCKSfJvNmoYNKNrwfOJGPcrmJB4UaV0v+wo3TuY7F5WZYMBtHmN1900UuA+Te+2CICjJGeHwcOxuXNIOrxHi3IOnBuBs3re4FVG+bzxoy1pA1H9XkCj1swYq7YV4RZb/FlEnfKJI2ofsK/IDmQ6f8x0WULb4qcHzYwwadAmGbCHNQiz2bQOOvejzxbCoSa30qsnvzY2allubkAakfFbBtYVhuJot5F0l++yfJFV4N58=; 20:ZQ0JGMW8OzpdvZ8mv0JSOUKCLRkI77p4700EKLiXD2+fS40t2lCxFD+Xf9UsL4dxfGuiIilsZURoW99sX+uPazXt7ExwprkRPva2vKRI9nJ04XZD1GCGb/G/7wnCdC57qO9YZGhdaAWlSds1/psD7pdSCH6nCfUXqOL3rJX2D8gX6H4ASxXBVi/g4/Mwoj8/Gz+J1lyPWyFm0TwjqL/qGpY/a+qrhhESavVuo0oRB8FTfNLZ3H24T2kFgWbb7e+hKHAkgwqqOZIWUXy/saEiQXRlneU0+OnvfRCIaSdok0kKYwhM1aJdEHCKjPkQsKqXvWw+eI6z2pOQqcXnoQ6XSGpzTbWOXzha0573Ulqr7HWIKYk0JDeULY43idlCXM+ZJTrrKWWoAXxKtf/7drAJZylWK6v0mEAiyFreLt+oLbgP+WSLZKHJP5YyBVZ3OW8tHlJ9aXM2Bwy1dX8ySTibJwM3VAbiStp02m9/6z+IHvnSKyIUe+cbg8QRhvrEWKJL X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231022)(6041248)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123558100)(6072148)(201708071742011); SRVR:BLUPR0701MB1939; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BLUPR0701MB1939; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1939; 4:siUKWS9FSfLeRIkgmm9GQj4jYnaHdc6dY7OZF/FGK4yMpUsFHnqRBs3NUpJdLmMGypiG00OxRF4howf2bKmiwKFF0oCu8jzdByyN3YSuqaXUCR4rA/bgpaAjkBR43OCCrJinq20Y6Vd0Df99AtCEp4BriQtKRtKlLS8CyNIz7yaIGbJzYd8y6Uqaw7Z21eWXKdx6Qa+obAesmJxkBj/NE/9CyMrZHVxe+7dRNE067ESFov/eB2KwbtDTLJEv0Bm9UpWPWV/7HmXbeZEa7HYBWowskl1LtDzIrIm1OFMspT0xkSuLJCAOGBsgUngBCCYr X-Forefront-PRVS: 05079D8470 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1939; 23:VeJ5KrlCy+mS2T0e6sdrRcFElcUyKVVv2RryPdT?= =?us-ascii?Q?Q0AQb+/dkSozrNcBL9loIciv6WsNS5a5/2gM1nX9XVK4AiF6ji154obVvnRW?= =?us-ascii?Q?65R+y6oPjs3cve0DwPef81mOinyFlEGHY5O470W+hLM3b90B0op57d8NJnLc?= =?us-ascii?Q?2YH19jha+eaVKw5TioiuDOhwzQD04vR5df+nP8Ia6Bx+jW3DGzy4o98sBK4W?= =?us-ascii?Q?l09GmRWfNJGF0BSWM+8u1Gr6zsjiO1BTDsM29Px8c5qMLjPMlboPqm/HmTbL?= =?us-ascii?Q?V+Igs38WphbH1U75FnAjtozEyNXzHRyvLk127DkR+Elgk7Uh8pKbbvuABMTB?= =?us-ascii?Q?UWEqUtHoXCn4NNrHz+0YWYwcooRHjkO4+0BCBHBU6emZBaR50ukPRsol5xd8?= =?us-ascii?Q?KH1fTIKP/khWKJOJJhV5i8BoErK4EiWeaMtaHvnR4CR+etrrZkZtENvWe/9Y?= =?us-ascii?Q?nmg9py/plevPCc3cXucP4WuFFlJSx3Hpk+D3GK6pfguuhLiJX+UD/OlnykTV?= =?us-ascii?Q?CYzxl7vUxtVWONJCvDinz798PGsGPnrBdNUlLggZfHAov41rTUumXhx4J7r5?= =?us-ascii?Q?4hLlgmlMGiRM4SiGHUMKJZj/gc5UpIe6ycU425KAelnJ9E5ccbQz/kQ+9yU/?= =?us-ascii?Q?1XyipPhZGrC31ODWCP6QmwogMV7YWrssW2VBhpfGlnD4ti9OZacCGWC+w/2z?= =?us-ascii?Q?64TxSJylX2N5w20Wkm4zK/KPFYk7Jwad4CrAT+riez225iwNmxS+LLdXcbMZ?= =?us-ascii?Q?9IJHCNWMw5NOAUsuaO9eVu+hAEvwy9psgVHUcfomojCZzVOQr2lwsKDrZ/UO?= =?us-ascii?Q?zIsS/OLdGmMQI1reTNkwtJL+Vz7n71fkzMHqHt6vThbRbKJNaJGLLc8ymo4s?= =?us-ascii?Q?KlUz2srZH9+0dmyNRrIzAQjg4Ls6QFMGsv7Bx0OkOiUrlQQ6pSMx+MyhVnzk?= =?us-ascii?Q?748/XznbgZaifNCVj6wM/cHH0mzh4fGMUCrp1gJmuenQvBqtywZj38pxmX2E?= =?us-ascii?Q?EtMXOayu/IZQD6PVi3th4MtMfD8UuyFCmB9Kcz1DwHzWVUw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1939; 6:36LkDoFClAKtGwE43ZQ5ocam1ch8QAZEfUH7OojadT5tsuxC5vJGl0gBqPqqmLO7LJeCOur1owRLfYeZP/qWuuhubLfluQCve0cUdFDkAWndzihV1GFuFwU373SebNW9geYJYsuoMbfa2Dqj5ZJ3RAVIljYuHs8X/dFVnSVALeyybgZXYF/0/o5Zia9DvikPXDunbuI1a1ESbouc6DrMkG0o7o0OQYeHtENDiHr5clZqxp+Wys9oyyPmK23kmMZgRJgGAgiZI7TDtnHbjZp8gwoZospiQb0EkF/tsJ5JkN+eWnxuD5y9nN2HHpyBhXRmzy6J8H6TDLpxHOfe5mQjYpalMBvKP3mJnKL80lc49ZI=; 5:q+P1+1PAC5aj0MNeQtV+7XMf0cXWP947GS8G31cs4KfY0dTkLlK9hoivhl+oRf7nSSX37iJj7xeutow4qRPRAteEECUeIc9ZBfX4tB32JUYnMEyyb5WHHA6lno7BI13nVsjJG6APAtNL1Z0Zxz2vo0rIJi3eBGyxD0fmpJkDZac=; 24:eL9JpQrcyThanwE7GYFcfSWtB+3rApsjwygmnuv1CGeyzYXN2RkPjsak1/F5C6tGq08bNmvl0jEpisT1314V2f5elr+eoesdJ/eyMxJuedI=; 7:gKRBu4wd9pQg2i21zUH+7lsdvOisPpJ2ha06dzu3z7SZKoGzuMy4Qw7nJ321Fb8U9mNGdzR/h6pLxXE66cMvT3AFYF7bJkY6g4VRDdL8/tBVfvGwX/dg3NOVRS6OOZvQy4P085N1qsc3btocRaaKtTSNAWJw00AFde+lnjOnvjZjIjbq77q8P3WfwutLWrzknTPff4/8omWQG7ZJG/3icWkripw1/NAA9FPk3ztQ8puhGKinNofwwU8Jf470MgRo SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2017 03:40:53.4321 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9dc5ec15-150c-4fba-a1d1-08d537a4289d X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1939 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran Fix NULL pointer crash due to missing timeout handling callback for Notify Ack IOCB. Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric discovery") Cc: # 4.10+ Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke --- drivers/scsi/qla2xxx/qla_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 18069edd4773..1259ec85ec0a 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -665,7 +665,7 @@ int qla24xx_async_notify_ack(scsi_qla_host_t *vha, fc_port_t *fcport, qla2x00_init_timer(sp, qla2x00_get_async_timeout(vha)+2); sp->u.iocb_cmd.u.nack.ntfy = ntfy; - + sp->u.iocb_cmd.timeout = qla2x00_async_iocb_timeout; sp->done = qla2x00_async_nack_sp_done; rval = qla2x00_start_sp(sp);