From patchwork Thu Nov 30 03:40:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10084207 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0BF4B602B9 for ; Thu, 30 Nov 2017 03:41:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 020AA29935 for ; Thu, 30 Nov 2017 03:41:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EAF3B29B02; Thu, 30 Nov 2017 03:41:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 583B229935 for ; Thu, 30 Nov 2017 03:41:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753367AbdK3Dlc (ORCPT ); Wed, 29 Nov 2017 22:41:32 -0500 Received: from mail-sn1nam01on0082.outbound.protection.outlook.com ([104.47.32.82]:29664 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753296AbdK3DlV (ORCPT ); Wed, 29 Nov 2017 22:41:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=LQ3IMelMPGwzMkBKqzwR9Wn2V1QdML/9+L/oQh3QowM=; b=KtBQ5bn+88Ir2fXT7rSSXt6I3d/omQ3FMndAcH/Sb6E5HvhPZhjhIx4Z84i6u14nhhAjWcH4C0t/Kd2lp0QSKwFuzVLNWYouylVkvqdDDO/92mkHKd9qdXIFg0/5QYzu6ao5ThYS3bRwXK/6WFcgxVCMxMROCOjK3q+8FIvWo88= Received: from SN4PR0701CA0024.namprd07.prod.outlook.com (10.161.192.162) by CO2PR07MB2519.namprd07.prod.outlook.com (10.166.201.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Thu, 30 Nov 2017 03:41:18 +0000 Received: from BL2FFO11FD056.protection.gbl (2a01:111:f400:7c09::140) by SN4PR0701CA0024.outlook.office365.com (2603:10b6:803:28::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.282.5 via Frontend Transport; Thu, 30 Nov 2017 03:41:18 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BL2FFO11FD056.mail.protection.outlook.com (10.173.161.184) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.218.12 via Frontend Transport; Thu, 30 Nov 2017 03:41:18 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 29 Nov 2017 19:40:51 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id vAU3epha015182; Wed, 29 Nov 2017 19:40:51 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id vAU3epEN015181; Wed, 29 Nov 2017 19:40:51 -0800 From: Himanshu Madhani To: , CC: , Subject: [PATCH v2 19/22] qla2xxx: Remove aborting ELS IOCB call issued as part of timeout. Date: Wed, 29 Nov 2017 19:40:44 -0800 Message-ID: <20171130034047.15070-20-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20171130034047.15070-1-himanshu.madhani@cavium.com> References: <20171130034047.15070-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(2980300002)(428002)(199003)(189002)(101416001)(106466001)(81156014)(69596002)(356003)(80596001)(50226002)(305945005)(47776003)(8676002)(33646002)(50986010)(76176010)(48376002)(105586002)(81166006)(50466002)(478600001)(189998001)(316002)(2950100002)(87636003)(72206003)(54906003)(110136005)(16586007)(42186006)(1076002)(4326008)(5660300001)(36756003)(2906002)(8936002)(575784001)(6666003)(51416003)(86362001)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2519; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD056; 1:mcRMmcbsHEfQvlJxC9+ZPxvv/od1bmXFUEqTYHfbWpQkdwIklhLgjP4YLp02h+jkTRQniK5PBqsUK/ff+bfqujRoD6En2XBsbiL04/5L7C4rwGorsu0mOCstCi2YMTnd X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: be0607f6-790c-4b62-f9f9-08d537a4377b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603280); SRVR:CO2PR07MB2519; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 3:GPxfk0ut1DuHw0E9QbJ8AkuSlFf/xNQHMC+RKeq3m+Ojn7bS+oe6X2hj0dp2gXnoqS37iBZhyMhkybOj0yq3v3V04s2nrgPwkFHn4v2u52K+PfvXDFIp3ru8S8DuMTQgnwOFCy01QP73khPQVPzlFP4+2e51KAAYHgH61gr1PJ+w818j+Dynysxviks6A7kB0Ux8t6ah8rMf6u//0EDxieT3sH6Rme9J3RhK8sz6QXUgiUGB2uqpgM5Z1Ce3W7FFrOBVmYJw2pGZu48WQfecLcB0n9IPdNBKG22+36ZL0zCq5qcTnKODnXDeqbKZsG+htYtaZ6RvTkcmyg74db/y6ePclmzdeVsDRVbeVks+6jY=; 25:moyk8vtVMRtcBWeYAdjADjv46LhstdyXJW9csyNJabSxgVB9s+3flyj6UiKNKK9VgBKG1Mb+g8s7cxafaC1LvaFuCiW59TA6W7yiOsIysbi0Olv9CqnxRs6p5+z30ns4BtxeE6gBO1BeQgEan8jgxDqMdZlI7kzGDGgwpmHT0d+VyW0JXAP1HlUEfFep0wKBG7JGoQA4fphlaqEyR68+JLVOWSztOek1rWExsw+V0fFbMRbP/m1JnrflEAWlVNrVdZUiUAvSm2rG0pJsEU/7ntxxW6VZlPdQxPmDOrmx32CfuKoGeSI61f4INUNhwsdvVvS1DJud76farS/LwLLHiA== X-MS-TrafficTypeDiagnostic: CO2PR07MB2519: X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 31:k10JJT8Fwb4meBNuUiXzwlx/CClmcnGyI6jwH9rF4C+1Hrt6byPFxd/YnYsRRmaH+c3RuULh5Elm29qnBOqjF4xRaepPYmgXCK9QUitaeV5FDW+PURf/ISVguS7PnFiGMmMsOb2QAu8UgoSnv87fw2kEQvjOknPJi7cSwJ15RWY+PN1afCwMvNUOuT0Zrza0CF70YM5gqzyYFZXyibdVY/SGqkQc8lkGSssMa2Sy1Aw=; 20:9scFQWP9or4fQXq1zZncLRgundQIwWiKPkPK1ktUswOmNEV/pRdL/DLur8hYtT5LDymU4A4Nw31NmogVGX20YchAbGVplf9LhxqMmdbYWZvMnq6pfvZ2g3nKcpR44TgPzx1M6JyVJvBXzXruKCbm3ybRzn1oq7ryb//McF+/RAN9rZyhSRI4aM2/KMT70LQhb++pmD+/psosvLRx58f2DB0XvK+JCELJzGzJPzVmua1DPg7eEjCU+o5elWW0SMY8zPojPODRoiZ+FyOwSCxT015ogTN06InI0la9KSuxvZ0trl7ndXzEUDPyqKK1VgnaCwaYH+OgExzUN7siN0hD4J4I6J9Wnyr5h0IB15AMB1QxJj9YkLpkTtGxfqfVi7TiF+Kab+SKB1x5fG3HchlVMrgDktfKdD6VJkoce9kOliP4gtcP1saqq8axK8Xkp80+HsFxPTyVfTcrGxMtD/qCS7pA9hVFchJeQBvahevIjry/dYtUSeXiXqIdDAMUr68c X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3231022)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123558100)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(6072148)(201708071742011); SRVR:CO2PR07MB2519; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CO2PR07MB2519; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 4:zr617lpHWY+aEEcQuYteZvj3bV/QNL6fwsRsjkiA0Zcpb+cQ80ZcS8PsBRNSO4S8LTXNfEWxgB+gLie97RU5shKbdVIa4JIQNV2EVL7GmDRh19bqewmYPq7awx+uW032xjHBINM8pHpnkN/iXeoZnBh2hEH6JrCPqYrUo6UHoqME/fafHJE2jzqwzF+BqliQsDeQG4uSgeNHXsFx1TdZvnme+aRX1a2BqI3HtexctGKxGyVeso1V5DbXkJZjXX4qdvWpO7cSWD4KdARNK4meuw46U9wfi3tbLZpw9++/W3yLseKyIpp02g9YuuNOVL2e X-Forefront-PRVS: 05079D8470 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR07MB2519; 23:lVj7A6Z9Eq08J0wawkrk4lRBTNKuhTEeSvSNXMm/l?= =?us-ascii?Q?ZaOJbFqPUnImEB5iqHNXTsKQMjgGGoNCpwo/xTLdCBvcm2qBQpOzBbkAzLcE?= =?us-ascii?Q?0EI4DWs6oKYOp5xwNlr8ThSnykXnEl+Bgb9KgYtpT/HwUEHPky2HaTKFPTVk?= =?us-ascii?Q?s7abNf1wMurn+7zGifiMUBmNARcdOZtT89u6Ca8cRIP05caOrda1/9MHK+uc?= =?us-ascii?Q?QGxZRw/BTyJuARpbST4HqUgFpGuKYSMvkAFXA66fV+RqPhrHmID/p/au37qZ?= =?us-ascii?Q?B5w2LtZ5s0qYJjK5VLCJ6sgscwLtcEsKS1jmbl0X6k4DtnvR2D2Q0B1V5vQ1?= =?us-ascii?Q?6cSRN5w8mCuy1XprCGEX7jipeh0L/tqXcT7p7gcQdriWM0eVPap17Ou4I1rf?= =?us-ascii?Q?eYeXSE5nH8F2rFCqytRAsC1L3LA3TNKL3ZlrAPcviYBIipVmsfcMdzSI7L+w?= =?us-ascii?Q?O7RfAL8SuWakOSIBEmdmtnWsIMEXt7ymb2m6CZYbcz6b0iFtG+ZYcotefYiZ?= =?us-ascii?Q?ua3iE6amXJDOGVEdmph4d5G+sdsrtGpgwKheY/1gjJLVkF8x+JqrFShgFra1?= =?us-ascii?Q?YqaWgUBaNT4HFB3YqFfsqM6twncOG2CGYYJ9bFPGH9LlOvyM8tD6PDeKR8SK?= =?us-ascii?Q?dU62IlNnOrj0AdejX40QhlfYWXExybiNCmyTC/7aLksqA3lL5pPgjWT+2dWo?= =?us-ascii?Q?tdvlhoRYBxBZOVZuTmQoFdWA6ujXDoXx2G+1/vX+YIbWEj3zTGSgThWq5Yhs?= =?us-ascii?Q?LXFBif4n9PHbJ0IgxnpYTxmzxtiMgpFcPnW2myhtshMicZi9AsNS+RWysR5a?= =?us-ascii?Q?SQIZul4xAC0QrmN2YafOjGAd3fGlrxSiz94fuGcauITqy13FKr2wkQXHDPaQ?= =?us-ascii?Q?6lxbsgrOryFvDHOozEgC5HPi+ReKFUebg47XFAqUlJJ0MkIHVh8RbnEeVSu+?= =?us-ascii?Q?v8I72UTVPxtjNl6+1bb9fjn1q6Y5ADCHf7KBxW+ig0TnZCORenvTS80+E+Jv?= =?us-ascii?Q?KteEch3sx3raKs2O1SZdUcdOeUpwZ+kXdIfhDM6oQ0mylbV1ofS4XuWq5ZE/?= =?us-ascii?Q?TKt2Po=3D?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 6:vhqIVAKJYi9XUK5ZuDTZ0X52oQhpzDd7rxDUmlxeBm5ZKeyBj8GJakScA6ySg+/qMZYj3GJSUtPPWWmT2+Pd5DL4WzkkN5HvW/jv6BQFKSrTQ5eCRGJipi72xkWXe9aiaSdixVpqp6g/CdWTvepo0DiHTKNPsHJeMRXGFaFq1R/ecdMd5yrbT0UfluxljHmcPoZ1d2xxMKSMlrBcVmIiU49J7X3DYMh+bxutNgr6mn0snlxy2i3xLk9+rrxHA2VsfOTzNB552Kpr5MAxUAEAWzv90MZySnTJUXoRMGvjvsdyRGm34iXTuCDcd88VBu6vvkwsa+U7g7gEUdLl7jMJkfcs4Ef2QbHYhjSZCjtb8js=; 5:wwvNSkkUSce8kUp66sWGg/8eYCKQlHms6O/eYNc6jePlFJbqvke3TpzbHYvVPrjF9RU5QUtZfYt8Kd94oOrq7EgG/kk+9ULALXrHhT3MRqdUMDIi0A91znK4LXWbP3A28J8kELHOuRveTjozut0H3Uv4feGglkukSfdUCD7tbio=; 24:tE+pslCKtJEros2U/AIMK7mrtLChNxTRpaZvMEpmB1SUVjmDFKdHzuIHRRU1H9SLHoHRLvbTBgpNpK/WeUQ/ivd6o/vc7/FV43gwUuYXmOo=; 7:STnUoIJYBUSQZEa45OmHB1d7liO7Q2XSURYXCB3z3wSyWhLpvbIbvJYXhOuDM83Kh9jnWFN0nefF/s6OhzuTM6HAf3/aKUiOLiP+8sVVMi7qaXQahdpsns0v+bjTSNfGIlkfcBGoL5syLHCiqgdiTEgowtswl/LhlMhm/WotLD90hHKArcQb7IfGc551zI+qTVOTsIigVNKiJaG0rBlPfZc+ilkFbBtXoGlloOTV+O5FRvCj0IrGGdQNFrJvUA+9 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2017 03:41:18.4397 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: be0607f6-790c-4b62-f9f9-08d537a4377b X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2519 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Giridhar Malavali This fix the spinlock recursion issue seen while unloading the driver. 14 [ffff9f2e21e03db8] native_queued_spin_lock_slowpath at ffffffffad0d8802 15 [ffff9f2e21e03dc0] do_raw_spin_lock at ffffffffad0d99e4 16 [ffff9f2e21e03dd8] _raw_spin_lock_irqsave at ffffffffad652471 17 [ffff9f2e21e03e00] qla2x00_els_dcmd_iocb_timeout at ffffffffc070cd63 18 [ffff9f2e21e03e40] qla2x00_sp_timeout at ffffffffc06f06d3 [qla2xxx] 19 [ffff9f2e21e03e68] call_timer_fn at ffffffffad0f97d8 20 [ffff9f2e21e03ed8] run_timer_softirq at ffffffffad0faf47 21 [ffff9f2e21e03f68] __softirqentry_text_start at ffffffffad655f32 Fixes: 6eb54715b54bb ("qla2xxx: Added interface to send explicit LOGO.") Cc: # 4.10+ Signed-off-by: Giridhar Malavali Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke --- drivers/scsi/qla2xxx/qla_iocb.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 106f4ac4f733..8ea59586f4f1 100644 --- a/drivers/scsi/qla2xxx/qla_iocb.c +++ b/drivers/scsi/qla2xxx/qla_iocb.c @@ -2392,7 +2392,6 @@ qla2x00_els_dcmd_iocb_timeout(void *data) srb_t *sp = data; fc_port_t *fcport = sp->fcport; struct scsi_qla_host *vha = sp->vha; - struct qla_hw_data *ha = vha->hw; struct srb_iocb *lio = &sp->u.iocb_cmd; ql_dbg(ql_dbg_io, vha, 0x3069, @@ -2400,15 +2399,6 @@ qla2x00_els_dcmd_iocb_timeout(void *data) sp->name, sp->handle, fcport->d_id.b.domain, fcport->d_id.b.area, fcport->d_id.b.al_pa); - /* Abort the exchange */ - if (ha->isp_ops->abort_command(sp)) { - ql_dbg(ql_dbg_io, vha, 0x3070, - "mbx abort_command failed.\n"); - } else { - ql_dbg(ql_dbg_io, vha, 0x3071, - "mbx abort_command success.\n"); - } - complete(&lio->u.els_logo.comp); }