From patchwork Wed Dec 20 06:56:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10125079 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C0E5B6019C for ; Wed, 20 Dec 2017 06:57:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B82DD2964E for ; Wed, 20 Dec 2017 06:57:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AB92229652; Wed, 20 Dec 2017 06:57:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 520392964E for ; Wed, 20 Dec 2017 06:57:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932511AbdLTG5b (ORCPT ); Wed, 20 Dec 2017 01:57:31 -0500 Received: from mail-co1nam03on0048.outbound.protection.outlook.com ([104.47.40.48]:27088 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932388AbdLTG5P (ORCPT ); Wed, 20 Dec 2017 01:57:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=N3QE5h2daUz+jCBl+zg0WCVJ3k7KhAM77H/hNYPjbWo=; b=EXs8sOI0nWehvhd/DZm971gvXjvsQe+QfJM9W4XceZPxeGuh0qkucKNMpPVhb0TKJRtTWgKSq1a2ln0KOCUsdvI0Y2/bBA7Dex12NGLSdqXOvOlKoGfkvIfEXqqCj6FVpDdPJVB+jhdwbbr5bxSZdPxC2vCo0GJ4iVGcRKxyYB0= Received: from SN4PR0701CA0020.namprd07.prod.outlook.com (2603:10b6:803:28::30) by DM5PR0701MB3815.namprd07.prod.outlook.com (2603:10b6:4:7f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.323.15; Wed, 20 Dec 2017 06:57:13 +0000 Received: from BN1AFFO11FD027.protection.gbl (2a01:111:f400:7c10::106) by SN4PR0701CA0020.outlook.office365.com (2603:10b6:803:28::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.323.15 via Frontend Transport; Wed, 20 Dec 2017 06:57:13 +0000 Authentication-Results: spf=permerror (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: PermError (protection.outlook.com: domain of cavium.com used an invalid SPF mechanism) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1AFFO11FD027.mail.protection.outlook.com (10.58.52.87) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.302.6 via Frontend Transport; Wed, 20 Dec 2017 06:57:00 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Tue, 19 Dec 2017 22:56:49 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id vBK6unjB021630; Tue, 19 Dec 2017 22:56:49 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id vBK6unc4021629; Tue, 19 Dec 2017 22:56:49 -0800 From: Himanshu Madhani To: , CC: , Subject: [PATCH 21/43] qla2xxx: Remove calling cancel_work_sync() Date: Tue, 19 Dec 2017 22:56:22 -0800 Message-ID: <20171220065644.21511-22-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20171220065644.21511-1-himanshu.madhani@cavium.com> References: <20171220065644.21511-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(396003)(376002)(39380400002)(39860400002)(346002)(2980300002)(448002)(189003)(199004)(2950100002)(16586007)(8676002)(6666003)(81166006)(5660300001)(50466002)(8936002)(50226002)(48376002)(86362001)(356003)(42186006)(72206003)(316002)(54906003)(110136005)(69596002)(81156014)(87636003)(80596001)(305945005)(85326001)(478600001)(106466001)(1076002)(59450400001)(47776003)(76176011)(36756003)(51416003)(2906002)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR0701MB3815; H:CAEXCH02.caveonetworks.com; FPR:; SPF:PermError; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD027; 1:xcelCEz63O1ue3m0f+p7fC/rehnkqH+CkAIouMS8G8ewt5LuXMJ/JUbAhJh8qU7V3m1WpS8NToAQQzzz38zZysNzUk3ow6L83zqnwa2tV3EpAiAd4XLno7hLSKBLkd2/ X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c0063c52-de5d-4b93-354f-08d54776de76 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060); SRVR:DM5PR0701MB3815; X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3815; 3:W0wjvHddT1bTFOO4IAuj9TW7wW94nyJ86CobgN2tvCUua2gaVnxgJvf/TS3dCRQTFVEoVLUhHqXm9J1tOiAuEqK+LV66ECB56UldtcT9EihtKKfbC4MxxArPR2/J+uEu4A9nGLlpHBHt7TVIupB6JyNV3/nOkN0S4JKd+uh5fwg3SJ3T876aY7Dif8qpdaI6SRrhUn4pQde+T5ajzURpoN71R+jtFJfkGEbA5zItBQiUFeUEsUOV2U7vIzrdLFxWqccMW0jdQERIhZ1oHiMNwyorrR7yW/CaWiBoP2O10tOsJYssGDSTAe0mKYhB1Zg2uuEDF0006RZd9kmwjpU+In1qwRJYemk8QhJG23Guw50=; 25:GmI28+JM0s8YTP7EMPXdgjEub0ozxAjjdwV4K58kAkW3YJ0+8nSGkObi46SiiYeCaGfikle6uakBNVIA7tmK09qasRLzN0D52whuUYaaAz1Tx4QlOClz3194cRkLxIZJt0wR3ZRGzdgTt6PNFVy+WZt4FrtjoYvWRmxHHi7RqH3dfFTfgiA0YzL/0cOi6TUnAakgyuLFpA4Ik1/BVQrtYI7zPi4Ey3it7/HLh6fTy7nUaHsAC+V3CyfIYNcDDimOF7IlUquwbB6M3cyKVhimOcKzoGuNNQyNNLOG2jhRpzbRwGpNEcQVO8AH2AlnnS6+oUSweTcNGSw8tGpv7VzJFA== X-MS-TrafficTypeDiagnostic: DM5PR0701MB3815: X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3815; 31:SntBBoQkC4xGeXMH6mkHotAmEbyel2IoFICDWN8bbn5/XjpJlVAw6voRJLJ9xVF05xiZKUVPcLkBYKYf6xK++2P0ppvl4AMBYUAKh+Wh62jKHs685cQNMAXw46rNZyes04i708WYzgmnZSuvHlnp+u4UYmgDX6kPglco3Y/VdnJpv+ZcOd96GXg6k5N6BmMAXbz/hJV4lfBD7mpwCGCVphc4dGdrleyKzgVO6yA11xg=; 20:T1jp2vKpLMvvZGlyfeykwTts++2CGd7Wp94gONofWX0sTsTvFBJvYMumORyqJfaakoj3Nf/sn+TRvciPjQlJn9yEGYy1zJxjxaL1WQL2sQPSX67kpDWwoG06HZam7KO+h7N5ulNBay45L1MXTqFw/1uTd0zqfbS9qZRsq95LaUjeDoov8iguaYXVhGq9qmbvpG10Y6kXoApvoJgeFoR8RKatnA133uC35gjMZciwteDFsQPGF5i1AUDouH8nBN615mfudHPCEQ/AP0kHEapmORDLBWgIrZ1FLyTvUIVyb2RfZr/Pe6seVDhx9SDf2LxHMqtHychBTX5+JO8ysVD7daLpcbrPeqKyk+qxuV9/TZIgn0Y0iO34LszxHroPBjwaoOuMSSN1FnNefVV73PI0y80XvLOQrV+m910pzrJCch2y7m/cN3UiHGu5mnVCL6ZyV0qhtC7DiUnM1aYkc85atSMYXpcNniAGhNzaYKzg5QedtEoVvgf1rkQSnFw0vvEY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231023)(3002001)(6041268)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DM5PR0701MB3815; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DM5PR0701MB3815; X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3815; 4:iIjWBMx2pSJQFG03R/tsO0AKVldCSePaNlLhVAQPloevbiAE9njDEB4EU/C2qTU0BP2EoXVy7wwd8I8P72Jvr0+uem2aUqUGvAvQjHbuBuW4BPQszFVlEp5H8gPot6pL74ch71YaMiBuMXiXPY+nqHuKZeh7zyxF6mIa0WyG/ESXLfmU6zoBGRKlfJas3IRTD27rKQgKB8ee75cBh05evady2omHCHqDsjS95k6Lr+1PYWnn6UJdgqtKFJS1la6M8EswHRoUYXZZl4kivtyS0w== X-Forefront-PRVS: 0527DFA348 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR0701MB3815; 23:4EgrlnUF2rAGE3AtyMfpxu3FcmyhnJiw2Rfb9oX?= =?us-ascii?Q?chX5h6UiyNLd/TV3eAIlWl2lVQrDZPGCSgN8KEJ9OgyDioq7KzmP3EcEhq3I?= =?us-ascii?Q?hUsWMxeEYOPzDTuLEy+0PfJesFAEXQpUJb5xSdMNO0v95a4OXP72yt5Cidfn?= =?us-ascii?Q?KZCthdBpI7BOrL5RdrvM6i94ooiM5zUXZHcqgDmpLamT5/jDe+plxPnWWBos?= =?us-ascii?Q?csyqE0qlVOS4jy5dL8wacAEdRGoKAjcYK3KsxA2gFJs9ChFesqezLvE15YFx?= =?us-ascii?Q?Evc2+b7nZkvaWJtah0Oj8Y8eBdYZU7jDcbshHXIlc+psOthv4cVB2g7SqRMb?= =?us-ascii?Q?2JMBkcQdi9tAGrLAfhooGvid/WiHiqVLkOu8Gh9KJG6PFAJX4HfyLiLvxwa4?= =?us-ascii?Q?A8l0EZ4QUnHiCPFpU75QaL6JB+klVYMJkpuOzVM5u9HomQMn33TZ54a4P+jb?= =?us-ascii?Q?5fRfusExTLYi/bE2sd0uJ5uzemRb57XdPAT/3nXKevmcLkz0OdpyaanfcZ/E?= =?us-ascii?Q?vnAW5PpeD8nlQE1QTQ+GXyu+xH+YlpZeiqglRKesTkL53cRVVkbfhnSXT+o0?= =?us-ascii?Q?hrMRDbOP4IBNYcn4wMveg9vkqAoVIz04BSuMrOtjtWxVbN6fIdG1KEzFUU1Y?= =?us-ascii?Q?GLYr2ZnHQ5g6fFen6EdFyF7JopMR4aZZ0NVK19+7RubFrZIMi4oO/G/qNwFt?= =?us-ascii?Q?i/qywHKpuUw9fXBmvAINDe7uIgwnBSsgZ2MmFh4EhUENnv5WkVYJpB3WHX8a?= =?us-ascii?Q?yKCq25ElhL4yDbPqkS9Oyxlk8KGjxmSMFEqB+DIU8Xys9qQxKoJAxLEkp4Ts?= =?us-ascii?Q?ZOZGODnWyieQk4wVsjIMnXBI4oyngiieYBOUJpQPud6rjb4srKNdAKO2hfNx?= =?us-ascii?Q?I4LWW/aPGLKy+xeX8u9fZBRdwmlAClJLBYBw3CLk3IvHLtPm52ycLeifGxCi?= =?us-ascii?Q?0uanhAZclGK6NJJD7Lk9GlwyATaSae3u6WqQQxkQ+Eh4P+dswKb7KR0YEzRu?= =?us-ascii?Q?wLIYCfwJW3bAXy83wWIsdcvLC?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3815; 6:ViWUcxaZAbIw7gOFy1kPRH06uFoqp/Zg+lbMIX2l9Fsqtk8meBlT+wp8Svwp6dscDPZTX3ciXP/vMyWtvsxSGF7hUTENKypiup9yPEtBCQdWSWYFQh3oAwt5/RQ0Poma7oqDv7hXszXwrQ885245qOWnL/coKeaYggIi+EyDXEXWkZag6rlUpohZPLx/u+WFL+QiXsadKRSvmybxtH85QWs7uvrtHW5qE2HVFV9rrVnzx2uSiqRfsqx6VE1Or0fNf/gZDIDHnMeUFqKKRmD6RZXfdbvw7T6v0JJ1QM7SthaL+80N9Buzxq/uaAtWf0PD8Pp0nw7CcT+KkCw0/ud/gNjrtP8mIasicv5v15Hw3XE=; 5:U/R1iCIg/jd7+jJKu8zS/nCCoQh+nzvMDohAs3pe+cc4QT1i0Yyd0tyHlOrh0w/Ai0/nOmRjZW3r8R/azF5VbfWIWT/vZaMqhkrngy5rhWyr48tERPyTsI1VAbU/tGs29MUykamejsqBl2TjqCvd640Rl09IZEChIkr5w585AK4=; 24:S/V7V8HZJWCOBt2gm86/MhpMvY8eJ7h1luDJgR7KvXhUe+13zBNX33LDTEpWnZOtcs6R7GkiijrloNeLDBx0KncE+dPbwiLdBYrfUYaSwkE=; 7:vC7BoXFriQWVy8iHe89km8xXznOqt4cdF/+sNSZGkkzi5AlmVb4tCUx7r2o8GTVEDGTmrWAn7Jrlwfr8BobZoEZyEDwzvTUC/Cp5FWkBvcnbCj3IVjijXzK8maefFYLu+aLbdJWs34B3CmzlUtSDrbrzbiRpgqMKAMqCVRmmeQKlEA/qQ9wmD+FBmrSPCOzvXV0FtbFOKkgmMhXZQcZ/aW/7JFJ5Df8lgko1AfrHmZ8TxAyVwTqjrGqkeKS5I4Hq SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2017 06:57:00.3363 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c0063c52-de5d-4b93-354f-08d54776de76 X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0701MB3815 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sawan Chandak This is blocking call and issue is seen, when called in interrupt context. __cancel_work_timer+0x140/0x210 ? ql_dbg+0xcb/0x110 [qla2xxx] cancel_work_sync+0x10/0x20 qlt_schedule_sess_for_deletion+0x89/0x170 [qla2xxx] qla24xx_handle_gpnid_event+0x146/0x4a0 [qla2xxx] qla2x00_fcport_event_handler+0x14b/0x290 [qla2xxx] qla2x00_async_gpnid_sp_done+0x118/0x240 [qla2xxx] qla24xx_els_ct_entry.isra.15+0x1df/0x2b0 [qla2xxx] ? qla24xx_msix_rsp_q+0x39/0xf0 [qla2xxx] qla24xx_process_response_queue+0xae/0x270 [qla2xxx] qla24xx_msix_rsp_q+0x8a/0xf0 [qla2xxx] __handle_irq_event_percpu+0x3c/0x350 handle_irq_event_percpu+0x32/0x80 handle_irq_event+0x39/0x60 handle_edge_irq+0x8c/0x140 handle_irq+0xab/0x130 ? _local_bh_enable+0x21/0x50 do_IRQ+0x5e/0x120 common_interrupt+0x9d/0x9d RIP: 0010:cpuidle_enter_state+0xe9/0x320 Signed-off-by: Sawan Chandak Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 71be1a95ba86..002fe05dd344 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -1234,8 +1234,6 @@ void qlt_schedule_sess_for_deletion(struct fc_port *sess, ql_dbg(ql_dbg_tgt, sess->vha, 0xe001, "Scheduling sess %p for deletion\n", sess); - /* use cancel to push work element through before re-queue */ - cancel_work_sync(&sess->del_work); INIT_WORK(&sess->del_work, qla24xx_delete_sess_fn); queue_work(sess->vha->hw->wq, &sess->del_work); }