From patchwork Thu Dec 21 17:33:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raghava Aditya Renukunta X-Patchwork-Id: 10128095 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3AE1B60390 for ; Thu, 21 Dec 2017 17:34:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2890929CE3 for ; Thu, 21 Dec 2017 17:34:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1D83829D1B; Thu, 21 Dec 2017 17:34:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AE0F629CE3 for ; Thu, 21 Dec 2017 17:34:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754147AbdLUReq (ORCPT ); Thu, 21 Dec 2017 12:34:46 -0500 Received: from mail-by2nam03on0042.outbound.protection.outlook.com ([104.47.42.42]:27728 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753819AbdLURef (ORCPT ); Thu, 21 Dec 2017 12:34:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mscc365.onmicrosoft.com; s=selector1-microsemi-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xN9oyn2fAwZMr8CfaC3jrI8OM3T+XA1HYitoWrIwZEU=; b=PzU8mHv9lkXj03qNkbyyfERjBvk/W4d4NkUY4rmdrJ+yYUwQTMdOxRvXRDdM+WrcEly+K4ivTdnH8GgRehy4KCW0A2YdKrMdUfa9OHVxbVJEX22jAQnX3cdzarsboAiEw/cXKQ6dgzsSark1Wz08O5pFqBwsu1bE77KFfSa8meA= Received: from MWHPR02CA0045.namprd02.prod.outlook.com (10.164.133.34) by BY2PR02MB139.namprd02.prod.outlook.com (10.242.45.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.345.14; Thu, 21 Dec 2017 17:34:33 +0000 Received: from BN1BFFO11FD036.protection.gbl (2a01:111:f400:7c10::1:195) by MWHPR02CA0045.outlook.office365.com (2603:10b6:301:60::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.323.15 via Frontend Transport; Thu, 21 Dec 2017 17:34:32 +0000 Authentication-Results: spf=pass (sender IP is 208.19.100.21) smtp.mailfrom=microsemi.com; linux.vnet.ibm.com; dkim=none (message not signed) header.d=none; linux.vnet.ibm.com; dmarc=bestguesspass action=none header.from=microsemi.com; Received-SPF: Pass (protection.outlook.com: domain of microsemi.com designates 208.19.100.21 as permitted sender) receiver=protection.outlook.com; client-ip=208.19.100.21; helo=avsrvexchhts1.microsemi.net; Received: from avsrvexchhts1.microsemi.net (208.19.100.21) by BN1BFFO11FD036.mail.protection.outlook.com (10.58.144.99) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.302.6 via Frontend Transport; Thu, 21 Dec 2017 17:34:17 +0000 Received: from localhost (10.181.72.13) by avsrvexchhts1.microsemi.net (10.100.34.105) with Microsoft SMTP Server (TLS) id 14.3.361.1; Thu, 21 Dec 2017 09:34:21 -0800 From: Raghava Aditya Renukunta To: , , CC: , , , "Guilherme G . Piccoli" Subject: [PATCH 03/29] scsi: aacraid: Fix hang in kdump Date: Thu, 21 Dec 2017 09:33:54 -0800 Message-ID: <20171221173420.8213-4-RaghavaAditya.Renukunta@microsemi.com> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20171221173420.8213-1-RaghavaAditya.Renukunta@microsemi.com> References: <20171221173420.8213-1-RaghavaAditya.Renukunta@microsemi.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:208.19.100.21; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(346002)(39380400002)(39860400002)(396003)(376002)(2980300002)(438002)(199004)(189003)(106002)(4326008)(2950100002)(54906003)(6666003)(110136005)(5660300001)(106466001)(316002)(16586007)(305945005)(356003)(478600001)(36756003)(2906002)(81156014)(81166006)(104016004)(2201001)(8936002)(68736007)(77096006)(1076002)(69596002)(47776003)(48376002)(50466002)(86362001)(72206003)(8676002)(53936002)(51416003)(97736004)(50226002)(76506005)(57986006)(76176011)(59450400001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR02MB139; H:avsrvexchhts1.microsemi.net; FPR:; SPF:Pass; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD036; 1:bprx1AKPk1E/xl1TMiu6aIEAuK8XYTkS0ooKIcQLcLxYcWvXLCK/Wrg+zKPM/Er5nbXvisAN+zgzctArtJ8wFSZnBIIOrSUdQZVjDkM8UP4RSk89m8LhGl5GobA0lKb0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7603351b-a839-4f9a-9dd0-08d548990fe0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(4608076)(2017052603307)(7153060); SRVR:BY2PR02MB139; X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB139; 3:8+uM952h+759WVLXrx3mzmo1U+4ccMMzkDaMPMUqvDX33Tzpq/GA7dJBGrBgyJR3n0d6kr9owdiiJyqOq20WlK8nPtrps0nbRzU7oGaIPbxC8r+c6xG+7tLv1q1osDnc8vIOS+HPyEvL+DiRDz9VMz5x/tkDY8D+9P0r4lpKAV76cAMuOMHapTVhJ4kUD28pF7O3TSDlwr7jDeeYwHo8dwPoFpZODXPjWtfpMD7qMDGVSiKt+L1SnqvE9N8n8/53YGF2zJiqq4kK03grpEN713EyRAKygcgrYFcpO8ahqVp4Vgrup6BZjf0mDHms70eh/eP/6KRJnlH1fjUqMrbAnQfXItwyyY1PrQKRt3MN2cs=; 25:Vleg5b6+1mX0xCTxy4gvhxixOQpQhARRgT+0Rz5FQPtrd6QyvaB3atxCXJbis5HLQ5CrDgVSCxqweELAhMnp/wa/hhI7gAqyD4nb0pnQbrUNLIK/2Yp0EAchMMG7sbSuCDCPt++o0ML7tvghEWSyoN0zdwABxqNENJvdv7xBqxg0J/SASk8iI72M3TIh0woBvUUWa8TmoQe2e8xL1hb2r7tR9R7i0AFuWmPjSJOeOy7laVDGeMRqlpd8b6ouIZ7bbhCmYN6K1CuX9VVhU7Sh5PODTr2AmtXGUmDEKOUwFLOkCzAr817GYDq3jpw6Khn7zMbQA/3jbPq0XNnl8b064UwBMHzz3kMDlTTHG7uY+EE= X-MS-TrafficTypeDiagnostic: BY2PR02MB139: X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB139; 31:rxtFkdsBAdaQcN9pqCl9LtRsuQk5erO+kWDAbfFQL0kmWcWEiaW+siN7j3+1TjyhNFyLa8NiZEpK+21tJCq/9cDyurGTJPLCCxQD7ME48EEp57S64zcdhjhwO4jW8IORnOxrY35A/0E0bL7Cgiy4GN2Q3jrI55lRYfDOWhZ66KN9vWhr81BCystK8ZsopbW9nlOYeZA7/fJROnG6/zJJJ/PnAYbar6ROHj28BhkxP7I=; 20:aaxycgz7GSp5AkHz4w+K8PzwrperG09nn0Lzn8apVL4DJW/1Mt9BFPQj+eJj0JDFRjsH/XDAWk/s9vSRG80Zk3mX0iTN0nZtW+aA8MPDXlDkeJiTp5j5LV3YLq2BLrdnmb5IQ2FtJKm6pzEQKGLMK/DsJm92eeVcnv70IAU2upcfrkAcfrwo/6xkA3OTFEVFAfAYxvXVUNpyrGWyc1sYmzEOsyz2UOQQLt7ic9VnkjKkuj8l5zrBhizXy4shmrlIX5r/+EZB21vawuh1yvTxlWPizTo96sFbA9i3redTXdMSq4SPSQJwYoOBb9eUgs7INOnr0xkacxXvYNxX1UB/MLfJb4wWHN7FZ/Ao8JiuER840aU5eheGwPKQ50ziyhC2mKRZ/b1LV9BJCVQnxRpOt6QtVJ83Y7Dp0kYeBVgqy6crHHdpFsLgGWcsArx4s7GJLT2SYaoY6orf5dizxlDXyLrAQUiniSCdwu7hHl4hIdsiEPEEULcm1IXsIgBmBnkwyCYsrJvWVJXzLs5VYWnFFRrPfQYR8PUCSo4L0Ggz2cT36r3j3eW6K8kMhq1fp0/Az1SefEajUpZMX46kVHyqHvvXzuGkToY53Tn++DzGG2Y= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(72170198267865)(104084551191319); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(10201501046)(3231023)(944501029)(93006095)(93004095)(3002001)(6055026)(6041268)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011); SRVR:BY2PR02MB139; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BY2PR02MB139; X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB139; 4:ODuDy4HOTnsSMSEhGUtKvMdILxFTSME+ciXKdr4n/eZRqW9LxXLKOJFcsVMlSWG75cI9Q7hEZ1BJSIJlgoeChU9J6+fwtb1gnpFdYlSV5krVHGmernbNxTEYq2GKnQ2Sgm1wai4dkfIO7Nb+JpMAcY02riCw0i2wXtax0rh0JRXP9pUIMFA+kh6fvTjbTd6thmV7tLsQkQxZHZnUtIoIUpHv+u0PbDWUEE9/dDTcQjI2iHBcOes7jjD/yzLSl3mUipH4qTx2sYfGquQ4AAlDp/Lyvfmv6ltn6i49rColTyyL3XJVj5RFRRkqBYeOcOIU8d4M88LHfDomz003QsnFSkqMHrQ5CJaqTQI2ErfAfrJL9gAEGRkg12xBIpqhxjGt X-Forefront-PRVS: 0528942FD8 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR02MB139; 23:tUH+8Ar4aEJPmGHcVIThM00pP8cjfph7l4u7B2JnhR?= =?us-ascii?Q?rr99aRJmO6i+63UNmq2LtcCrdN2ihWDYUknpXNzWio43CaZkc4xFpjg5VYhA?= =?us-ascii?Q?O6+SJEduwQslKJoZaWorPNLFWkylzywGnpj29i15ZHCN+ZmxdtbXDxNfgzcD?= =?us-ascii?Q?lQCljwYHbOtQSxJ6HS7aaRA+3WYW4Y4Xog8haNjbrF5Xi0TIY3rusSj8EDne?= =?us-ascii?Q?mL+llZYMWWakERaUrbntgR4pmgFs3tpfthj/A6vJyO0576/gszIlU3Nc9zbc?= =?us-ascii?Q?UjojY5qiGgvwcQ6t3ZJPVgy+Pd1N+F9PWMkL7aBuJCmlN0sdLlx9Y1k7KRnX?= =?us-ascii?Q?d7oF4UcAikeDVGID78phy2YaMiPQR0OALNsNIcAlAL8Y8Q9BQrmwaFEbYBih?= =?us-ascii?Q?WO4yDrUXdLQn6bQYAVEqBFqIW1XgaUlqbEXk3jThTcnUqDo0S1N23oxQN5AK?= =?us-ascii?Q?uineLv7ARRb7fNc2MYvVoITzxeCxp8ufnhpqL8pUN3I9ly58jGAKX9MVaDMs?= =?us-ascii?Q?0eF5xJMjBmUu2gBZ0UQSf135NUwfZ03MtDXv14zR/YCC/zCEZC6kD3NYI5XF?= =?us-ascii?Q?bvz1KeF184XcCxbvQL/607CXACs1qwMF5Ne2ZeyEzprHWfx1uWGx5wzeBtkD?= =?us-ascii?Q?ViX2uyOw2xAeOedjmXzry/HiQepnjeu1U/JfJCM3rtduWHBGpS5fFuORJ/nB?= =?us-ascii?Q?OD/zKrS2pt5fKcl3JlHvpEiklWCmHgtmc+LGjzK7QI/DaO/JxzGn7m/DD63G?= =?us-ascii?Q?/RkKzdocUH2Fdk0A7SNkfDhzBCn1CSkgJNuLNIHPX2282US69+pBbZkuIj56?= =?us-ascii?Q?8ThOgPUO8NkI1//x1T7cldz4+u5j4qGx4C+hGx9PbC4Lqnm9SU1JGxTaIBnq?= =?us-ascii?Q?vpDInHfTilabh/eyfNsKlMbMEVTMIAEtoks+NhRPk9P6+jkx/JttHSjQ8rBh?= =?us-ascii?Q?AV2+PtDBZG6QcSJrulI2p3oGJXxLQ1BOZl49nAoenTERz84q6QHvOFG2mwOu?= =?us-ascii?Q?HcBv5KE2KTpAqAzrQd7Lnx5t/p/WFe2Vyfhdb+Ys2euptfLhU060ZYLbHf16?= =?us-ascii?Q?yeBlu0gGdCTWzmaaf7cQO8CCyoHgjMfH4WmHLL5+HBoakqsAts8VcVKu5rsO?= =?us-ascii?Q?4IxXe8oOs=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB139; 6:9KAKUWPnOUD2c0DdFW+J52EA6/FqWIzwibwfPXWKy5BmcpB5daonZiWZRuzmmuUlSfDz+xOdG7ILkXNb8XMTxfLxZl+Ye2XLsKCi02dl63Np1OfjKxjUJ3JjQE9jzl1JH03GVLr82g/JBmoIWKhNkEp6hdGwiQcsGkOvOh9fv0vxoKrAfc4bGU5G+2C7rtahWe0824LA93cS3pAWSyOIXvwFZ89V65theoVhuDm5J8KXqB+lBcphcOA42Vqq/Ne7MDNHjUih6sJ3WcNrHKhsPRTA0qbTXweOH/n/cYdDX1Oi3sXPS4xPem3nAjnZkZjcbJE7qSywvwOWWAuUpp5bB9zAf3GejVEqfKqIFEZKIqc=; 5:ikjhV+DWDibjb58rznymzxSxGhqZnoTmRqgc+N7x4av3qovOIpGYEuihSplFqNHHHS8wJMr7r5OPGvF/0vpRzqtxgysJDvL93xNEaE9HvLyjfZ47T5iMUXSaYmPPoLWDnmo3Qu0SwX7IO65DXvpditShEVK30hYXjZjtOIlHHmM=; 24:I7zUNmO4F5X3ETT6p3Ki0hdnHUWNPau/7Ugl0PTN50r8wMZyK1VLuKc3XuQugb5Rkrz3eVEXNsCw9u6u7jgtYRRvUJ8EAx7yt+BPmMSdwD8=; 7:Olfv10x4MgfToCIQfImXgP1qusH1+ruVNrC4cLWuFXdqPTr7JasyqBIrYQl53meSqbyttva+Bvj07sdkiNvpAIkMXQy3x+VEvl9g7EhzoiqVctdVg/ChEC/9XqQ7/iAqV0wF/edkSK+5WRaCMLD6bUPd5cZFxgaeLHBBbDGue3UOqu5iSaK4QTcD7QkFDVKG5GVjmoEcoutwcL83vEr7qeDTchLnvaDzruU2tTT7D9IlDGY+6qHGTY62bmkir7a7 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsemi.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2017 17:34:17.3092 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7603351b-a839-4f9a-9dd0-08d548990fe0 X-MS-Exchange-CrossTenant-Id: f267a5c8-86d8-4cc9-af71-1fd2c67c8fad X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f267a5c8-86d8-4cc9-af71-1fd2c67c8fad; Ip=[208.19.100.21]; Helo=[avsrvexchhts1.microsemi.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB139 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Driver attempts to perform a device scan and device add after coming out of reset. At times when the kdump kernel loads and it tries to perform eh recovery, the device scan hangs since its commands are blocked because of the eh recovery. This should have shown up in normal eh recovery path (Should have been obvious) Remove the code that performs scanning.I can live without the rescanning support in the stable kernels but a hanging kdump/eh recovery needs to be fixed. Fixes: a2d0321dd532901e (scsi: aacraid: Reload offlined drives after controller reset) Cc: Reported-by: Guilherme G. Piccoli Tested-by: Guilherme G. Piccoli Fixes: a2d0321dd532901e (scsi: aacraid: Reload offlined drives after controller reset) Signed-off-by: Raghava Aditya Renukunta Reported-by: Douglas Miller --- drivers/scsi/aacraid/commsup.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c index 525a652..ffbfd04 100644 --- a/drivers/scsi/aacraid/commsup.c +++ b/drivers/scsi/aacraid/commsup.c @@ -1672,14 +1672,7 @@ static int _aac_reset_adapter(struct aac_dev *aac, int forced, u8 reset_type) out: aac->in_reset = 0; scsi_unblock_requests(host); - /* - * Issue bus rescan to catch any configuration that might have - * occurred - */ - if (!retval) { - dev_info(&aac->pdev->dev, "Issuing bus rescan\n"); - scsi_scan_host(host); - } + if (jafo) { spin_lock_irq(host->host_lock); }