From patchwork Thu Dec 21 17:33:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raghava Aditya Renukunta X-Patchwork-Id: 10128091 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6E9EE60390 for ; Thu, 21 Dec 2017 17:34:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 59E6729D15 for ; Thu, 21 Dec 2017 17:34:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4D75529D37; Thu, 21 Dec 2017 17:34:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C7E4029D15 for ; Thu, 21 Dec 2017 17:34:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753872AbdLUReg (ORCPT ); Thu, 21 Dec 2017 12:34:36 -0500 Received: from mail-bl2nam02on0048.outbound.protection.outlook.com ([104.47.38.48]:18521 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753761AbdLURee (ORCPT ); Thu, 21 Dec 2017 12:34:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mscc365.onmicrosoft.com; s=selector1-microsemi-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vkCez7l+5FEqQLf7OS5xIkD7/vkTyMSaksGMXySGYVg=; b=NGNIMGXnfx9GE/a8UrTtO6rqvpK+fNq0QzD1CjDdI4Y8Xd4wbh2JOw5A+sReyTVPzVMHh6UftIo+AZ+KLH8qllcj6I4RmXEkHUYp/Qb/3LSoQRK0ah86L2HcbhErkh33xUMnjdMjXEDh289euzr8sSvgZjPTPaUZw+SaJEUrtUM= Received: from MWHPR0201CA0065.namprd02.prod.outlook.com (10.167.160.42) by SN1PR0201MB1839.namprd02.prod.outlook.com (10.162.228.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.345.14; Thu, 21 Dec 2017 17:34:32 +0000 Received: from BN1BFFO11FD012.protection.gbl (2a01:111:f400:7c10::1:173) by MWHPR0201CA0065.outlook.office365.com (2603:10b6:301:73::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.345.14 via Frontend Transport; Thu, 21 Dec 2017 17:34:32 +0000 Authentication-Results: spf=pass (sender IP is 208.19.100.21) smtp.mailfrom=microsemi.com; linux.vnet.ibm.com; dkim=none (message not signed) header.d=none; linux.vnet.ibm.com; dmarc=bestguesspass action=none header.from=microsemi.com; Received-SPF: Pass (protection.outlook.com: domain of microsemi.com designates 208.19.100.21 as permitted sender) receiver=protection.outlook.com; client-ip=208.19.100.21; helo=avsrvexchhts1.microsemi.net; Received: from avsrvexchhts1.microsemi.net (208.19.100.21) by BN1BFFO11FD012.mail.protection.outlook.com (10.58.144.75) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.302.6 via Frontend Transport; Thu, 21 Dec 2017 17:34:17 +0000 Received: from localhost (10.181.72.13) by avsrvexchhts1.microsemi.net (10.100.34.105) with Microsoft SMTP Server (TLS) id 14.3.361.1; Thu, 21 Dec 2017 09:34:21 -0800 From: Raghava Aditya Renukunta To: , , CC: , , , "Guilherme G . Piccoli" Subject: [PATCH 04/29] scsi: aacraid: Do not remove offlined devices Date: Thu, 21 Dec 2017 09:33:55 -0800 Message-ID: <20171221173420.8213-5-RaghavaAditya.Renukunta@microsemi.com> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20171221173420.8213-1-RaghavaAditya.Renukunta@microsemi.com> References: <20171221173420.8213-1-RaghavaAditya.Renukunta@microsemi.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:208.19.100.21; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(346002)(376002)(396003)(39380400002)(39860400002)(2980300002)(438002)(199004)(189003)(305945005)(356003)(104016004)(77096006)(97736004)(4326008)(81156014)(6666003)(48376002)(50466002)(2950100002)(81166006)(8676002)(8936002)(50226002)(5660300001)(68736007)(69596002)(2906002)(106466001)(36756003)(54906003)(86362001)(2201001)(72206003)(478600001)(110136005)(106002)(47776003)(316002)(53936002)(51416003)(76176011)(1076002)(57986006)(76506005)(16586007); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0201MB1839; H:avsrvexchhts1.microsemi.net; FPR:; SPF:Pass; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD012; 1:1ROZEgJXGjs0jQpZMEqpEA6wodbz6sYqDXEnDGSXILkpcM2LlhfWWKGq0XzOIm34ga1kQZ1XQ8JJVaRS/cxBH0ox+ltFxJyPzSTj8n2BcdsujeKwPXv3zbbhfQpAAaK/ X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b362fe9a-0c4b-4c1b-fa19-08d548991007 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(4608076)(2017052603307)(7153060); SRVR:SN1PR0201MB1839; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0201MB1839; 3:BsnUd5dF3+DQvht7LCyXKQz4obHAuuVUo95XzCy8/JpJEC8vLUUsrfjx6Lt4J/90RuhGrP0rfUixgTjtL2iKHTw6ASN0UnARQ2fXke43E9DDZk1NXEJkVr3rTv+1dIPkOn6rTLh/XluryM3nr6EESqxIlOLzzOdJ1/vq2ZlyIfNXYI0IszeYyE4w5BQY1iBkZXiZ1tIL4tEpC5FMaegZw9rlstAO8fbS/hNp0cCIkn9aDjwZxis2GU/GhaCHqJDyOh2px+EL8tqZKpOSoPAcSjUo2RhZZFGPcyjraDSTVfR7POIkWIUI7v9tIzTgtdYkcXb2g/Bzt0c7mAcV5QOfrktZ6ahoH8mal/eScCuny5c=; 25:m8tvRno2d2sJFFXiNd6ssXvb5iBA7N01HVdWGQBmA5Lvh5KqnGhIPprTGqsXA9e/GpULWIfqG4T4rT75lytKtzpFS++XgKl4yfRtlw5RsbunaqWjGxwfLYyQuzndoFrnmJii8ZhDVBV9FxQu0oXrvjDD7+pVSZLF/fyceNy00esG87nn4aCJvkFTvPgtzxvp9yFR0v9g5PJyY1rOqL3oU6yKF2KxGKV+0ZFTtoYkxHGz8RQH4+NdGS2XTF6EaqxoKLaYjDLfX5BiIvTY8UNxVPMygKDQPfb8Q6ZxipO5WpmBbBtHlqBY0j1ZysPFlbBlThZHPFVTOJEB9SBhx2ZPBA== X-MS-TrafficTypeDiagnostic: SN1PR0201MB1839: X-Microsoft-Exchange-Diagnostics: 1; SN1PR0201MB1839; 31:DM2R1yJwOU6jKpX/KGe93RgJnxy8vB0giRWW859nxKevGzZ2xOWRNaD2Z3K45/FCgSmffbQBzWNw6exOkMB6OB2H49+QYOUTuHrXqg0vNvX/FbPt6sXP/jmP/LQN2VXbMJFNB/B3C1P/uU69S7czUdkNP3hQpKqBRSSzTXjB5HPUl8XMxXWAO0CgAm3S4+5sAuJyv0LHoTwh0INLZwtyg6VYf80g69gf4FDZz/jljnM=; 20:EZ64Z4wUl1i9Vei8wniYj0EiUYPHXatcJOkjz/yrb3Ra7NtlI1LnmbaohTebSYFX5KdoW55SciBKOHS8eWOsclToo5WM3cAkBGX4XkF63pqGhmUZzXd/+KEJ23UYTpmox7Bm1RnObS7UMvnlOYuqccxtanJtq2xJTjgVpc3KF6XkczOzuNguD7opsWEiYwsMwyPvt4LKAreiXv2H5WZCc/PYV5O63NnR43YZNgItqXZUCIzXLennyQ0T4es0WjRH6MqNMyXReuVtKDPLREGGPA+kid23YWC12dZ7daSunxm1iG0vPFtbRJzwjeUiWqmHM0nvyP81O+a+oUcQLlNl6MFvJFImL+Eq9ozlHfET2prdvtoZMNdi255jy4goOjSwQzz2qGCBJywqMBSB5W7ekFOMPTYc8qSgxXQ1SnFjG4sx/jHkjwmasarEdD9IU8i8NCBxAt90qQWQC+1qNKXiWDB8+EDSbfhSt7/ug3IkmCA+5MKxE8jj316sltftIaummBdWPrwAri/pmFlfdJ8Itxgk7hYq+ubrJ74bur+JLODXE+aLUH+MZv6PKT2EghYWlM4wMCVA1huwiQTOlLtgA1yL6AwSzKZmd/Ka8Lqkz0o= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(72170198267865); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(10201501046)(3231023)(93006095)(93004095)(3002001)(6055026)(6041268)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:SN1PR0201MB1839; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:SN1PR0201MB1839; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0201MB1839; 4:4PRi4MvpNGdzo/8ZBY6wPgmvgV2R1x5CfK5T8h0MZxOQgFYr/21uHU7nkHb7S7YJjygJr4OUJtyUdTy9FVBjt+mfL5l4kY7Hy7UXSzbJH6z4/J7/bQzpNgrBPcGQd6ehFhT/vYextvAMHnZnPEG7lqKN3YE0EFoIuzRMzhLKdpt8KwZ+qMalz17XMhy8alROgX4LVN5L5dTlEPf9bntVWIOeWUuE0yd5f1x67rCBI/b45G9XikLdi+07HsHKAX8CYbX9tPsF8AlUX/B9onCUZNs76EKP0thtFFCYnLC2ZbRF2hGZdcefSK/zkuWEkPEd X-Forefront-PRVS: 0528942FD8 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR0201MB1839; 23:R52l7psohNeLGpGopELiCqDzGSFstvc5AEy7ey0?= =?us-ascii?Q?1GKSpLj4f0/LjePd88tQVAEy4CvxycQbF1ExMrR1FaDpbMhOkpuO168nHRXu?= =?us-ascii?Q?opWtGLx9usZiUXn9PKgP5qqOexBeceQ+0UfapLEfzKZjjwIQvtHmPCen36iF?= =?us-ascii?Q?2Pb64b9kG76c0wYmsfqqUcnWoJU4vCbdUfH2eorsvFrhyTg6Zhf11bTwU2yT?= =?us-ascii?Q?K48MdtnQaamDbumfVRCBRFXzlJ2Br+65RWw08NZ0lKMWnEooyfzsqqKJf/fv?= =?us-ascii?Q?JMWuv/T0f91SShWVwMUqDaQuNu3wYDKsjkCSMhUExYVXEmiqo40Rn5Tjcwgn?= =?us-ascii?Q?XdKSYYJa5pU8MtTBA1G2zjWi8DSiFO+kaFQwzZ4XZohS72A3V59pmjBbJL9A?= =?us-ascii?Q?IgSJR/mOsVogus5qx5bcfzrZxpKSS1+vJrT0bf406941oNBjkFMZBm0swnrG?= =?us-ascii?Q?GbGjD99Fm5iDd0PmOtUTeV62wX+lJoTvsdu+LgvP06GGcrhvabuCzTDESHHY?= =?us-ascii?Q?vkWpSW1F2dblwoHPRKXfG4vLVB6es/iZyGcPTembrMAXd20nfRqvdY5gdNoZ?= =?us-ascii?Q?BUfH7iww67O6p2iaDnt3WuviWwNuuwPOMdDi3KnMHNBGu7qaZT7Ha3Dv3No/?= =?us-ascii?Q?wSOSC4HlSLUBq34eT86N45y0846ZIFPyPUYASUCRamMOTx4zcK5mtjwwdiMj?= =?us-ascii?Q?tIhcovYwVxLxaSeJF4gbIQWTDBc4ryjkisfQ+FlZgNxA13d4pHgBnqdQ0z5S?= =?us-ascii?Q?hteNtHYb+KPLFkzopgB8NaXxGB1ueBYOkPDa9feZe/L6DU4pEibQUYkFJZMU?= =?us-ascii?Q?rgEnCW4lafF/9aZs9aYM9c4gTSYPPCWUBjFAYA7PM8H6gCrIp801pS6KnYtk?= =?us-ascii?Q?lpeLjRYbTFm/Zh5QClLJKyHUeqUnuownGgaqGP/7CllwlXtVNakyQ2jcbmDH?= =?us-ascii?Q?qlQJVn2tmBoiuxV0Mae7i2gC4utJZheaNeeusGsbvPaNgjrjKJ5sWam+4Yvb?= =?us-ascii?Q?uSfVn7ZgWAj4BXUubk1rAp+epOVrTQ0sgf8iYvC1tq7Qt6m9Fd2yXos0UXCC?= =?us-ascii?Q?ncFtvHR5Q7cgXS9TeFeJslBKJt+Ri?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR0201MB1839; 6:z9sliGIZDg3NYTjtexg3109NBvutf3fZvumbsY1z66lHktivoCeLDgE+h4O6BODLxEeDwOD70HEf0PCwxK2D8yXwHSJLhd7bE7xtWanHZfHwdcao4kH2iclGxy0CDWk4uLPgUZmG8aGVEs1Uxo2a0YUQhNWOwJ8B+ZDkejbomTqSERDeEFygRyX4Rvuu6z7J8ri5qW0yT9XnRSAgdIL/E2XFE2ZE9S3ossdYMD5rYV2CyqFTIIKc48v3MfARvKurLti0O/eWf7fTD72rKQtIIxAI9tbHzIBtDuXhrHAStMPlupti+cplWIjO/3UfiZICQbwBFaMfmt4Ts9RxGcaGHx31AhljD2l1OquZZAxTzlg=; 5:Df6HQ857qa3lUMlXQsB7jMLPnMj02gUVDw3s4AFSbgjUJMsts+0+Vc5eEkINyn6jRgA51eaHzZ1KEC+jIrKydDK2tPF2OaqUWI9wRMV2S5neB0H/LHUJ66DaPpW5PJZ2QzpHzi2JH7ddmwbrwYrsILJpRkFUTprTB/sS3o0DAho=; 24:owb7XiSSl/ztVGZk68Tflplg5fRFeG2MQfMHNNicOTcvECatH9gKaAZ4DmWdLg9UGsufXfIiwzuj4OmGOb/Z/y6+cTjDB7NFjxEbArNLlEc=; 7:5CIjK0iH8rhsU6oIjF2Zg0ppi4f936qneFiXEiBQOm4PpTrGuRY2sxJjR0EpbnPrCS+E+3r6luqfYfb8gu3aYpSWbjRNe7xNJULcYcyZMWFeNYj/XlAEfs9CIIC4xJIo7ONW+Lq+b11EKcm98fq7WavcR7iaTZtV52ShAkwq99/w4gcsLSZ7gINlK56SqYb10tQquNcGbHMLKMdqP3An+tcj7Xk6cNZ0x3gEMWwAtdPv3mlBvPaAN4qgVQ8rGvD/ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsemi.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2017 17:34:17.5671 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b362fe9a-0c4b-4c1b-fa19-08d548991007 X-MS-Exchange-CrossTenant-Id: f267a5c8-86d8-4cc9-af71-1fd2c67c8fad X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f267a5c8-86d8-4cc9-af71-1fd2c67c8fad; Ip=[208.19.100.21]; Helo=[avsrvexchhts1.microsemi.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0201MB1839 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As part of the recovery process, the drivers removes offline devices ( done by the kernel) and then tries to add them back in the rescan code. Removing the device is like taking a sledgehammer to a nail. Set the device as running if it is marked offline. Signed-off-by: Raghava Aditya Renukunta --- drivers/scsi/aacraid/commsup.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c index ffbfd04..32b8bdb 100644 --- a/drivers/scsi/aacraid/commsup.c +++ b/drivers/scsi/aacraid/commsup.c @@ -1658,14 +1658,12 @@ static int _aac_reset_adapter(struct aac_dev *aac, int forced, u8 reset_type) command->scsi_done(command); } /* - * Any Device that was already marked offline needs to be cleaned up + * Any Device that was already marked offline needs to be marked + * running */ __shost_for_each_device(dev, host) { - if (!scsi_device_online(dev)) { - sdev_printk(KERN_INFO, dev, "Removing offline device\n"); - scsi_remove_device(dev); - scsi_device_put(dev); - } + if (!scsi_device_online(dev)) + scsi_device_set_state(dev, SDEV_RUNNING); } retval = 0;