From patchwork Wed Dec 27 04:34:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raghava Aditya Renukunta X-Patchwork-Id: 10133385 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 97698602BD for ; Wed, 27 Dec 2017 04:35:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7E4872DA56 for ; Wed, 27 Dec 2017 04:35:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 71A502DA5E; Wed, 27 Dec 2017 04:35:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F20B22DA56 for ; Wed, 27 Dec 2017 04:35:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751716AbdL0EfF (ORCPT ); Tue, 26 Dec 2017 23:35:05 -0500 Received: from mail-bn3nam01on0045.outbound.protection.outlook.com ([104.47.33.45]:39616 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751591AbdL0EfB (ORCPT ); Tue, 26 Dec 2017 23:35:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mscc365.onmicrosoft.com; s=selector1-microsemi-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jK7+iIBwhmjMK2Sn7Ujuf2chNUlVrtkPMfFFawYLgHs=; b=iGz4MaAlkIXYKkdptHpMmrEgVssqQkXJP03Mnq3okGuF9E+2aUwhvVttWCWox+HbgPHCQamCvtlNdQeXCcaINcieG85TpGoSC+Y1jSFgPbKMH8PjFVy8JkyX5lTOzvr4ON+Jo+jJcwRu8/1Zamy35sI8ftYqOoV2O5g5oxNz814= Received: from CY4PR02CA0002.namprd02.prod.outlook.com (2603:10b6:903:18::12) by CO1PR02MB142.namprd02.prod.outlook.com (2a01:111:e400:101e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.366.8; Wed, 27 Dec 2017 04:34:57 +0000 Received: from BL2FFO11FD049.protection.gbl (2a01:111:f400:7c09::182) by CY4PR02CA0002.outlook.office365.com (2603:10b6:903:18::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.366.8 via Frontend Transport; Wed, 27 Dec 2017 04:34:57 +0000 Authentication-Results: spf=pass (sender IP is 208.19.100.21) smtp.mailfrom=microsemi.com; wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=bestguesspass action=none header.from=microsemi.com; Received-SPF: Pass (protection.outlook.com: domain of microsemi.com designates 208.19.100.21 as permitted sender) receiver=protection.outlook.com; client-ip=208.19.100.21; helo=avsrvexchhts1.microsemi.net; Received: from avsrvexchhts1.microsemi.net (208.19.100.21) by BL2FFO11FD049.mail.protection.outlook.com (10.173.161.211) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.345.12 via Frontend Transport; Wed, 27 Dec 2017 04:34:37 +0000 Received: from localhost (10.181.72.13) by avsrvexchhts1.microsemi.net (10.100.34.105) with Microsoft SMTP Server (TLS) id 14.3.361.1; Tue, 26 Dec 2017 20:34:53 -0800 From: Raghava Aditya Renukunta To: , , CC: , , , "Guilherme G . Piccoli" , Bart Van Assche Subject: [PATCH v2 03/30] scsi: aacraid: Fix hang in kdump Date: Tue, 26 Dec 2017 20:34:24 -0800 Message-ID: <20171227043451.27813-4-RaghavaAditya.Renukunta@microsemi.com> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20171227043451.27813-1-RaghavaAditya.Renukunta@microsemi.com> References: <20171227043451.27813-1-RaghavaAditya.Renukunta@microsemi.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:208.19.100.21; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(346002)(376002)(39380400002)(396003)(2980300002)(438002)(199004)(189003)(104016004)(106466001)(97736004)(59450400001)(48376002)(50466002)(53936002)(36756003)(76176011)(68736007)(1076002)(2906002)(2201001)(86362001)(72206003)(54906003)(5660300001)(2950100002)(8936002)(76506005)(356003)(81166006)(110136005)(51416003)(4326008)(316002)(77096006)(16586007)(106002)(8676002)(305945005)(57986006)(50226002)(6666003)(478600001)(81156014)(47776003)(69596002); DIR:OUT; SFP:1101; SCL:1; SRVR:CO1PR02MB142; H:avsrvexchhts1.microsemi.net; FPR:; SPF:Pass; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD049; 1:dP0YF5TkO0qyLdV+7MHwkbFKYjEbE32Rj/zvpAS2tcm3nM9IIBcHDgfANEdSFScYQa6Jk0sT5tFNv/qrVMdl75ILGGISvFDRzK09QjD5AyaN3FFKUJrd+aBOTpamxq/S X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f7af04e0-9923-472a-56e0-08d54ce323a4 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(4608076)(2017052603307)(7153060); SRVR:CO1PR02MB142; X-Microsoft-Exchange-Diagnostics: 1; CO1PR02MB142; 3:AViKcump+mgWml0JLcv1UxqF9vHS3jkfrw8Y5AGKFKwfKZnQW/zd1fM7MmcMaCGi4vZf+DUZrRR5odvKQ7yR7Vt+mTA1mJLjqWV2WyUtLlqyYtQGcgxW7ky6fH0HygpZP5iwTYHfZmdUT2Rv2/7Nlcl174/dCegzL0wSHnKwZ6pn41AkZ6m1L+pBgf1wc2lREZiNwG/m4ZyC2nZvfTOehtTPCq5E8RYvv6NWqLLFJUWanyjnALyQO9piwAk+cYplZPw1LsXPniVMB35XyQmh3ZkeMqoKUpyzvrkiXPOtlZPZkT4ruZb0UXAjjQbmgiXGzP6AkT/e2XeQG8JZduPCFt/x3rCYUlU/kCBLKvnUIzU=; 25:pbec9B/bhuI4eQ7XDnIen4iHVaxfDoz816i9xvnAq4e1ulfBie6Mr4ldbo4NVswu6qFyRejTQupm7C9Jp4TbndySzR5uB1jVgPxGgB06v1NR8cvP2b2elq+Mjtc5AHGEEXuILxkiwdv4SjjvZdVslgwCU0RooHTNWepTxHUvkxIliFoP5uDDMhzdedcjizzaDM/8RjwWUWaCmuKefkhMsNDdOxioZhAo4rtufvz8Za9pLmInlbz/KJ+mmFiMqLyYo+7Uv/Lzq9wvDxwRRrGGUD5EFE+ZKsM7mezuyWUIsSrJ+iJvYAL9XQfOaGTlXjdWbn/OqCoE7SkhKwS+m+C6vQ== X-MS-TrafficTypeDiagnostic: CO1PR02MB142: X-Microsoft-Exchange-Diagnostics: 1; CO1PR02MB142; 31:np/o5SUiDbjYgdAFPYIAes/bEY2kAiVDsoSM4phDvKzPoiVBMSjrpJpNeitpXOxMd/xl1kzDWsYKF6e1E6NHYOiMASDs94C3bLV1lOt44I/q0Kqep+WIemfnWdSUj1ec4tUihnAXipD6VFjoZYWzVwrKEPP9/8lpLGoq6usgqUsTxY9T6L3e010SddxquPnGuKPObHb+2jxJhjfyw0sgQLkJQcnxi0tVOolEkxg/YuA=; 20:d4Gy2DDN+CF/22eHiSI7h/NazNAtckbtXPmeWsX1LbOoqxssUB0QPr1DA4DgPfQ1KJUrPpNowTCHFE1xVOn4bCY7G2Ax8hydYmeBGfGfPQWD5wloM5eQ4Q5etlSqnRAEEcH2paMC4VSaYFqcrhU5jEM2kw2fidakwSQBhS+RJzggVsIP7CCyhxs7tzmhMCQFvVLRtv01YJfryEgnB/hIhknuvm74bFD0yM5wqtKMwNKO0G1myP1eKo0H90Row/gSpk55i9Y1NNAiXnldUskAGCL/0VqcO0mwc1ZFd+0snjKPORMjgBj+wuV+daxNMdy273iO4odWCVhuny5QnhlScv3HWLdu9bCDRrjr2FPwOzOnHYVINV65juQhEx2GRYmNJAstsoKGEqdi0HLO5Ud6pz2pKnCa03bnh8nRCUCeOBg7golowl9YnqgbY57dzPRb92EPRkhcBUrEyQ3LoOuFGwPTbsjlXCLbma9BnpmemcIJ+/6r3WERqCRqoI1KvOifpqsGcn3yIxxQddBgnP0Tv1K6YVRO5iI4imAWXQ34T46GPGEDupHtdD62FBPBGfz9FPc6SZ2VCBLIu3Kam9qtaP9G1PKAgRpOtnWD4gzHDic= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(72170198267865)(104084551191319); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93004095)(3231023)(944501075)(6055026)(6041268)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(6072148)(201708071742011); SRVR:CO1PR02MB142; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CO1PR02MB142; X-Microsoft-Exchange-Diagnostics: 1; CO1PR02MB142; 4:ZqxogHWLhRAXEvm98k1iCBKlfof2FNGklo9FxLs873Xq5+vJ3/CimUuu+hFgxcaM3mjdIwjQHrauWzoRrIXlczRGgf3jyUZgBPg0tjADQP8UNxewz8WjbWM1nJfAIgAiH8Vb0AA0mq1vqLVKfzDVuo99alIPFs5rjoIZrktrgjj2dQEXI3rOCPRfaLtPmjwHUcq1hRe76wgy5oGn1oXPoWvbbyZydUodEtBHm69j3IHp/fpay3wjizSjnbcGc++Ku7zs3WaQjDpcIwOoRvmp3EWANldbh1iSRd4xAdPH1f0EBHH7Jp8IxmpT4xzo1oNad1RfoYtA9fhCXjO5HRHtHms5GOAXvcpHdhtOzTI0obZEwzBXNzA12XKbKI5yZN81 X-Forefront-PRVS: 0534947130 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO1PR02MB142; 23:XeNHABudjvqvdXpQU7AFL0wf1MyZb6fo0SbLHkD9b3?= =?us-ascii?Q?sMae+/NIImmWnh1Gap8+GdO5mWU+CAAo5rSAbjUMdyMF40zi14M7xKki0B+Z?= =?us-ascii?Q?uCEm4M7fi+jRdAG4iRewl/OrLQ03tzcPyRfsXO7e7EFmGgjm+xGGHMjtvR7j?= =?us-ascii?Q?XjzrsnvcDBo+dwC3YZlJVtR3ky8r5u+2Ya/MgUetVVghRjiogx9e0VRVZzOU?= =?us-ascii?Q?umMVX5e24nqGrORZDDBvD2Zks7VKBP+ywp0DA/qUif6ncOTuTtAIuudCXqU8?= =?us-ascii?Q?Z9GbxJyi1qH0lxjvcS1Z0nXoATHhqbtAmE1g6zDbCrTqG9LCPlmXbETOq98S?= =?us-ascii?Q?OWJ1Rh5LxqOnzvtNFmFHMIWhR0iYHFLdfbHOLwjwMswITLJAIjYNcbEx0eDm?= =?us-ascii?Q?82XkLDDAIEN/TD3Saku/+/feD/ug6714unqcle9L800Si9o7h8L+eaBl65UG?= =?us-ascii?Q?ZrzgAXvosqTB5fIXcRpCLCOCyQJCR2RUhULFw0ZJO0rlE+9/AAoYhAiwXyrh?= =?us-ascii?Q?E33h38ZCsRoqh112vCfUPIzpGvjTvTmg1qSiIpKBxRRFk5JaxuFgvK66MkeT?= =?us-ascii?Q?h94DrHVNpz9OcvVju4oRIZjjrm1YACjI/vjlk7tHqHoM4gl+aQkzrj2jo5Wp?= =?us-ascii?Q?Ncr9KVqqAEMPSZjcYN0pebTkUuEBcUK8+Z0whKzi2AqzWHck4B0skepsGe/V?= =?us-ascii?Q?jy8h+UCIPBuY5KBylq+6AqI5J9L+7Ypph9xQhaMF4TCwEOq9XtemfGSaN6o8?= =?us-ascii?Q?oBOQPZHBe3jq/jOODJYs6ch4efbLFEcMfTKuCH8QLMrXoSyg3U/+vKqTZ4Jd?= =?us-ascii?Q?reAaLMNClPAxej4DRBGIMr7o73XOa+Fe4VwBdGosUUokguiewPK0yduJX6yP?= =?us-ascii?Q?b+RKUWzBxzH2nvVPIl3eqRwwAatex7HizKJqg/8bUk/BqYpBtr2kArVC5jkH?= =?us-ascii?Q?P25RTiiKK3Pq21BYBsMECa00xKL+OH6Ee1XqhBpCgIFvO07neZT6sO7awVpF?= =?us-ascii?Q?8VBk2xuzUX78tHd0daSgQKm+VeH8zthx7othydDTvbeqlHeX6Utm1uojsXVC?= =?us-ascii?Q?qzCQhZLRQcQ7IG3bSTW5uiGmAQqyWE73bRhQaYrSdSzZj2Ouqg0oMWY57Ue5?= =?us-ascii?Q?bTXpgDf7g=3D?= X-Microsoft-Exchange-Diagnostics: 1; CO1PR02MB142; 6:DIjyKqurvYJtlVK878kbVaBytOs4gBRk3wN2oNVwUToQUq1F8pWUvRfqL5IP17JFENAZWgSC9xlE5L2v8PFLDBn5VJ1CrOUwUk1gqJTgV1pgWKPoHx29K5RVkDJMHqIm4Udq7xrFvw8kt5olyhBIicgvZRTzKknPYgvU1VDKkjffdWcxL0BPYrLSxGZKgss46QOzQhuOJieDA4eb9Ab/sPjMbnDQ9osT3sekZJPDvFhqyJguTvg48BwEjmw+Zx5lAGa5D2WodiAGjahTTZ1348PeY+I18GViMYjDTkX8GDnMOAD0U2Bv5aUBz2HYaFhehFO+ZeyL0NV0IJn8kRGQzfRMA27OLt3syfO+UbIkbjs=; 5:jnjIsxW8uyxQctMnYfrGfpm2HP5EzowR0an+0xSDADym88zi6M5oWXx/P8E+EBGksDGiWnJb0IHmUPJbyu4YDQk4joqA5gUN1+YfeWr/+OErA7CEKoOx7gA3VpmC60JCQFCAu4lZznAbNQfC4gLZNLSz1PlQmCyur+Dn8G57xeo=; 24:rl/ANz+XN9aaS55EHKyat0MrAxNQS0bygBt3dC1F7YxHRzP9yntJBn+HRZVrI9lmjLD8zfonslCMaKJCqKdAhseiAf/9si3kBtuoalcsvrY=; 7:YBIkHUjSNhisuT2M4FMMsyo6nVdIREcfMWC5ZyBXv/kazz52eAYJyGfj4L7uYQaOVHYROLQ+rWbtoj1YhHISUXyt4lgEYhqKj7oBaBnztjX6hKesWBbVAlET9Wy3FmsE/aIHaIBwzdPFdUUba6XqeMXYqj4oXmUyKH9WCy4LI5QyXFfFWexUTpNc+vSlsR1gBuLXr2fw93PHwaHNwtAGGoXGUKlUOi8fHr2DvLic54Gn4cI6TO3O99IIJ6HHC6Ls SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsemi.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Dec 2017 04:34:37.8777 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f7af04e0-9923-472a-56e0-08d54ce323a4 X-MS-Exchange-CrossTenant-Id: f267a5c8-86d8-4cc9-af71-1fd2c67c8fad X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f267a5c8-86d8-4cc9-af71-1fd2c67c8fad; Ip=[208.19.100.21]; Helo=[avsrvexchhts1.microsemi.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR02MB142 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Driver attempts to perform a device scan and device add after coming out of reset. At times when the kdump kernel loads and it tries to perform eh recovery, the device scan hangs since its commands are blocked because of the eh recovery. This should have shown up in normal eh recovery path (Should have been obvious) Remove the code that performs scanning.I can live without the rescanning support in the stable kernels but a hanging kdump/eh recovery needs to be fixed. Fixes: a2d0321dd532901e (scsi: aacraid: Reload offlined drives after controller reset) Cc: Reported-by: Douglas Miller Tested-by: Guilherme G. Piccoli Fixes: a2d0321dd532901e (scsi: aacraid: Reload offlined drives after controller reset) Signed-off-by: Raghava Aditya Renukunta --- Changes in V2: Changed reported by from Guilherme G. Piccoli to Douglas Miller drivers/scsi/aacraid/aachba.c | 1 - drivers/scsi/aacraid/commsup.c | 9 +-------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c index 548a3e7..7173ae5 100644 --- a/drivers/scsi/aacraid/aachba.c +++ b/drivers/scsi/aacraid/aachba.c @@ -918,7 +918,6 @@ static void setinqstr(struct aac_dev *dev, void *data, int tindex) char *cname = kmemdup(sup_adap_info->adapter_type_text, sizeof(sup_adap_info->adapter_type_text), GFP_ATOMIC); - if (!cname) return; diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c index 525a652..ffbfd04 100644 --- a/drivers/scsi/aacraid/commsup.c +++ b/drivers/scsi/aacraid/commsup.c @@ -1672,14 +1672,7 @@ static int _aac_reset_adapter(struct aac_dev *aac, int forced, u8 reset_type) out: aac->in_reset = 0; scsi_unblock_requests(host); - /* - * Issue bus rescan to catch any configuration that might have - * occurred - */ - if (!retval) { - dev_info(&aac->pdev->dev, "Issuing bus rescan\n"); - scsi_scan_host(host); - } + if (jafo) { spin_lock_irq(host->host_lock); }