From patchwork Thu Dec 28 20:33:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10135861 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E2D0360631 for ; Thu, 28 Dec 2017 20:34:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CF8C92AD58 for ; Thu, 28 Dec 2017 20:34:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C47AC2B3EB; Thu, 28 Dec 2017 20:34:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 817062B1F6 for ; Thu, 28 Dec 2017 20:34:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755272AbdL1UeL (ORCPT ); Thu, 28 Dec 2017 15:34:11 -0500 Received: from mail-dm3nam03on0056.outbound.protection.outlook.com ([104.47.41.56]:29094 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755090AbdL1UeG (ORCPT ); Thu, 28 Dec 2017 15:34:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kmnh0ok5jVZvRq6+6WWXjQMgf5AVI+Lk+cSyP3iFgnI=; b=PrYIjO6pWfrJ4YafG6yWJZIjqNNAEmVvNabMdbfVlcAOGgdf6nzdOXWHEQlUe/EupNqrk/JXl41g6Mt3E+HVtpfb0SxntTMwcQtiqwNbmAVBVNQLB0DcfjoTdaiZV0tAyJH3lEeNXljQ8W6FDqd19wSAG2wVJz5NtJsU5lL+42o= Received: from BY2PR07CA0085.namprd07.prod.outlook.com (10.166.107.38) by BY2PR0701MB1944.namprd07.prod.outlook.com (10.163.155.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.366.8; Thu, 28 Dec 2017 20:34:04 +0000 Received: from BN1BFFO11FD008.protection.gbl (2a01:111:f400:7c10::1:118) by BY2PR07CA0085.outlook.office365.com (2a01:111:e400:7bff::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.366.8 via Frontend Transport; Thu, 28 Dec 2017 20:34:04 +0000 Authentication-Results: spf=permerror (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: PermError (protection.outlook.com: domain of cavium.com used an invalid SPF mechanism) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1BFFO11FD008.mail.protection.outlook.com (10.58.144.71) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.345.12 via Frontend Transport; Thu, 28 Dec 2017 20:33:43 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Thu, 28 Dec 2017 12:33:49 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id vBSKXmRs002855; Thu, 28 Dec 2017 12:33:48 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id vBSKXmrb002854; Thu, 28 Dec 2017 12:33:48 -0800 From: Himanshu Madhani To: , CC: , Subject: [PATCH v2 13/37] qla2xxx: Don't call dma_free_coherent with IRQ disabled. Date: Thu, 28 Dec 2017 12:33:21 -0800 Message-ID: <20171228203345.2702-14-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20171228203345.2702-1-himanshu.madhani@cavium.com> References: <20171228203345.2702-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(376002)(396003)(39850400004)(346002)(39380400002)(2980300002)(448002)(199004)(189003)(50466002)(86362001)(69596002)(80596001)(106466001)(51416003)(47776003)(48376002)(6666003)(36756003)(356003)(81166006)(305945005)(316002)(8936002)(5660300001)(16586007)(1076002)(42186006)(2950100002)(54906003)(110136005)(87636003)(478600001)(4326008)(72206003)(2906002)(76176011)(50226002)(81156014)(85326001)(8676002)(59450400001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0701MB1944; H:CAEXCH02.caveonetworks.com; FPR:; SPF:PermError; PTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD008; 1:xeU93hguJhQG+IK2zQgYtvjjS78gdJDlZovffAnTQfxJ/AvfbJkR/XW1Ak3RAUncjBRh4lfCHwUtiNBZHqW9vDYPnIRvS9k0Cy7Xa0hpnShSZ1gOKgUPeaEK0ckq/Q+a X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 47325805-9448-4788-b12a-08d54e3249cf X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060); SRVR:BY2PR0701MB1944; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB1944; 3:6KaswETF4y19tVCpDRs+vPRvfAjr9lwvMpuLnZJIztmjfETmD2JuvI8igpC3ltsz6nMNvvjty4eLUsYiQ0F2Jqropa347e4dNOzaZ0LDfaLHgCphURu6F5JIJQJwtnONkxayty+oo24XzwCgG1gIZmcb5VuKRBTwOrlfQtR5udJCUzoQDblbaA7fuOhpiQdhUuVk2HvX2An2J04snzMhwvlqfD9haE5iGkTadXsPa7vw3i4POsZzB0XqeAk3WHswYWuBjzudL0X5p1a6z1I82ImejIxDVLN4ahSYh7SgJYIXin5RQ8wsAXetafx4oiznRiVFOb0SQwFGRlcKpizDzQ==; 25:S9Uu0ogUihmor9AZCFwBX0Agfl6nf+CP9pjJK1wsNdDjSYvvTxW3+StakHGFP9HEYx7Q2wy0s+mhJma9z3BVuSwZGiqaWMtVqerIHWnL+aZ+TV6fmNfcn1PMBO4F4OvUt1sS1BAOvvbH0DtRp999CtZRXbc6tCl1m+BwrZpJU5myDU6eFyAdE3rafvfi47lnbgc3LVBJo84m9yqVApetO1+6MjBmvsoCJYG5GiykGsru37iLQRMKYr45ULFimGsuA2BCSId/CHl+JsoJwiDuGoRKoI+GOGDJCLDA+gOqRbWs4CXDV9r9L7t5u7xn1cxCz3uIG5+IVV0+u09ze2Adxg==; 31:p5kW6upiMJdU4ytDM+YKiJQTFibYkx2USqDAEWWhOfT3R4g5zIgMgLIHZBIEsWSysnOfdlC+gbZ1INz8LjW5lo0S2CU40JllLmiQbAluZxC+s+VzNX5ow/I2ca8HhZZYM0krqZTBlTV1cfgNVvSs/LcrdwwA8aw9HuN0sfxviKb7XWKenSvduPjgdyBcTiebhuNVYh8XMxvYQabYA2dgk9UMIhfWix2+Ee9JV8Q3dKc= X-MS-TrafficTypeDiagnostic: BY2PR0701MB1944: X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB1944; 20:sd1G8O89QOmMybVDWFm9xo1B0O9dOPe9hB+m+pfteF9Ce9+iEhwei81pt38WCete3davUnc5xpAKxcsT2fRT0E3+fvvKddHAUSLWW5aawu27xoVwBuayNDhrP3gqas8Xi994D7+YAupr8WW2PZx5aHeM9qq9Ye0D9sohK3jcyDvZYwgg2+jX68ICCve0Ds0zC0puXf87cKRyoZ5cmvFfxU23MHEF8V6htniHZdg5ZvVm7M4H3hgdGhMIUAJyTDG5ULb//BGKKyuIxHJRUTPs+XvEMoDlqOpnc9NR6P9AZhP14ejZTgJvTxM5itatKcPhqsWIj2vXfRxTjLD2GOyHR5fEWyTnlXCd0Ayh0XSIWU7NWh1FRPOqM/U+V6SH/b/YvhBKDChsjTb+WybFUhDYQGPBfqXfbz0+/KBYk8h+Z2E8L3f1pglMC8yzcR4wprdw7nIBM88pVwQ1uzYRhaNQo1PI6FnBkf+W9bsyjcYS39lEfso6bClUcWDtSjOtcbu9; 4:ZcNXCHSUFdKBQJLEZ/qhAKIXQDQc7/0S5VAGFBYE/uQ2W091xQ3rFZ8l/swnXDFdHU+vi6ReNgoUi/cZx5sKj+vTw8VIaTxMw8yPFfPxYLN17s6i8BqMnfCbkbKok/Lu6oglDymKLtr+EBqZJs0C/XkHQxp4cvcfmS0yWZN+DTPCdJm2iXJlowOsMinWLYLT9cQhxgcziZTOVBlUL6FXXugCMs5L2MOkKJk3GaqA1ZxNpFEFBQUQ0+UyK861AZa8FS/hhPm//88O0eiZ34k7cg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231023)(944501075)(93006095)(93001095)(6041268)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:BY2PR0701MB1944; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BY2PR0701MB1944; X-Forefront-PRVS: 05352A48BE X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR0701MB1944; 23:AIoxWuaE5n33ksu1Qlo16r6EZXjeWSI08cTgKo3?= =?us-ascii?Q?Z+0kiAj4TLui5QcEu5pZ57ou+I5nAqntrZf7KamdcIBplmDcX4zq6uJuubw3?= =?us-ascii?Q?zbgVJFiMqKOQSOaRxrn87tMzZcMauRNikVQCPNYIPCbvN9bbp93tTFWCge2P?= =?us-ascii?Q?Tu8cQ7VSRL5PBIOmdyXrhzy+5f/KCLUv667834kdAOyLEUQIQdXVQ664dsCS?= =?us-ascii?Q?OrSYQkfQHGSoyKiP/y6ZoV6tKJqa5LGXj2jg0US9JxZ2ijgf7AXWPf2OGSw+?= =?us-ascii?Q?UGIDehEiRjmNhRNkoCdVyEmjGVsKBs6oPG3AUrSYp/I3M9+bv4dTrTPyyJBf?= =?us-ascii?Q?EXytA2lsilV84jzDq+95G5e69SgY4iGAJ4ItXb5s2cXHroor4d3GfKQJD0Mc?= =?us-ascii?Q?QLWXZonNVELt3KTz0Gg6rE6i7MURU2MnN1kEpXztgN6ysItdlnpvN8LnGE9z?= =?us-ascii?Q?o43In0jVxpQE/tpZjH99yyft6GZYegLWjTSFlqPMWi16Xa2aXmQOGo9JQlxS?= =?us-ascii?Q?5YY8IhS5G0Iv1nYCT8jgY6grvE0PumGpejPC+ATcoXI2LHXRMpt6oM1v4VUe?= =?us-ascii?Q?L06a1sdG8786LtPSzCbrvu3k0YokQE4DOo4jSBlH4suaJ8JrToJb381LUaCF?= =?us-ascii?Q?5Hd0QJE7f9UTHu+Ja7ap9SUldUH2JL1TcD1QxgCekSUUHp9Osvj/00tKBdlY?= =?us-ascii?Q?7/2ofZRsWt3GQDKWu/cf5w4/qoN1uGfUqFzpAW2AT3QJTIZFVA77YRk7fJei?= =?us-ascii?Q?Y2umZQNqVNXaOTYb5hp2Gf+ywh0SMwHkcuq/VUfz9lrHmfmg31PyLoMKsdW3?= =?us-ascii?Q?dk4u7ktl/Rc1GOq0eTwXc4Gl/K2c6HkAPLMHEiFQCZMVKPCfnhmfg1lmVGW+?= =?us-ascii?Q?kiqQlduMNcUH5tbddcAxIbf0oA44sei5vIZgYlBwcnYh62OvZX0i1DjhcD9d?= =?us-ascii?Q?strW51ymcGWG/Emltx0l0L8YCGCkJ2icl68LZm/EMzNiX7ch7N262r3uGUOF?= =?us-ascii?Q?Ls+wojcM+tE5IVpVMyeijkX0S?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB1944; 6:ghnuQOdlPtuD1DGKQD55ctlHIQ1OFO30+BdZEJrYqF7OxFGYLQ1+krnT5QcIpYxOTFOG7o64eBGDT7CAtWxJ6Av9ZjQtWslbMK9xcotwwH3MGRYakfOkq4AJDDFhN3aV8T/YEZzH/71LAZqVaQG4YOEXVOGnQzXs/5fT2XFRYeUbh1EIraZGNWkwxezE/IgdQjcnNvoSUdnWCqI7Aeksg4usE0zOljb3r+BRW2W914IobUbBcRH77h9fbbfhRJPyoBLKw4zmeYhYyOXE8oDd7Z2Eqqsd2/vDrkxFDdOlQVG49EmPJzCITvNZ2PrxVrePSDXYM9uAQavlIdcARyvGmsMxFYy4KaQpZzjKILOqklQ=; 5:L/LcQLFr/k7yEctME6kIlJBzYv/BI1bbgL+gGhl5Gl7K99lNatbZGbaDCu8yqUfMLZcnLSy4n+UD4ikJk/wsj1aitOa7IaxgrEZvruT1o/nilWc1AId17zsvRm+uq9MbM7BQVMMVQaLxlkEeBTLzjTCkNz44gqXnENoJUUvDMTU=; 24:NSQNRulgxsP0ASfx5Sw9qvPLsUf2QRdKL8GpiP9BvFv8oNNSBYw0As90gVjlisSapXJMs4smbUFqPm9TkdxYHfvJ15Mq8iaPcmBpL3yO+D0=; 7:vSFxgbQjtWGW3Uu/5a6Kw3Muoz/Dn583fsJbOVEVC/6BhB+S1v1pLyMrQUBPfFneGZFtjRX0zF2mdIyNbHR7bhk+R4v22FOzuqjl4cKFdjMkW0rpXaqU555/HVuYEPSrIKktqVXE7nSBurFoc7zdjD7cPRi0NcU0nQ91qOTWPpls58gZqpblBWQGy0HIS9GfJFOKubOMMKGl5FiV1m388IWPVB4RMooUeFNr5Ief31g5GOMWJC0HwJXkr6d0Ft+P SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2017 20:33:43.2884 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 47325805-9448-4788-b12a-08d54e3249cf X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0701MB1944 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Giridhar Malavali The logo ELS command allocates dma coherent memory for the data payload and serialize the completions. When this command times out, the timeout routine completes the thread waiting for completion which in turn cleanup resources allocated for this ELS command processing. Don't call generic sp->free routine when this ELS command times out to avoid to double freeing of the same resources. Signed-off-by: Giridhar Malavali Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 56bff7856cf8..4e6d3eb4caa4 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -59,7 +59,8 @@ qla2x00_sp_timeout(struct timer_list *t) req->outstanding_cmds[sp->handle] = NULL; iocb = &sp->u.iocb_cmd; iocb->timeout(sp); - sp->free(sp); + if (sp->type != SRB_ELS_DCMD) + sp->free(sp); spin_unlock_irqrestore(&vha->hw->hardware_lock, flags); }