| Message ID | 20180104130433.42813-2-yanaijie@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 01/04/2018 02:04 PM, Jason Yan wrote: > We've got a memory leak with the following producer: > > while true; > do cat /sys/class/sas_phy/phy-1:0:12/invalid_dword_count >/dev/null; > done > > The buffer req is allocated and not freed after we return. Fix it. > > Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver") > Signed-off-by: Jason Yan <yanaijie@huawei.com> > CC: John Garry <john.garry@huawei.com> > CC: chenqilin <chenqilin2@huawei.com> > CC: chenxiang <chenxiang66@hisilicon.com> > Reviewed-by: Christoph Hellwig <hch@lst.de> > --- > drivers/scsi/libsas/sas_expander.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c > index 3183d63..4b0c67f 100644 > --- a/drivers/scsi/libsas/sas_expander.c > +++ b/drivers/scsi/libsas/sas_expander.c > @@ -695,6 +695,7 @@ int sas_smp_get_phy_events(struct sas_phy *phy) > phy->phy_reset_problem_count = scsi_to_u32(&resp[24]); > > out: > + kfree(req); > kfree(resp); > return res; > > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes
Jason,
> We've got a memory leak with the following producer:
Applied patches 1-3 to 4.16/scsi-queue. Thanks!
diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c index 3183d63..4b0c67f 100644 --- a/drivers/scsi/libsas/sas_expander.c +++ b/drivers/scsi/libsas/sas_expander.c @@ -695,6 +695,7 @@ int sas_smp_get_phy_events(struct sas_phy *phy) phy->phy_reset_problem_count = scsi_to_u32(&resp[24]); out: + kfree(req); kfree(resp); return res;
We've got a memory leak with the following producer: while true; do cat /sys/class/sas_phy/phy-1:0:12/invalid_dword_count >/dev/null; done The buffer req is allocated and not freed after we return. Fix it. Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver") Signed-off-by: Jason Yan <yanaijie@huawei.com> CC: John Garry <john.garry@huawei.com> CC: chenqilin <chenqilin2@huawei.com> CC: chenxiang <chenxiang66@hisilicon.com> Reviewed-by: Christoph Hellwig <hch@lst.de> --- drivers/scsi/libsas/sas_expander.c | 1 + 1 file changed, 1 insertion(+)