diff mbox

[scsi-next] scsi: mpt3sas: make function _get_st_from_smid static

Message ID 20180111165539.1248-1-colin.king@canonical.com (mailing list archive)
State Accepted
Headers show

Commit Message

Colin King Jan. 11, 2018, 4:55 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The function _get_st_from_smid is local to the source and does
not need to be in global scope, so make it static.

Cleans up sparse warning:
symbol '_get_st_from_smid' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen Jan. 17, 2018, 6:02 a.m. UTC | #1 
Colin,

> The function _get_st_from_smid is local to the source and does
> not need to be in global scope, so make it static.

Applied to 4.16/scsi-queue, thanks!
diff mbox

Patch

diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index a44b9be6e3c5..13d6e4ec3022 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -888,7 +888,7 @@  _base_async_event(struct MPT3SAS_ADAPTER *ioc, u8 msix_index, u32 reply)
 	return 1;
 }
 
-struct scsiio_tracker *
+static struct scsiio_tracker *
 _get_st_from_smid(struct MPT3SAS_ADAPTER *ioc, u16 smid)
 {
 	struct scsi_cmnd *cmd;