| Message ID | 20180116153432.17927-1-luisbg@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On 01/16/2018 09:34 AM, Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > It is completely stripped out by the compiler. Removing it since it doesn't do > anything. > > Signed-off-by: Luis de Bethencourt <luisbg@kernel.org> > --- > > Hi, > > After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches > suggested I fix it treewide [0]. > > Best regards > Luis > > > [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html > [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html > > drivers/target/target_core_user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c > index 60c8a87b7a88..f6164d294fb3 100644 > --- a/drivers/target/target_core_user.c > +++ b/drivers/target/target_core_user.c > @@ -1564,7 +1564,7 @@ static int tcmu_wait_genl_cmd_reply(struct tcmu_dev *udev) > > wake_up_all(&udev->nl_cmd_wq); > > - return ret;; > + return ret; > } > > static int tcmu_netlink_event(struct tcmu_dev *udev, enum tcmu_genl_cmd cmd, > Acked-by: Mike Christie <mchristi@redhat.com>
On Tue, 2018-01-16 at 10:25 -0600, Michael Christie wrote: > On 01/16/2018 09:34 AM, Luis de Bethencourt wrote: > > The trailing semicolon is an empty statement that does no operation. > > It is completely stripped out by the compiler. Removing it since it doesn't do > > anything. > > > > Signed-off-by: Luis de Bethencourt <luisbg@kernel.org> > > --- > > > > Hi, > > > > After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches > > suggested I fix it treewide [0]. > > > > Best regards > > Luis > > > > > > [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html > > [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html > > > > drivers/target/target_core_user.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Applied. Thanks Luis + MNC.
diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index 60c8a87b7a88..f6164d294fb3 100644 --- a/drivers/target/target_core_user.c +++ b/drivers/target/target_core_user.c @@ -1564,7 +1564,7 @@ static int tcmu_wait_genl_cmd_reply(struct tcmu_dev *udev) wake_up_all(&udev->nl_cmd_wq); - return ret;; + return ret; } static int tcmu_netlink_event(struct tcmu_dev *udev, enum tcmu_genl_cmd cmd,
The trailing semicolon is an empty statement that does no operation. It is completely stripped out by the compiler. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt <luisbg@kernel.org> --- Hi, After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0]. Best regards Luis [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html drivers/target/target_core_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)