diff mbox

scsi: qedf: remove redundant initialization of 'fcport'

Message ID 20180206140316.31453-1-colin.king@canonical.com (mailing list archive)
State Accepted
Headers show

Commit Message

Colin King Feb. 6, 2018, 2:03 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Pointer fcport is initialized with a value that is never read, it is
re-assigned a new value later on, hence the initialization is redundant
and can be removed.

Cleans up clang warning:
drivers/scsi/qedf/qedf_io.c:920:21: warning: Value stored to 'fcport'
during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/scsi/qedf/qedf_io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dupuis, Chad Feb. 6, 2018, 9:58 p.m. UTC | #1 
On Tue, 6 Feb 2018, 9:03am, Colin King wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> Pointer fcport is initialized with a value that is never read, it is
> re-assigned a new value later on, hence the initialization is redundant
> and can be removed.
> 
> Cleans up clang warning:
> drivers/scsi/qedf/qedf_io.c:920:21: warning: Value stored to 'fcport'
> during its initialization is never read
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/scsi/qedf/qedf_io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c
> index b15e69586a36..50a50c4249d0 100644
> --- a/drivers/scsi/qedf/qedf_io.c
> +++ b/drivers/scsi/qedf/qedf_io.c
> @@ -917,7 +917,7 @@ qedf_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *sc_cmd)
>  	struct qedf_ctx *qedf = lport_priv(lport);
>  	struct fc_rport *rport = starget_to_rport(scsi_target(sc_cmd->device));
>  	struct fc_rport_libfc_priv *rp = rport->dd_data;
> -	struct qedf_rport *fcport = rport->dd_data;
> +	struct qedf_rport *fcport;
>  	struct qedf_ioreq *io_req;
>  	int rc = 0;
>  	int rval;
> 

Acked-by: Chad Dupuis <chad.dupuis@cavium.com>
Martin K. Petersen Feb. 7, 2018, 1:25 a.m. UTC | #2 
Colin,

> Pointer fcport is initialized with a value that is never read, it is
> re-assigned a new value later on, hence the initialization is redundant
> and can be removed.

Applied to 4.17/scsi-queue. Thanks!
diff mbox

Patch

diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c
index b15e69586a36..50a50c4249d0 100644
--- a/drivers/scsi/qedf/qedf_io.c
+++ b/drivers/scsi/qedf/qedf_io.c
@@ -917,7 +917,7 @@  qedf_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *sc_cmd)
 	struct qedf_ctx *qedf = lport_priv(lport);
 	struct fc_rport *rport = starget_to_rport(scsi_target(sc_cmd->device));
 	struct fc_rport_libfc_priv *rp = rport->dd_data;
-	struct qedf_rport *fcport = rport->dd_data;
+	struct qedf_rport *fcport;
 	struct qedf_ioreq *io_req;
 	int rc = 0;
 	int rval;