From patchwork Wed Feb 14 16:02:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 10219347 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0308360600 for ; Wed, 14 Feb 2018 16:04:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E69D820700 for ; Wed, 14 Feb 2018 16:04:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E49542823D; Wed, 14 Feb 2018 16:04:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 755F62914C for ; Wed, 14 Feb 2018 16:03:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031964AbeBNQDD (ORCPT ); Wed, 14 Feb 2018 11:03:03 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:41337 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031553AbeBNQDC (ORCPT ); Wed, 14 Feb 2018 11:03:02 -0500 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1elzWG-0008LE-Ed; Wed, 14 Feb 2018 16:02:52 +0000 From: Colin King To: Hannes Reinecke , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][scsi-next] scsi: myrs: ensure sge_count is set correctly Date: Wed, 14 Feb 2018 16:02:52 +0000 Message-Id: <20180214160252.32230-1-colin.king@canonical.com> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Colin Ian King The DMA size is not being assigned to sge_count, instead sge_addr is being assigned this value, which is incorrected. Detected by CoverityScan, CID#1465233 ("Unused value") Fixes: 8a8606895947 ("scsi: myrs: Add Mylex RAID controller (SCSI interface)") Signed-off-by: Colin Ian King --- drivers/scsi/myrs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/myrs.c b/drivers/scsi/myrs.c index 16498e1b0dd4..eb67ed3a7cff 100644 --- a/drivers/scsi/myrs.c +++ b/drivers/scsi/myrs.c @@ -442,7 +442,7 @@ myrs_translate_pdev(myrs_hba *cs, unsigned char channel, DAC960_V2_TranslatePhysicalToLogicalDevice; sgl = &mbox->PhysicalDeviceInfo.dma_addr; sgl->sge[0].sge_addr = devmap_addr; - sgl->sge[0].sge_addr = mbox->PhysicalDeviceInfo.dma_size; + sgl->sge[0].sge_count = mbox->PhysicalDeviceInfo.dma_size; myrs_exec_cmd(cs, cmd_blk); status = cmd_blk->status;