From patchwork Thu Mar 22 21:47:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Long Li X-Patchwork-Id: 10302367 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BEF6660216 for ; Thu, 22 Mar 2018 21:48:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B0DD22898D for ; Thu, 22 Mar 2018 21:48:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A5461289AD; Thu, 22 Mar 2018 21:48:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5EB242898D for ; Thu, 22 Mar 2018 21:48:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751992AbeCVVsa (ORCPT ); Thu, 22 Mar 2018 17:48:30 -0400 Received: from a2nlsmtp01-02.prod.iad2.secureserver.net ([198.71.225.36]:59094 "EHLO a2nlsmtp01-02.prod.iad2.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751920AbeCVVs1 (ORCPT ); Thu, 22 Mar 2018 17:48:27 -0400 Received: from linuxonhyperv2.linuxonhyperv.com ([107.180.71.197]) by : HOSTING RELAY : with SMTP id z83ReDNsPC9PZz83Re3Qd4; Thu, 22 Mar 2018 14:47:25 -0700 x-originating-ip: 107.180.71.197 Received: from longli by linuxonhyperv2.linuxonhyperv.com with local (Exim 4.89_1) (envelope-from ) id 1ez83R-0007hH-1q; Thu, 22 Mar 2018 14:47:25 -0700 From: Long Li To: "K . Y . Srinivasan" , Haiyang Zhang , Stephen Hemminger , "James E . J . Bottomley" , "Martin K . Petersen" , devel@linuxdriverproject.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Long Li Subject: [PATCH v2] storvsc: Set up correct queue depth values for IDE devices Date: Thu, 22 Mar 2018 14:47:18 -0700 Message-Id: <20180322214718.29547-1-longli@linuxonhyperv.com> X-Mailer: git-send-email 2.15.1 X-CMAE-Envelope: MS4wfO/suPO+RwtKAC+8Y24aPAm2MOOJ4U2Xuuf4/nxkxcwIm5Od5tsK3UQI1tLo96dHdovxJ+T50J7Jb99bUuMm8aY1idm/9cqpBMY6nL4r8Psgvopor+AE 4Qt8lAFJRRMKh3x/FnXQh0wIbiJNO7YiLhvBL7lLMo3FCXdMtS2+vnubGMSbl6euvmLkSkwohDh55np+3hygF7jjSzIY9FzGWaI9g+VF97DkFHQhNx5/nPJc UQPoiKlv7/MKTGRFoNX+QPbZ9VnE6H8PplLJSChKiehgDxtxCKrQKrURIUMl+xhYleg/uVX7KVOCxoM0mo5rNQumEhBTt90GpcxgLJLM2pP8ANSareSN4RZF 16bX/QLdSM68/wByIxPlW0j3B+mg9twWbgB/0youoTvcHxE9fN5sd2lOBwoF+vBEF8bbbQrKvZcuGf4WHLkfbkPa3xvBgYjO5CPh26Ag4WLMQAFEkHzedYD9 +tD/MbkT9yra2esiegtphsXtP3yxJaK7c/kwgLZ3gGl9VczNujMOGVCtxSQ= Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Long Li Unlike SCSI and FC, we don't use multiple channels for IDE. Also fix the calculation for sub-channels. Change log: v2: Addressed comment on incorrect number of sub-channels. (Michael Kelley ) Signed-off-by: Long Li Reviewed-by: Michael Kelley --- drivers/scsi/storvsc_drv.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 8c51d628b52e..a2ec0bc9e9fa 100644 --- a/drivers/scsi/storvsc_drv.c +++ b/drivers/scsi/storvsc_drv.c @@ -1722,11 +1722,14 @@ static int storvsc_probe(struct hv_device *device, max_targets = STORVSC_MAX_TARGETS; max_channels = STORVSC_MAX_CHANNELS; /* - * On Windows8 and above, we support sub-channels for storage. + * On Windows8 and above, we support sub-channels for storage + * on SCSI and FC controllers. * The number of sub-channels offerred is based on the number of * VCPUs in the guest. */ - max_sub_channels = (num_cpus / storvsc_vcpus_per_sub_channel); + if (!dev_is_ide) + max_sub_channels = + (num_cpus - 1) / storvsc_vcpus_per_sub_channel; } scsi_driver.can_queue = (max_outstanding_req_per_channel *