diff mbox

[1/3] sd_zbc: Change the type of the ZBC fields into u32

Message ID 20180417010441.28903-2-bart.vanassche@wdc.com (mailing list archive)
State Accepted
Headers show

Commit Message

Bart Van Assche April 17, 2018, 1:04 a.m. UTC
This patch does not change any functionality but makes it clear
that it is on purpose that these fields are 32 bits wide.

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.com>
---
 drivers/scsi/sd.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Damien Le Moal April 17, 2018, 10:39 p.m. UTC | #1
On 2018/04/16 18:04, Bart Van Assche wrote:
> This patch does not change any functionality but makes it clear

> that it is on purpose that these fields are 32 bits wide.

> 

> Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>

> Cc: Damien Le Moal <damien.lemoal@wdc.com>

> Cc: Christoph Hellwig <hch@lst.de>

> Cc: Hannes Reinecke <hare@suse.com>

> ---

>  drivers/scsi/sd.h | 12 ++++++------

>  1 file changed, 6 insertions(+), 6 deletions(-)

> 

> diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h

> index 0d663b5e45bb..392c7d078ae3 100644

> --- a/drivers/scsi/sd.h

> +++ b/drivers/scsi/sd.h

> @@ -74,12 +74,12 @@ struct scsi_disk {

>  	struct gendisk	*disk;

>  	struct opal_dev *opal_dev;

>  #ifdef CONFIG_BLK_DEV_ZONED

> -	unsigned int	nr_zones;

> -	unsigned int	zone_blocks;

> -	unsigned int	zone_shift;

> -	unsigned int	zones_optimal_open;

> -	unsigned int	zones_optimal_nonseq;

> -	unsigned int	zones_max_open;

> +	u32		nr_zones;

> +	u32		zone_blocks;

> +	u32		zone_shift;

> +	u32		zones_optimal_open;

> +	u32		zones_optimal_nonseq;

> +	u32		zones_max_open;

>  #endif

>  	atomic_t	openers;

>  	sector_t	capacity;	/* size in logical blocks */

> 


Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>


-- 
Damien Le Moal
Western Digital Research
diff mbox

Patch

diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h
index 0d663b5e45bb..392c7d078ae3 100644
--- a/drivers/scsi/sd.h
+++ b/drivers/scsi/sd.h
@@ -74,12 +74,12 @@  struct scsi_disk {
 	struct gendisk	*disk;
 	struct opal_dev *opal_dev;
 #ifdef CONFIG_BLK_DEV_ZONED
-	unsigned int	nr_zones;
-	unsigned int	zone_blocks;
-	unsigned int	zone_shift;
-	unsigned int	zones_optimal_open;
-	unsigned int	zones_optimal_nonseq;
-	unsigned int	zones_max_open;
+	u32		nr_zones;
+	u32		zone_blocks;
+	u32		zone_shift;
+	u32		zones_optimal_open;
+	u32		zones_optimal_nonseq;
+	u32		zones_max_open;
 #endif
 	atomic_t	openers;
 	sector_t	capacity;	/* size in logical blocks */