| Message ID | 20180529022309.21071-7-yanaijie@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c index 4617eccb0c43..6b6de85466c6 100644 --- a/drivers/scsi/libsas/sas_expander.c +++ b/drivers/scsi/libsas/sas_expander.c @@ -1107,6 +1107,15 @@ static int sas_ex_discover_dev(struct domain_device *dev, int phy_id) } } + } else { + /* if we failed to discover this device, we have to + * reset the expander phy state and address so that we + * will not treat the phy as flutter in the next + * revalidation + */ + ex_phy->phy_state = PHY_VACANT; + ex_phy->attached_dev_type = SAS_PHY_UNUSED; + memset(ex_phy->attached_sas_addr, 0, SAS_ADDR_SIZE); } return res;
When we failed to discover the device, the phy state and address is still kept in ex_phy. So when the next time we revalidate this phy the address and device type is the same, it will be considered as flutter and will not be discovered again. So the device will not be brought up. Fix this by reset the phy state and address to the initial value. Then in the next revalidation the device will be discovered agian. Signed-off-by: Jason Yan <yanaijie@huawei.com> CC: Xiaofei Tan <tanxiaofei@huawei.com> CC: John Garry <john.garry@huawei.com> CC: Johannes Thumshirn <jthumshirn@suse.de> CC: Ewan Milne <emilne@redhat.com> CC: Christoph Hellwig <hch@lst.de> CC: Tomas Henzl <thenzl@redhat.com> CC: Dan Williams <dan.j.williams@intel.com> CC: Hannes Reinecke <hare@suse.com> --- drivers/scsi/libsas/sas_expander.c | 9 +++++++++ 1 file changed, 9 insertions(+)