diff mbox

sd: Remove a superfluous assignment

Message ID 20180625234938.11939-1-bart.vanassche@wdc.com (mailing list archive)
State Accepted
Headers show

Commit Message

Bart Van Assche June 25, 2018, 11:49 p.m. UTC 
Since blk_rq_bytes(req) returns req->__data_len, assigning that value
to req->__data_len is superfluous. Hence remove that assignment.

See also commit 5db44863b6eb ("[SCSI] sd: Implement support for WRITE SAME").

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
---
 drivers/scsi/sd.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Martin K. Petersen June 26, 2018, 4:35 p.m. UTC | #1 
Bart,

> Since blk_rq_bytes(req) returns req->__data_len, assigning that value
> to req->__data_len is superfluous. Hence remove that assignment.

Applied to 4.19/scsi-queue, thanks!
diff mbox

Patch

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 9421d9877730..3463f21f91ee 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2028,7 +2028,6 @@  static int sd_done(struct scsi_cmnd *SCpnt)
 				} else {
 					sdkp->device->no_write_same = 1;
 					sd_config_write_same(sdkp);
-					req->__data_len = blk_rq_bytes(req);
 					req->rq_flags |= RQF_QUIET;
 				}
 				break;