From patchwork Fri Jul 6 20:19:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10512511 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B6830603D7 for ; Fri, 6 Jul 2018 20:20:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AB67C2841D for ; Fri, 6 Jul 2018 20:20:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9F6A8287B7; Fri, 6 Jul 2018 20:20:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5BBA3287BF for ; Fri, 6 Jul 2018 20:20:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933255AbeGFUUJ (ORCPT ); Fri, 6 Jul 2018 16:20:09 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:33093 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932328AbeGFUUI (ORCPT ); Fri, 6 Jul 2018 16:20:08 -0400 Received: from wuerfel.lan ([46.223.138.35]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id 0LqlM2-1g5exT1tRq-00eNrm; Fri, 06 Jul 2018 22:19:25 +0200 From: Arnd Bergmann To: "Martin K . Petersen" Cc: Jens Axboe , Felipe Balbi , Matthew Wilcox , linux-scsi@vger.kernel.org, "James E . J . Bottomley" , Arnd Bergmann , Omar Sandoval , Ming Lei , Paolo Valente , linux-kernel@vger.kernel.org Subject: [PATCH] [v2] sbitmap, scsi/target: add seq_file forward declaration Date: Fri, 6 Jul 2018 22:19:07 +0200 Message-Id: <20180706201920.2185565-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:gFLHbI4SRZKu7sStNHVecPi+UOtkhZ+hdXsQ2znEm66YVUlsntB ulVjcxVsbxzROTPA28V38wSS6Ntl7+3aXErFJUEm6W4xjZeU+mQgJhrxkhBf9StOoiHXou4 WKx3uudT2YK5KiJd8vf12IWGw80hbbxbxCb3s/MgyxzWAZbPTHU3hhRIiEgWP8Sp/0Dz3lz YGv8yEH4YiLXUdToLRdHQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:r3leehaQw6o=:nNNvtjeraBL8bHXSUymWNG UtkKfhslqlELGUHHtkvlxcQ7WvGT/D2g1X/qi/01M0RBoX+6GIKRn6a9N6pCvxlwha8l6h/N/ ut+12PfAs2OaSxhHlYropQgrfsEGFOlTgPoVxDAwMlT3IdSF5IUJNSR2Cf6Q7c3+SVskusrgP sim6cR/e01RqzSorj9krr4lO07mMcJqR7/XcylESQa94qYXIDFjiqMoxN4KbHOdwKG+683uV7 8jcRdGG0QuQMH1NsB3iS+jJP8WKA9Fx3qRhWPTXy561inz/ANoQFhMXnBv9Ok2/d5pohISMk3 U3Ak+bkw2Qr/SAZuhfV8ZWRn1mVnPqTziCs2Sgqx7M1so+ec14S468hJDUqB9FYkZI1oLqPKF EJEfTA3eEu1Fr1+rlxnE/P374XMrsO/y6okijH+UOuhGjH1YAIZnzJesjpdSfo++ubtxHIDG5 Pmh8JFyV84/vybvstmU6ABwdKWOJChdaCDQ57999Dv0vC9zwajmxnZpJ/VUT+gntn7CZrxrIc w2+L0UPmj6LLEeXPTitl5fjMmiUsQZtTc0aOGr2yqkjky0Oh0PX6D9ySbOLZHnECefIdgGd8F mnOo6qAkPb/yZy+pOtg+EjgRS9x/J7xu0OHQFuRspKqMp7U7yVFjDNcw026kCfNnIa9tHGXZi 5d/IOClYansyNu2UwlR8iI7K0wjieOZWLUGoKNYcIBdpOI4cv9O0AM4OwAWCMZe1LBc0= Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The target core runs into a warning in the linux/sbitmap.h file in some configurations: In file included from include/target/target_core_base.h:7, from drivers/target/target_core_fabric_lib.c:41: include/linux/sbitmap.h:331:46: error: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] void sbitmap_show(struct sbitmap *sb, struct seq_file *m); ^~~~~~~~ In general, headers should not depend on others being included first, so this fixes it with a forward declaration for that struct name, but we probably want to merge the patch through the scsi tree to help bisection. Fixes: 10e9cbb6b531 ("scsi: target: Convert target drivers to use sbitmap") Signed-off-by: Arnd Bergmann Reviewed-by: Bart Van Assche Reviewed-by: Omar Sandoval --- v2: move declaration to the start of the header, as suggested by Bart --- include/linux/sbitmap.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/sbitmap.h b/include/linux/sbitmap.h index e6539536dea9..804a50983ec5 100644 --- a/include/linux/sbitmap.h +++ b/include/linux/sbitmap.h @@ -23,6 +23,8 @@ #include #include +struct seq_file; + /** * struct sbitmap_word - Word in a &struct sbitmap. */