From patchwork Thu Aug 30 16:35:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10582323 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3362B5A4 for ; Thu, 30 Aug 2018 16:36:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 22AF62C0EF for ; Thu, 30 Aug 2018 16:36:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 16B712C132; Thu, 30 Aug 2018 16:36:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A08B02C0EF for ; Thu, 30 Aug 2018 16:36:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727579AbeH3UjX (ORCPT ); Thu, 30 Aug 2018 16:39:23 -0400 Received: from mail-bn3nam01on0077.outbound.protection.outlook.com ([104.47.33.77]:23389 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727698AbeH3UjX (ORCPT ); Thu, 30 Aug 2018 16:39:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bz8tKx1asbp/u40hzfPZyiwl9ImTUMDy/6nav7v5PsQ=; b=CrzDhtZVvUVw2F9l5cR28V478ozT2CefotFBV+jxj9HEqAMHR8bL4YyGP1ciWL4Dr2tpiR8O8gB11HfBESji1bxx1XV85P3LtLBviTDLeFxT4rxKvNBTdGF6GKaFpnm4Iq7Xapqs4JlBGYl5u9LjmPIRMhPZ3aVR5UgVNz+IFxU= Received: from CO2PR07CA0083.namprd07.prod.outlook.com (2603:10b6:100::51) by BYAPR07MB4392.namprd07.prod.outlook.com (2603:10b6:a02:c0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.15; Thu, 30 Aug 2018 16:36:07 +0000 Received: from CO1NAM05FT009.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e50::207) by CO2PR07CA0083.outlook.office365.com (2603:10b6:100::51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1080.18 via Frontend Transport; Thu, 30 Aug 2018 16:36:07 +0000 Authentication-Results: spf=pass (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=cavium.com; Received-SPF: Pass (protection.outlook.com: domain of cavium.com designates 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by CO1NAM05FT009.mail.protection.outlook.com (10.152.96.116) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.1122.2 via Frontend Transport; Thu, 30 Aug 2018 16:36:07 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Thu, 30 Aug 2018 09:35:52 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id w7UGZqFm027367; Thu, 30 Aug 2018 09:35:52 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id w7UGZq85027366; Thu, 30 Aug 2018 09:35:52 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH 11/14] qla2xxx: Fix iIDMA error Date: Thu, 30 Aug 2018 09:35:47 -0700 Message-ID: <20180830163550.27288-12-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180830163550.27288-1-himanshu.madhani@cavium.com> References: <20180830163550.27288-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(396003)(376002)(346002)(136003)(39860400002)(2980300002)(438002)(189003)(199004)(80596001)(26005)(69596002)(11346002)(305945005)(2616005)(356003)(44832011)(36756003)(6666003)(1076002)(5660300001)(2906002)(336012)(126002)(476003)(81156014)(446003)(8676002)(486006)(81166006)(50466002)(186003)(48376002)(54906003)(316002)(42186006)(16586007)(50226002)(87636003)(110136005)(478600001)(8936002)(47776003)(4326008)(106002)(106466001)(86362001)(72206003)(76176011)(51416003);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR07MB4392;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Pass;LANG:en;PTR:50-232-66-26-static.hfc.comcastbusiness.net;MX:1;A:1; X-Microsoft-Exchange-Diagnostics: 1;CO1NAM05FT009;1:MRxhsw9W+JbewCCLjqiELp11wE/NMX8KC/O/RWD3HDa5BusaBQmngUH/EesyXuuzFrUlRTF8LH9A6jR6X/7TKSdfkol63T6ZHmQBCO7jv1E6Yq3htXWFNrvAAcLuOQT1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fc0717bd-b201-430a-0751-08d60e96afdc X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4608076)(2017052603328)(7153060);SRVR:BYAPR07MB4392; X-Microsoft-Exchange-Diagnostics: 1;BYAPR07MB4392;3:nv3Y+kpc8aSJqWERqineiAJE9SQ3Afq3ICHxdKXgRGeOIGgQ0/azoe1DNOGumMOcq66wHOomPmYkYG+X7JrI8ADqNKHf42k8Cv5s7iFQ8dbg5EpGabvVGgZLriPqfuUG57/DXoAmFw7FIhlPCAi7ma/gCM1ibJD3VDRh9gdMehLZw/64KO/shs5weLEy0DSU8zfRqaRTptdK7x5FsbX+qVVtWNkvcYyATA4YFlFJ/MeeoILxOOlMxGH9c/PS1qVCCyJRRtTrcsMEeEjlZbhTJrmMuDAoF0nbQSC3UkNaEsq+j4GPKspUdaU3TU4sBG5mMhS3bSUr3wmVKtdeLt1dq1poFbbzpSzpfE1Zse2XRFY=;25:xmjJeBJtwBWJwOaLpwu/aXXJsLix/IQqqypkwpK38mQZWpepAs8akqCx9HsrgmDjDwqaIEbcGhfqyYO+pmLygJrmNNyJOC1XFLKk/f6z90uU+jfECvOU5ms3mhQKf68jkfsYtN1m/djD6auk0UQTogu8d95Jb3mPEXAkBV5ln813/uHtEMorCGPtzaV8Y50WCxMu+kKsPwj0JUoyKofO5tXxGpmKutIXKVpgWH8ynKnIhJFhhMqUNTwbcpYFNF9wLjXe1EZlJD2HCNcnQqA8JZ8by5E2ZvKx5kwEKI8jqsOavCqMN1NUuTLZtoravw7vWG1Y8BUkvVDp384hU2MB2w== X-MS-TrafficTypeDiagnostic: BYAPR07MB4392: X-Microsoft-Exchange-Diagnostics: 1;BYAPR07MB4392;31:fQ+E3Qjg9YEmdDzhCm+9oA5TjPw5h7aaTWveV1brLfPlhn8uFT12M2CgtTSr3gEMMCmAUyJq3g5CqxPzdqrxpU6soxeQn5hLjJ67cfsVh972bUhVTekl1jKsk4z+Llt0rXDyRILKULCep1gvOimof5UbtU7ce97f4mQB4saddrM0V5tYekQgnji7frMOXG6Amg61qq3oDpm7XXq0ChwfzTfJ8pjduT9UZJI2iiMpCsw=;20:sXuBB5DN10kIM8/mBIFO7fOX5NDjj4a2Q7dDueHKnYaiZ8M0QEXYejpHMu8BUsJgpDJorI3uvPxUmgaEUivsUwPAFa/HQYxhzsQWaswOYPHI5PvsVe9BKW818FlNf6xjB509pXjS9/AdJ5Of39CuzwqZFn4hLuWCwtgznRzzRhwyk5O6urzBMIwlGaJE/WjZSMNuOi47FPt3jw4ltUTBk02OiUhkBSfGStawztT3AhEmeNXD8eNgapZD17A1Bv4jQX7hUb4R96aNgCIdevaILysSl+1MQbKhf5IvpqE7QUALu2sxnZitKQD72aJ0mBKgXaIHMIrg0wqW5PSsQZzpTWBW7rAbNZLUT3PD/ht3JGrjTHeNS4zDdy2//NqZHdwd6MEg5x8a0Iu4zRrEMYcsB56HWDxEN4v6gx/49caVbtNbtWy9jnIv6YClSwIPJegBpyT6xWFNVIVm/0+pOIm9N2wuXhSNnetVmGqr+x2jcjqE3hvqEGnXeEeaQ3hAcMLK X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(3002001)(10201501046)(93006095)(93004095)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699016);SRVR:BYAPR07MB4392;BCL:0;PCL:0;RULEID:;SRVR:BYAPR07MB4392; X-Microsoft-Exchange-Diagnostics: 1;BYAPR07MB4392;4:LoIzoe1HPwfXeqwwijIjJbzk+xR2JgO13Ya1zcbbOmMtpaf1uWBzRYYgg3YjMfISkO/psjoGIQ9kWHq4cCDnYJBSWxg03OIV0oiN8XfqPj9kGKgq/SDQXrJyETHBuK/9a/VJXjTFgjs40LRANQYbfkYsFEUTG+xn9TCWIPHTLzhj07z7L+nXg33DexzuzsI2V5i3w4VcDrI1E2O+38yDlR2j+QEfFaQoPi0BbJ12aAsyYF2dA3BLF0b5QOgnT09VHdoqRzbE3EW0dxDUhoDxAA== X-Forefront-PRVS: 07807C55DC X-Microsoft-Exchange-Diagnostics: 1;BYAPR07MB4392;23:bsnyXgY8tlXd9Fx//Rl7Ql3VZfEPYaP0URp20qeSt/asCUspTZ7nskaSBtrNirh1kNOOS3Gq7zv6W13rLMug4T1C3pFy+q14KEFvQORm42UyVDnMuVPZR3R7Y1oFZOHqWA1sVEiAxHQ4vpVlcnPwriKodeG85ahn9rg83pUvALDqEDKcBrpxl2GMNTdGhQqVIj/wIShGn0mQyAok2lmnpkgdmeHmcQ6haW3jo22N2L9qgsruZMP2WuXErHUTtpVMmlDI9yrF3fWAOuh3xubwa3O08bjcuUtsdS03oGLgoxqT8+wbMOY6cfEEYg+2bUeV6m35WbAHnLx5pZpxiu/XJ/nO4hkx7/fyiN19TCPiRx/6yno4dw+f9tuoC+ZxmYdnwBuu/gPQE8M3WB5dixb5WPDJ+3dE8LGRp6Dob2IC1ME9B+ycVV9Lvi3YZKKXWe6ilZG0lHrf5JTJggXdPpudmMQirWaFfqsDMhVdNIt40GxnPP2F6cZoG2fBguIFAuxezZxdMpU6NAlqgF/GpZ4Mz6CUg10pKw7JJOHYssWOOsVi08RVFiWenLABZzTYnEkX2MTokHWZ0WdQs54f7/EDzj4lNRKj72ykcBM19yMf/zJaPyioxfCyxzD/F/yREmLh9dkKhaZKsRwnEOzb6sA+ZSnxoNh81ygqffkS9JhzY+toBRQJXTa6Nl++LEyjr/45WOAugJxOppV4rBIZAs4G1NqeCtZU8c7BQMxskmzB/d6+xVLe8aKvxBEdas646Q8mYkcK2oi6cTTWVnsWsyCp3JSVUpwW9Pp3rcD4YVah63hKoUU3NS0ctxRs4/exdfEo2thLv9ZLIHdqLXyNMZiVf7nsDZA2fjK6D7byeeR7DkWjhtiJp9HepxCh1f34ftx1g8RC1PHcMgWREN+92HcQnuyGXIYFEQkWVELCRQv89v2O7kUZ1Cb4mimBEDptJlTxFghlEb9GBz4t5mlcVh00HSIlTmjbCetyRasmIK2PK0PqqVw9qBC891YjyPqZBPuYnIo+QLsivoUrPx8kFfdu/88nCKfQgmYjWEbJxU7hMQT6DyQKOaBhiBSfD/k8mLRskXUP1dChsPqG0nYxboZV5TQDvb/IIic8PAO6FAhVXS4= X-Microsoft-Antispam-Message-Info: bZFMfcCBQyLNU36I8jK0zoR3q1ef5tsIoScYK3VKdTQTss/6YzJxkQaCZnVmQkEc49PLC0+N3noEPcOSltH4QpkJCokS3FPSrbrbm7bIn0KwZbeGhswsYNhbGJAUsecHOFS/KcMYsllRfJOrkXqlZch2OtzfxX+MBUX4WCijhqEI3olihnTKuzme0NiXKR9G0RwJURGPVzndso41aDkmL1OYA17CxADyXzZbpF0UPXD2lOiVxePqSsSmxlV8b44fSwwUYcOkd41nGJCFgmM4g+4n2Hbpnp4MHI6xmwXKIlks5YjzTKkWNWWRnNX0lO+AHzlIsPdWIhmBE7xQVhX9zwIlGuc9/zf0MmvF55jDu3Q= X-Microsoft-Exchange-Diagnostics: 1;BYAPR07MB4392;6:VCXFEw3mJW4Ke0FEBsCRmXSm8b2yy4uy0DRqY+KJM2aleX4cRSrl2pba6vVkfOQIiP4cEPClDyL0bnBXirtqFeXe7vAGM3/WLonXdl7mHRvg4lwLBILFJWRv2haGmv7H9IMhK7kFiVEoZr+5xZLLl4BDqdpD25oZaf0xNDHOZajqrqLwrv9AUPR7cYbNHPraWGfjnAJ0cJnKYdT8/ct38ijDiPHJBk0W13sQOlp9KwutkLrAthHKtYntQH2EU8Upd4ToWcnAO1OwxB3fxD3wfEz8afRv5qetmoHntpS71r/nuL8rZY3zGsSpYbdJo1vTRLwzME7l+MLeyqzWLgsGnn5BTBtIKVgzQeFjd/0iyThGTXSNJL/JMipYPb9+kyhRMkwkb1ZFJ2UNb+hDISLnHxxHB59Rxk7A2EyhtJt7mSZReEFUJDckWfExqTcbvTGqSAmJEbwTNgHHk3OqCTmFWA==;5:4VA+xvvbifyWGZACdrH8XCsjNMknYgNB0nYOL/3XCizAjIObWiSzns4k2Y7vJzN+6LoOM9opXhJsbq16mien0YASWutHDp8KjfBuUyGGGqZ3oORY35PnkG3UtGhukHCET0YqkmvJa7pYXeZQ6tojU2ssvmsKXQTcwippHkhqybA=;7:YJoA0oI/mF4F2ruff27r3xu7lrKdQrJVsDX09FHUGg0lZry8eU4sOFC8+awgmQxdCzUSaRPJlYYdmrlTawqY7M6hcxjB10v9xA33d7KUjop/9nLis3WAhaG8sBtL1jY6ul9KCtf3WMFD0ziWrcqPXRHgAkOZHOgNbnDSIexLegIC2HQIk2sczU6l36XyWhv+bwnYKnH8/DSdQ8U1QNtAN4HNCVK7OZxpAOpL8yiCT5e63vh4IFxM8zeB1oVM89lT SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2018 16:36:07.5319 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc0717bd-b201-430a-0751-08d60e96afdc X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194;Ip=[50.232.66.26];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4392 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran when switch responds with error for Get Port Speed Command (GPSC), driver should not proceed with telling FW about the speed of the remote port. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c index 85cbe59b4f58..902106f97020 100644 --- a/drivers/scsi/qla2xxx/qla_gs.c +++ b/drivers/scsi/qla2xxx/qla_gs.c @@ -3272,7 +3272,7 @@ static void qla24xx_async_gpsc_sp_done(void *s, int res) ql_dbg(ql_dbg_disc, vha, 0x2019, "GPSC command unsupported, disabling query.\n"); ha->flags.gpsc_supported = 0; - res = QLA_SUCCESS; + goto done; } } else { switch (be16_to_cpu(ct_rsp->rsp.gpsc.speed)) { @@ -3305,7 +3305,6 @@ static void qla24xx_async_gpsc_sp_done(void *s, int res) be16_to_cpu(ct_rsp->rsp.gpsc.speeds), be16_to_cpu(ct_rsp->rsp.gpsc.speed)); } -done: memset(&ea, 0, sizeof(ea)); ea.event = FCME_GPSC_DONE; ea.rc = res; @@ -3313,6 +3312,7 @@ static void qla24xx_async_gpsc_sp_done(void *s, int res) ea.sp = sp; qla2x00_fcport_event_handler(vha, &ea); +done: sp->free(sp); }