From patchwork Thu Aug 30 16:35:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10582301 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 934B15A4 for ; Thu, 30 Aug 2018 16:35:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 836732C0EF for ; Thu, 30 Aug 2018 16:35:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 771342C132; Thu, 30 Aug 2018 16:35:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C660B2C0EF for ; Thu, 30 Aug 2018 16:35:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727671AbeH3Uiz (ORCPT ); Thu, 30 Aug 2018 16:38:55 -0400 Received: from mail-bl2nam02on0049.outbound.protection.outlook.com ([104.47.38.49]:48779 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727501AbeH3Uiy (ORCPT ); Thu, 30 Aug 2018 16:38:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CfJomuxMO0Ykf32dJ6beHDUOvEtGG8fEuCEx6D76pVI=; b=A22HVI/cWQDJvvUzu3afwxy0J9zwJJzl8Z9iXHh/my0cK8Ef1tje0OpdHO9eYWwn2QE2azPZ4LnHb93Vm8hMuW71I+twZM1xizzxqwtbDdeKH8U844BeQFIJcoZ1GFzZX245WIWQZ9BJVIlA0iu26E4TRkTzVz0Fl4mWW6O17m0= Received: from BYAPR07CA0046.namprd07.prod.outlook.com (2603:10b6:a03:60::23) by BN7PR07MB4385.namprd07.prod.outlook.com (2603:10b6:406:b5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.16; Thu, 30 Aug 2018 16:35:54 +0000 Received: from CO1NAM05FT023.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e50::203) by BYAPR07CA0046.outlook.office365.com (2603:10b6:a03:60::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1101.15 via Frontend Transport; Thu, 30 Aug 2018 16:35:54 +0000 Authentication-Results: spf=pass (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=cavium.com; Received-SPF: Pass (protection.outlook.com: domain of cavium.com designates 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by CO1NAM05FT023.mail.protection.outlook.com (10.152.96.131) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.1122.2 via Frontend Transport; Thu, 30 Aug 2018 16:35:54 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Thu, 30 Aug 2018 09:35:50 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id w7UGZoLA027327; Thu, 30 Aug 2018 09:35:50 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id w7UGZoWi027326; Thu, 30 Aug 2018 09:35:50 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH 01/14] qla2xxx: Fix process response queue for ISP26XX and above Date: Thu, 30 Aug 2018 09:35:37 -0700 Message-ID: <20180830163550.27288-2-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180830163550.27288-1-himanshu.madhani@cavium.com> References: <20180830163550.27288-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(396003)(376002)(39860400002)(346002)(136003)(2980300002)(438002)(189003)(199004)(5660300001)(4326008)(48376002)(316002)(86362001)(110136005)(54906003)(42186006)(2906002)(16586007)(50466002)(50226002)(36756003)(80596001)(8936002)(6666003)(106466001)(87636003)(305945005)(81156014)(81166006)(69596002)(356003)(72206003)(47776003)(478600001)(14444005)(2616005)(476003)(44832011)(51416003)(486006)(26005)(446003)(186003)(76176011)(11346002)(126002)(106002)(8676002)(336012)(1076002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN7PR07MB4385;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Pass;LANG:en;PTR:50-232-66-26-static.hfc.comcastbusiness.net;MX:1;A:1; X-Microsoft-Exchange-Diagnostics: 1;CO1NAM05FT023;1:j5GKa5JqK+f4TbuzzrtTnQXIkmwMHQiHhqulLGClrtZxPABH/NkrXVqCecIDO7Q81W8jonR2mSlXcMcBukspaypoETUCD+nG9famXwYn1UMeVDV30cvj2wXndd16/023 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0960b5bd-1a69-49a6-fc60-08d60e96a7d1 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4608076)(2017052603328)(7153060);SRVR:BN7PR07MB4385; X-Microsoft-Exchange-Diagnostics: 1;BN7PR07MB4385;3:vbZlk/lfn3KzPoXWnJ9Y8H8BrB8z7vFhUBDNZSg1WkHIVjTkhaA54zB+Ykd3Ech2znS4hOXepe/Vl1G5QMuHq1MLK4OBnOr4nKVaoA1w+evyIOxczU/PV0yeImq/hJt07lfAnAbGJ+EBA1xTMY9ao6thmEbg6D14wCJMJ1K/etYX51tCDDnmSLkv1VrUZS41H4/6fQpCMUhvuZOZCz6cqVk5u8SmLQRDmmKHVKpvu+c+HGBs4gLsu7BGuJ9KJujZBX2Kc/ToykTMvir8WGYCmQ+a3vu/EP3CxzT3WXLFwM/WK+bev+WVluuq+ON9pSr96hOUPTq3BONAXhh+EY8FRTdQIr17iL4fDxdxdkZdWCY=;25:La4a1LoMD0gsf6qhTk9OHieripl8/LbLK5sF/TvlrtsKNv9czgdfSW5I6hvPaTkTbEXxXz2RqW7uY4WYqI4Yqok4TGmDcEwe5F+z6S9XDBzmu0etvoz4rHiRmKyH9FH69l79I1xErRA+3QiDtLegQUnZlNahUSXRUK6tBfowUMk+88be4J8/udI2qQzn1tq21zpvH43YkUljf5UUg483+Cqrp/PLLaT3QmOYr0PfqfWGEjlIOpsNF/QoJaXGCtL2ELaEFMuOQTY756Jx1BuouA5MvxagscyFUnEE9Z465zXivNAJnybSMRID5oUWYXPP0w87FcdhOmYkdyqwSzYaxg== X-MS-TrafficTypeDiagnostic: BN7PR07MB4385: X-Microsoft-Exchange-Diagnostics: 1;BN7PR07MB4385;31:35lpPRN7njTO/zh9MuZvDKAVzRG3PfKwSB3kkMBnlhY+lxO8lJ9WKErHo7eHeMCJZumoVxyciGmKf6ptSBZ2bLfvwjgvaPsfLrLoKVGgX8zFkACqIeWHCOK8gCAbhc6m9ooAlEw/nVQBfDlo6SZJlHL+TAyBq9AP79KGZYPnFkWZIFIbmG0oZiG3fFjvj7LeRQVkB2Q0nsmd9CKQmn5y4I3NnE+EXkfy/iaRSMpqb+Q=;20:IAFpvryjW9eAHbrDTjbKruLJeJF+pb+1k4vyMZqjr4W5EnjV4K8YgG66U/qPAnpWFxWLQUg2WeQgoe5BacyTXTVqeAcf83/nY5WhmuShOq2llsuzMWm1BpdUFtDrrba0GXSKnPZfXDhWQq0Mwi2tvzJ8CYjcAh2G2cXO6tn2HVXARqlMV9x9jgbNJQwg+Vk7eNyI6qsKmrA/DvZF3Dwlz+ziZ7F/v2ZRQn47Gamb/K/BQN26tox4lmrCC4Z6oV/0QSkfDLw6Sa+aDFQDqssbRmg3hDS/P2bzKttMhANGz1PTyupPP+auj9QfTQkQ5TmnmafMEq0IkOim1FUD4+YMIyYx3Bdv1u+1DvScVRPfjKSB84bpztrr4Bv44928Nsbf1JQsedFkuu0HD1Mo7HYbxf5BkY8sZQkryvk1PN4KJVrcaQdBUA0kvgS0DyvP1lu3UDK5x9qvqskc92hBSk0NXWRXMemkb5pKG5tOVXxjgiKJhUi45p9XmMPEc60pGn6C X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(3002001)(93006095)(93004095)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699016);SRVR:BN7PR07MB4385;BCL:0;PCL:0;RULEID:;SRVR:BN7PR07MB4385; X-Microsoft-Exchange-Diagnostics: 1;BN7PR07MB4385;4:XVbozryqOK7OM/iU6lLvLB3qFCVzYcYW99jvDTAIFtNWRu364Em8hqc+m9eAjbSFhY0FOxEr6nmW7zjxsKUxngsioa8B8M+hFKJK4s9SnIHMfBUWTEPRohtsD/clHXMYPHktFKAIP4L6kedCzcIKKDMAV599zXnh9fXV6m42oqaOhPxbD//OLoCx1VG8iFOV6OLdhaKQyqc0kI4V66fVxNjrQ/cBzHgMZfxgq6F6qug25S62xcb+mrgcbhepPzpep/89sbIY0GUnO5OHa2YfITFLcNU6FYaF6Roa7kdl7erZVE/LL9aEebwTDubPoxtr X-Forefront-PRVS: 07807C55DC X-Microsoft-Exchange-Diagnostics: 1;BN7PR07MB4385;23:H4Rb/9DqiEo93u+mn3ywtDDlleywrMe0c8uzEcT1fSA3zVgmw98jad5DkEe33Q0+cToZuQcmJJzcDvmNW7ToKeqShUJMxePIXVDmytwqKosM8ZFsA8XGZ10zby9HgVrSdxzk2kM20EIa2XlTMKQ4dewTg9xj7f1YGu4JHaTp2AzG0uKjPhVfzz+8No+4yfSPhgErrxlcOzHMNYTW/3uCrDYoQYeu7dsXTQ3y4EFYkJU7f8epdrPMzhF4vNkPkLDapD8TC8doQebo/sfQNliNQ87MAJLbZ5Nqt984pNhRLaUxZTTg/SWUk5P2NEII2dqb2DbjJdHhAf21i9aiQcu/hHiZqklLL9wRtX7TkoYHMyaNBa6WP8K7iiZsFroI5GKdJ/mcMncCQf7MvIBNb+gJHfWNbsFkAxH05ZyzyZXb8zPEMUP6czyvrJuZQfaD9Rubdhf4RuGC6MIPFU+p0LdB6naX9TUa9OeG8VVzA/bTR/iV1rkKRXM8MKwLKX7m7Au8dP6ROsGH6sZzCGemQrA30/YXdwcWGVzkwwCcGb2lUFvpxD+jtO0e71rkm3E9+GM1UedqqG6OtTdeJ/GmmK2jN0/ALSu0X3J6yScCMdFKI4UZnNGvS206wopaCAbpuxAkyUHq2u1PsHqkftgJI8v2OXv2wEbWNjAb3qpqj0fOlNUHGapqSLgVtmuHHVsz47QbQeD0/2kZJ3yywQqS0yWRA7vG5MGfR5KJiDd7vDiIQAZIASdbammUqAsZGKNlitSyGBkUYVarX1UTFADOXaArmfcH26EwIMBeBfkJyFyiWVGsyfbvY9HA+jK7IipYr+womgOgoYWadCb8UpJQcPUEygftk7e2rIxoBgVCfRjY3RgKKOMHffXWjPRb4Did4t+zRk3g/GFkraIOFZp9SsZePj5yOnpnPOk13M+vUI9vA6/sZ76DWybXj/V6mMi0zTXd/bWLGpduidjX8gzymS3mPS1oAfhefHD07cGydS2pqPXRzs0gxpIJl3yPcMWCuWFPDNkXvrIBf8EXYgMPz1fV1SHqk5EBC29Q5p/kcriMy1zlWZFmceP960S3UEgmH18vJOgaW1ZHebxLbdElAA38AOIgNxySuo6YFbki5gld0zDM7V0XZ5sHg63nSHZxauWE X-Microsoft-Antispam-Message-Info: XhRH6W+jN8lFAFwJsHDu1pgbgqERQ2dLHV47kqrQce/mFyJIZvz8uSCD6SWWD0ODPqdq4YQ0A00WoZVn/WQ8qg4gflpB6LDkHx6MUeskf5mOf/D/n7FKAHe1r4gizv7Z9WDfaYbACIRTJTiRyHEIAy3FdCDxziEuEglogYW1ja9xJy8w6z8gKhyK6enJr3++5jhk+YVlog+pfy9o/Lp1wA/0ErGHaP7silfeK6NQ2OdIRBvzhFE8utwXPQ2+sLz7/kd7FUSJwKyWx4RDNdh7j9diSf/Haqm2e0jJx0TSgr3sWBDss9K9cxl4qUW69/WBwJlvEGLJxWSJeMFY4wZiVlBkG7Fu0MI9Y0z45ZBrDk0= X-Microsoft-Exchange-Diagnostics: 1;BN7PR07MB4385;6:4U2iQLVqg+4gtT7xYlZ7O8JTbqUzJIekTJHayq+EYJRTqilh8EWJ0y3F5afitI/c6LMw4ifohjTGX/xcjO/qRPgglj7QsO1XxahM/AnzkId9T+Qw25mMCT88cf8aV9O3iQ3Gq6PV4CSSGnzi4l2wkUZPCQoL/reNHrj2Q/N/jvOD/gXJDbYIt4DmsBmGUPWq8vrn8EXiHiPnobxT9Qf/Zv+fyNQ4h0wLch3+hZpgw1WhQIovFse1Sgjbr+BF+kJisIvxZlflLYr5g3gBwhNTAAbgi6ubrdsuW8HBT9xzGN5bCSsWmYkKKLvZbr2HKEn1uSjotNuO/7mlNd/qGrNqb5G8CH2/20Da1R1kx9YX68Hwv6k2d+zp78QiVv93vdKdTA3dAjqePBK6EYrxcRtuAcC7TOos5cIZHkj6hZ4/PaRD1qd7y7YderqRXqtMCKfBImCnIcxZGvmzkMuvWRDhig==;5:5CaizgWZed7E/WD3svV4YdW9yVK7LjjZj/6dKriBjPlap0nPI8Baz2s/PlqLIaHftYaWw1VTSen3gIQ6vJJ1iCKTk1vj1ExW7T19dO4fgcKrefJxQ2dS1kZ0ka7MdkxHS8Oh9T4R5PUG3gW+4ZhnOE3GsPdxYpX5+dnQcmTUe54=;7:b+bYowiFU3lt9dd3jKHYPEZQUAVeywkOTPE42jzjuWWBfE99AhjzVugBj5W+r6x1XXAtEjnqGQ9d5+57Gjgz4sMFeL6NJXgWtH4osDNqPzDuMrf3cQ25MjJkI0lR0fzjemly8QNYnA7rrUwQLw1uwq5EpbgB8JBqnyu4TOYKUvLAGc4WDdhMMRRo3jaJHPwBXp6P6hwyCFKVxg3EE7eE86H1RaBC0+ZzwjDuqEACEUPpV4rIdjxZNdiUic9PKDGw SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2018 16:35:54.0443 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0960b5bd-1a69-49a6-fc60-08d60e96a7d1 X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194;Ip=[50.232.66.26];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4385 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran This patch improves performance for 16G and above adaper by removing additional call to process_response_queue(). Cc: Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 2 -- drivers/scsi/qla2xxx/qla_iocb.c | 17 ----------------- 2 files changed, 19 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index b934977c5c26..4686fb5f26aa 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -7142,7 +7142,6 @@ qla24xx_nvram_config(scsi_qla_host_t *vha) } icb->firmware_options_2 &= cpu_to_le32( ~(BIT_3 | BIT_2 | BIT_1 | BIT_0)); - vha->flags.process_response_queue = 0; if (ha->zio_mode != QLA_ZIO_DISABLED) { ha->zio_mode = QLA_ZIO_MODE_6; @@ -7153,7 +7152,6 @@ qla24xx_nvram_config(scsi_qla_host_t *vha) icb->firmware_options_2 |= cpu_to_le32( (uint32_t)ha->zio_mode); icb->interrupt_delay_timer = cpu_to_le16(ha->zio_timer); - vha->flags.process_response_queue = 1; } if (rval) { diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 42ac8e097419..119927220299 100644 --- a/drivers/scsi/qla2xxx/qla_iocb.c +++ b/drivers/scsi/qla2xxx/qla_iocb.c @@ -1526,12 +1526,6 @@ qla24xx_start_scsi(srb_t *sp) /* Set chip new ring index. */ WRT_REG_DWORD(req->req_q_in, req->ring_index); - RD_REG_DWORD_RELAXED(&ha->iobase->isp24.hccr); - - /* Manage unprocessed RIO/ZIO commands in response queue. */ - if (vha->flags.process_response_queue && - rsp->ring_ptr->signature != RESPONSE_PROCESSED) - qla24xx_process_response_queue(vha, rsp); spin_unlock_irqrestore(&ha->hardware_lock, flags); return QLA_SUCCESS; @@ -1725,12 +1719,6 @@ qla24xx_dif_start_scsi(srb_t *sp) /* Set chip new ring index. */ WRT_REG_DWORD(req->req_q_in, req->ring_index); - RD_REG_DWORD_RELAXED(&ha->iobase->isp24.hccr); - - /* Manage unprocessed RIO/ZIO commands in response queue. */ - if (vha->flags.process_response_queue && - rsp->ring_ptr->signature != RESPONSE_PROCESSED) - qla24xx_process_response_queue(vha, rsp); spin_unlock_irqrestore(&ha->hardware_lock, flags); @@ -1880,11 +1868,6 @@ qla2xxx_start_scsi_mq(srb_t *sp) /* Set chip new ring index. */ WRT_REG_DWORD(req->req_q_in, req->ring_index); - /* Manage unprocessed RIO/ZIO commands in response queue. */ - if (vha->flags.process_response_queue && - rsp->ring_ptr->signature != RESPONSE_PROCESSED) - qla24xx_process_response_queue(vha, rsp); - spin_unlock_irqrestore(&qpair->qp_lock, flags); return QLA_SUCCESS;