From patchwork Thu Aug 30 16:35:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10582303 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B1D2C175A for ; Thu, 30 Aug 2018 16:36:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A19482C0EF for ; Thu, 30 Aug 2018 16:36:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 962562C132; Thu, 30 Aug 2018 16:36:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 382592C0EF for ; Thu, 30 Aug 2018 16:36:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727674AbeH3Ui5 (ORCPT ); Thu, 30 Aug 2018 16:38:57 -0400 Received: from mail-dm3nam03on0041.outbound.protection.outlook.com ([104.47.41.41]:30144 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727073AbeH3Ui5 (ORCPT ); Thu, 30 Aug 2018 16:38:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4La41tnfV9u0wn1/1YbSomSa6Krp2LHn3GNuW/Ka1DQ=; b=IT+lsRIzwo4r9G16XB6hxXK6xj0GC4kxViw9rPDlvk0tSeZSrifIRr3QnQ3opODCuFSmFIeteJ65TofO3BZTXbfjKPD0K3cSl4u/KQ3tBRQMM9ZHF1I889U9A9GiIb0M7F/oUKeBTBzAecdOvkfjxoRH7V36dbMYu986WZ5TMio= Received: from BYAPR07CA0061.namprd07.prod.outlook.com (2603:10b6:a03:60::38) by BN7PR07MB4387.namprd07.prod.outlook.com (2603:10b6:406:b6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1101.16; Thu, 30 Aug 2018 16:35:57 +0000 Received: from CO1NAM05FT023.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e50::203) by BYAPR07CA0061.outlook.office365.com (2603:10b6:a03:60::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1080.14 via Frontend Transport; Thu, 30 Aug 2018 16:35:56 +0000 Authentication-Results: spf=pass (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=cavium.com; Received-SPF: Pass (protection.outlook.com: domain of cavium.com designates 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by CO1NAM05FT023.mail.protection.outlook.com (10.152.96.131) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.1122.2 via Frontend Transport; Thu, 30 Aug 2018 16:35:56 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Thu, 30 Aug 2018 09:35:50 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id w7UGZoS5027331; Thu, 30 Aug 2018 09:35:50 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id w7UGZojK027330; Thu, 30 Aug 2018 09:35:50 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH 02/14] qla2xxx: Fix incorrect port speed being set for FC adapters Date: Thu, 30 Aug 2018 09:35:38 -0700 Message-ID: <20180830163550.27288-3-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180830163550.27288-1-himanshu.madhani@cavium.com> References: <20180830163550.27288-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(39850400004)(396003)(136003)(346002)(376002)(2980300002)(438002)(199004)(189003)(44832011)(106002)(478600001)(87636003)(42186006)(76176011)(316002)(5660300001)(54906003)(110136005)(8676002)(50226002)(80596001)(476003)(69596002)(8936002)(126002)(356003)(72206003)(48376002)(2616005)(36756003)(81166006)(81156014)(16586007)(50466002)(575784001)(86362001)(486006)(2906002)(1076002)(26005)(186003)(4326008)(336012)(51416003)(106466001)(47776003)(6666003)(305945005)(11346002)(446003)(14444005);DIR:OUT;SFP:1101;SCL:1;SRVR:BN7PR07MB4387;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Pass;LANG:en;PTR:50-232-66-26-static.hfc.comcastbusiness.net;A:1;MX:1; X-Microsoft-Exchange-Diagnostics: 1;CO1NAM05FT023;1:VfouxjTkZaDuXNCsBJUK3pu+IoA4UzOE49h1ZhJmDZRvlD6e4EiD/zBTrqirug8PQqP/Shqez8qCLAreEhhgXuHzWx140uXhC9SJ2GImqZkNOZ9bGBXkWtbxUVKh+0Xp X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6cb37193-75a6-4284-3d15-08d60e96a916 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4608076)(2017052603328)(7153060);SRVR:BN7PR07MB4387; X-Microsoft-Exchange-Diagnostics: 1;BN7PR07MB4387;3:5nLZ6OjkRWxtmjUwazfs+IbbBDANuhThPS4etGm88rzlyO97u5RjFWtTFKY1lwM/xyq0cIdY2Rw9tqFpPNn01YsM1iGIuP6caTqSJhY7/fPPF28TMWaZ5n7fZaylHnt/A5WuloGhDN+7/UysTmtNkVuGfObE51cY1BCDh/VuJGqQhdmzhaissqRVjX4ylSiv7+W80Pjk39JA3bDg31yGKWGuvFhGjiK5q0xyPKcCmU5/ZOE0K3EcL9918Ue003W93oL2JOTz+yutbkMNIoKXpZbk5arxOxYpy0UtcDkzqQ6rCWVGaM3jKPD2pDTInE2WvkSrQKXQ74PgKB3BAMJ66jWMxPhB/6lPUnZen1Cw9Tg=;25:dw4m2Adr6OKL5gkMKmPUu0L0i7zsJAY9KmcYYr5vJZI0g4iTjCC+ldiYq7w6XC9Uw/O2/KZIvJ/BLK7dYFA9POPDV/CV2BS/8xRsQAXnVMIYVMxAi80C76LvCp/mR79z/IgJepE8uS/tIeyPt05UqXmDLJgdPEsjm/3VQ9GfrYTTWX0EyddojBVpM7YoBeF1y29seVoOf2TcTIO/Vsmu1fSXyeRfH1cAvScMEwSYWXkBbofFP3ZNRYbBNmTedY5+E7QbcFBmG4u2i50EG0lqpmPBoyvoqJ6pp+tiPFDbOa/t3ZVM21SGY6YS4ofutN7UVOD2OJ2G09wsbqtjHaYBfA== X-MS-TrafficTypeDiagnostic: BN7PR07MB4387: X-Microsoft-Exchange-Diagnostics: 1;BN7PR07MB4387;31:bTG4vD93f6UQsgWrRPSoO1oKjEUkc1rNIEKk4gzC13nfvdYwVq3KkU+UMk1USSV/fJllGTp/xGmhM9rh8wabDVbzVroqDP9uz5KKnTzjZv28/12+zcZglNTWFH4ja1yyxGg+3XHmxDhcWd9p4RUlI8C1rVoWDSALnuxpHjN1jZc2cbFISoZw7PXt3n64qQJ8EniXSWE/pUVe0eOhqL3lRdiSd5ZUGsTWrRPwdZ5hybE=;20:AF9/aOxI1Ue/F7F6+H3gY6P1bvdiQUlshSbyVe4ZU8CaF1r0nAH85b1EN1WrM4ezioaStGLodkTooRj7b6QW+JtQ0nXWhaLqeDKVd9t4kwLjrbiTaTRMCvsO1ITQMITL0seX2nWDLpGLj+hnbopy0B52urjZqB8ZpAz4YXJlKES85js+ToTYQCbhu4qLgEnFd71NWg35LOiU6RsqzqpovI1k120QTgjgCRe9rBDSFnfqYDTTJJvIEvyzLVPQ9gZufkV/IZRD9mk31R5WswglfSGHnpiRMfP4Z+i7yXwgkBaZdeAqjPDpv9JWbLzMbnAXrgdsHej+hlNDdVBFnef/57NSdg9PiLWhjmPuA6X2HhaGyUV1sBxDdp0GrZHg5sxz0OTaUrjAeI4S6/C7oMNoHCb7epy7zpX0G7LHJuXNp78ZZzYmwDW7QvayqL1WAae7iFl/BSxwNku9ZDa/ZlaSQRPwLUvgb4XMla7N72P+Nxlsysqz1fbLYpldGpiDdOuE X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93004095)(3231311)(944501410)(52105095)(3002001)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(201708071742011)(7699016);SRVR:BN7PR07MB4387;BCL:0;PCL:0;RULEID:;SRVR:BN7PR07MB4387; X-Microsoft-Exchange-Diagnostics: 1;BN7PR07MB4387;4:/d/bE0eRYxsAkxXSzFSu9hJQFNFr4ZSzdsPduRI9UfK4hIWdDzzDQ0I4MQlFzVUdTmShBj79mcTbRRxjkUKAs6iG9Hyz+QK+T7g2p7cC8GRImKpk/89KW7QrAabMOMF7Xyg8ADnlQC6G4gvV1gz6culIibcVp3RQHfCHGGnICbgCoZ6wA1vPcH44e8VyMrvKWlbezkQwGu+g1WESlISIcIi6fbGae6SjGP9qOe5Bk4fYd7VEqGhVuWlW8/AwHJ24H5LNobsVZgff2sZxxf8L1mEm8flTfJlRsWCCSRgzgb2br/6TOoWw363H7Wg9s0yM X-Forefront-PRVS: 07807C55DC X-Microsoft-Exchange-Diagnostics: 1;BN7PR07MB4387;23:c7I8DdFBN+TMsEWaE/c8tCvcxiPJ9c0B1VpJWsWaSrL0h8OhEXc56M6+aASvpjlbd8Umtt841RutMNGxmcFbmRNkSE4slUYWhgtEduovEOdZyPMpZDdC0HH0mMnhJ+sHy5W+UyZVhC8KOzUjffSAUXNg+oDxs8iCxv1EPEac415TEA1Zy+QMqOBPsFCu/AxRKuSfyfLjxJ3dCxMqyvLsiNURYWqwSZcyXAeO4HzpuBtLueRb4NYw63XEPq7guV2QENxjarRulZc32h0g+aY/AyOdI3hCVhUWQLPGaRaxjaL9sdO0QheNHhdlvKmzaRaLOI2q4gcNZW+hSF7hpfqzM5LNKGueppm0/qeZa3803Zp0vEz5RLYkDXBhNtCcVtec73Pm/yKXwKquJO4HF7KtTKwFZaxCQcYP84nXEEp1FKx5joSrpCuBlavQh6f0TzyUYvM1Mjz7fDOLH65GHBGRXpdFHMqJwk+dvJOZHVEUPj5eClhLjwcCxT+K1zUeQnt2mcNjfSWiEbB7SSkIvZA2qVgeTLtRjjzFQdUIfq7ySx5DCSNttk/1eXkHrr8js9ePkmxhonQ6wpfTEiOMpH5rHWqiH4vj67otoSo1bTTbm9Ml8aNfKLdAS1Liqj66OKycPXl8kZOPy/+vSqA1xwC9spkBEOvwjqRzWkAmNB+8t5iQL48RBha2nCMMWBlRnI0doBFQwfhXLmk6QkUB7ztVHBQ6CfXwlMhfoKUTLKvjTvW6LL5xNeh6POXvelndNHC5Y3nmnlL4k2riaa9jpOVuT7LgKsAoNHhDxYj0l0e/QPX7QJht3c9Jl94NO2ZRY7oaFPr+epao8DemrJvwJxqaE4VD20c0qZVZfSx88CLo5Eb/HBJBRSXaGSJg2xk7coNV9nV9ozleYneK2mVibx2HS+hkUWGI2T6Qe8D75KblFHF2V9TzHT+VxsZ5jDOX042cfr77CYjin45HPVvWkvj4xX3RkfGS20q0w/2dMlcRHr8Ha495ZCjrTBBWAEyxXEaX9mYkWJ4P9rBksGMm0+Y//++/U4ocm+D7NOw0ZUpeL7YKpFxr3zIURBHqN1qz0LIwGe9C9YhAzRawlM3wsSVYP4Aco7IjpCXTabpRrYN0PDUxc1L/tvCD2AgMGaxZca0jsoIU3N51b1HevJ+ngLyMuQ== X-Microsoft-Antispam-Message-Info: MWtgR5jqaHT0SZlCs56eHEqbjXqNMiw7SSxb9ytu2jFD8t9ZL1a0HIYINOHeLIGErgxExXjatSa/eqB4QUWJKxgMsJO29LBQdtwq4rhmx6euJraVqFDTpMeyNHyRcKHPUWuoIE7O5t6Ljma5IJjyKCWhsT1sDcdA0nSkoN/XQxiU3RwMyz4hnfrxf7cmy1UK33pzWIiR8ksHAoX0FneyKfJ5TZ3KmnJywb5m4yRKsoLl0gcBcXvBMsFBzxer6J1df8IKhjLvfI14ElixnELOUFogiHy8yNPXlkhaKNIyuGz4b1TUtNEN2eA0+1ozbS8ororHhsM2AIf8DVPiMTj3LKKfnLnOfLrF+a/M8m/ez0A= X-Microsoft-Exchange-Diagnostics: 1;BN7PR07MB4387;6:MseFIU5VJ3ONpMv59ilVxYtkx9WuixTyVcsj+MpVbtGq7uasWDFmw7AZgE7hzBxcIihP2ksVzE3E/1JZvV9SWXF7gWtkNs/c3hm1ihRe0yzaDsY9GGIo2ikSTSVOnFOlGQquVXo19DvHbBjfdFaR0eAFnyNPBowq4xwT5PsKz6J7m64iK259X3Yj1tYqjBciTre7krUt59gm7gxPesYgTQMawLaLjegMwHcomnHmlrfShkOvw72LvnzI0IkA6Z4/Aolr89VByw6jnzzJ86et0R0sZ0LtCBrKYscmRB5IEwFngnNTQZDeDNw15UPX7+o6ZeR9hVZskRyKgWF+42MUnDIOkiYHEwlPn5+VinwQZV+1Ra38nFaVgnzrY9Qd6omW98JhC69y9KIaXZ50RSua9Fi7k1RNSjTBifEKzSlIz+4V6wqAMhJJZvBM4HGwk6y0f4dEiZxQHkKjr/V3ZGaTYg==;5:8iJNkVVlDALUDrAmRHB5puLIdkpSNXSP0ddZozETQYkin28YNw48vLAit0p1UZHXeJPFHoyp7HgothEtftNOX2xaCSie6geFDC0lEd9cgcfVzwlzlkOEi11DHKgiJ+B0W4XT9V0spn0Ycv/WpRD2naPpY61fHel8fa+ey8e398I=;7:erHktgGtuS7tX78tQjOwvoNy+XNSQyk2n6msEyz1/LeGDnn1p7hOqiz2tBJ9UtxWLzTKhu1OUpi3waz1RpkrwZ7b9q4ytDjZMzwD1xph7PaUKdtLayLjQddTcYtAaQ1FYAeeolWy2d3d31ObC0bplOoKmA6xPUuW4FOQQmfIdXJW2O7Ry49joQOdR8BXJCmgktj+lVScRf7zvCPh+Qr89LJGEMafvlkE3TwN2R80aPhNokoEyBfbNBW7e8xOPjCK SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2018 16:35:56.1694 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6cb37193-75a6-4284-3d15-08d60e96a916 X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194;Ip=[50.232.66.26];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4387 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fixes: 6246b8a1d26c7c ("[SCSI] qla2xxx: Enhancements to support ISP83xx.") Fixes: 1bb395485160d2 ("qla2xxx: Correct iiDMA-update calling conventions.") Cc: Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mbx.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index 2c6c2cd5a0d0..c73039916c03 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -3762,10 +3762,7 @@ qla2x00_set_idma_speed(scsi_qla_host_t *vha, uint16_t loop_id, mcp->mb[0] = MBC_PORT_PARAMS; mcp->mb[1] = loop_id; mcp->mb[2] = BIT_0; - if (IS_CNA_CAPABLE(vha->hw)) - mcp->mb[3] = port_speed & (BIT_5|BIT_4|BIT_3|BIT_2|BIT_1|BIT_0); - else - mcp->mb[3] = port_speed & (BIT_2|BIT_1|BIT_0); + mcp->mb[3] = port_speed & (BIT_5|BIT_4|BIT_3|BIT_2|BIT_1|BIT_0); mcp->mb[9] = vha->vp_idx; mcp->out_mb = MBX_9|MBX_3|MBX_2|MBX_1|MBX_0; mcp->in_mb = MBX_3|MBX_1|MBX_0;